upgrade Bootstrap to 4 #566

keshav234156 · 2020-07-18T19:34:24Z

#508
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt jasmine
code is in uniquely-named feature branch and has no merge conflicts
PR is descriptively titled
PR body includes fixes #0000-style reference to original issue #
ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

gitpod-io · 2020-07-18T19:34:29Z

keshav234156 · 2020-07-18T20:17:58Z

@jywarren @sagarpreet-chadha @NitinBhasneria @Shreyaa-s @Shulammite-Aso Please review. We can leave the passing of jest-puppeteer test as of now. The test are correct and are passing locally but it look like travis run with --runInBand to fasten te process which fails the test.locally it can be simulated by node ./node_modules/.bin/jest --runInBand . I have also added changes to Gruntfile.js(made it as it was prior to #519 ) and added it to eslintignore as process were not running related to grunt because of it.

keshav234156 · 2020-07-18T20:20:23Z

Also, I have made this new PR (previous PR #561) because my previous forked repo was having too much problem with test and all branches were messed up (I don't why 😕 ?).

sagarpreet-chadha

Looks great 💯

sagarpreet-chadha · 2020-07-19T09:46:14Z

@keshav234156 , did you find any way we can remove this param from travis so that the tests can pass? Thanks!

keshav234156 · 2020-07-19T14:29:02Z

@sagarpreet-chadha Not yet!!

cypherean · 2020-07-20T13:39:42Z

I can replicate it locally but why is it triggered on selected PRs? And persists even on restarting travis? Do you have any idea why is it so @keshav234156?

jywarren · 2020-07-21T19:17:38Z

If you get really stuck here, perhaps you might reach out to icarito or alaxalves! Thanks for working hard on this, and if at all possible I recommend following conventions established by Travis and Jest, and linking to them so folks can follow along. Thank you!

…into bootstrap14

keshav234156 · 2020-07-28T16:08:09Z

@Shreyaa-s Can you please have a look at these tests as well !!

cypherean · 2020-07-28T19:52:52Z

I tried but for this one the last line, i.e. await page.click('.woofmark-mode-wysiwyg'); isn't working. The mode doesn't change. The safeguard added for that in the starting of test works. But in this case the starting of the text gets selected and is changed to bold/italic that's why it couldn't find the string specified since we format the existing selected text, the test only fails for whichever test comes second. There are a few options we could try:

Converting to md and checking for * or _.
Adding await page.evaluate(() => document.querySelector('.wk-wysiwyg').textContent += ' '); but this makes the rest of the text loose all formatting, like this:
backspace the selected text.
I wasn't able to figure out why the change mode button didn't work, if anyone can that would be great help. And if we can implement anyone one of these, which one should it be?

jywarren · 2020-08-04T14:56:43Z

Hi @keshav234156 just wondering if you had a chance to try one of @shreyaa-sharmaa's ideas above? Did any of them work?

…into bootstrap14

keshav234156 · 2020-08-06T07:56:52Z

fixed test for bold and italic by backspace. Now need to find a fix for center text.

keshav234156 · 2020-08-06T08:15:24Z

fixed center test as well!!
@jywarren Please review.

gitpod-io · 2020-08-07T05:27:24Z

test/ui-testing/bold.test.js

sagarpreet-chadha

Good to go after removal of screenshot commands 🎉

keshav234156 · 2020-08-11T15:07:23Z

@jywarren Ok doing it now!

gitpod-io · 2020-08-17T10:10:39Z

gitpod-io · 2020-08-18T12:07:59Z

gitpod-io · 2020-08-18T13:01:46Z

keshav234156 · 2020-08-18T13:02:31Z

@jywarren Can you please see why test are not starting

gitpod-io · 2020-08-18T18:11:08Z

jywarren · 2020-08-19T20:24:28Z

Hi, @keshav234156 - one thing that can happen sometimes is that it's easier to just rebase the whole thing cleanly to get Travis to restart. It looks like there's something odd going on here even with GitPod leaving so many comments. Can you try a clean rebase?

jywarren · 2020-08-26T02:39:14Z

Gruntfile.js


-  require('matchdep').filterDev('grunt-*').forEach(grunt.loadNpmTasks);
+    grunt.loadNpmTasks('grunt-browserify');


Uh oh - were these commits supposed to make it into here? Just checking!

Ah, i see here! all good then! #566 (comment)

jywarren · 2020-08-26T02:42:51Z

Hi! Almost there -- i see a few small issues!

I see a small issue with the "Help" icon here:

And the Use current location button needs an outline, as do a few other buttons. I think they work better with outlines otherwise they are hard to see as buttons, you know?

The history button too:

@keshav234156 I think this will be all good once you can make these tweaks, thank you so much!!!

jywarren

Just noting that we need a few Bootstrap CSS fixes. Thanks!!!

jywarren · 2020-09-15T19:42:37Z

Hi @keshav234156 i hope you're well! Do you think you'll have any time to wrap this issue up, or do you think it'd be best if someone else took a look at it? Thank you!!!

Sagarpreet · 2020-10-13T10:20:37Z

Moved here: #636
Thanks @keshav234156 💯

upgrade Bootstrap4

af5d275

testing with test changes

a9d00cb

sagarpreet-chadha approved these changes Jul 19, 2020

View reviewed changes

keshav234156 added 2 commits July 28, 2020 21:24

Merge branch 'main' of https://github.com/publiclab/PublicLab.Editor …

2c16fdc

…into bootstrap14

fix test

48616e5

cypherean mentioned this pull request Jul 29, 2020

GSoC / Outreachy Editor Project Planning Issues and General Disscussion #490

Open

35 tasks

keshav234156 added 2 commits August 6, 2020 12:48

Merge branch 'main' of https://github.com/publiclab/PublicLab.Editor …

77794cb

…into bootstrap14

fix test

7465e7b

fix center text

eb021b3

keshav234156 closed this Aug 7, 2020

keshav234156 reopened this Aug 7, 2020

cypherean reviewed Aug 7, 2020

View reviewed changes

test/ui-testing/bold.test.js Outdated Show resolved Hide resolved

sagarpreet-chadha approved these changes Aug 7, 2020

View reviewed changes

sgdev11 approved these changes Aug 8, 2020

View reviewed changes

pydevsg self-requested a review August 8, 2020 08:24

pydevsg approved these changes Aug 8, 2020

View reviewed changes

remove screenshort command

b266f37

keshav234156 added 4 commits August 11, 2020 20:39

fix conflict

abe2ed9

fix conflict

5092f84

fix test

fbc2c37

fix test

96bbe73

keshav234156 closed this Aug 17, 2020

keshav234156 reopened this Aug 17, 2020

fix conflict

65fffea

keshav234156 closed this Aug 18, 2020

keshav234156 reopened this Aug 18, 2020

keshav234156 closed this Aug 18, 2020

keshav234156 reopened this Aug 18, 2020

keshav234156 closed this Aug 18, 2020

keshav234156 reopened this Aug 18, 2020

keshav234156 added 2 commits August 20, 2020 02:10

fix conflict

1fdcb42

fix conflict

52749f2

Shulammite-Aso approved these changes Aug 24, 2020

View reviewed changes

jywarren reviewed Aug 26, 2020

View reviewed changes

jywarren requested changes Aug 26, 2020

View reviewed changes

Sagarpreet mentioned this pull request Oct 7, 2020

Tracking Editor features 🧨 #627

Closed

14 tasks

sagarpreet-chadha closed this Oct 13, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upgrade Bootstrap to 4 #566

upgrade Bootstrap to 4 #566

keshav234156 commented Jul 18, 2020

gitpod-io bot commented Jul 18, 2020 •

edited

Loading

keshav234156 commented Jul 18, 2020 •

edited

Loading

keshav234156 commented Jul 18, 2020

sagarpreet-chadha left a comment

sagarpreet-chadha commented Jul 19, 2020

keshav234156 commented Jul 19, 2020

cypherean commented Jul 20, 2020

jywarren commented Jul 21, 2020

keshav234156 commented Jul 28, 2020 •

edited

Loading

cypherean commented Jul 28, 2020 •

edited

Loading

jywarren commented Aug 4, 2020

keshav234156 commented Aug 6, 2020 •

edited

Loading

keshav234156 commented Aug 6, 2020

gitpod-io bot commented Aug 7, 2020

sagarpreet-chadha left a comment

keshav234156 commented Aug 11, 2020

gitpod-io bot commented Aug 17, 2020

gitpod-io bot commented Aug 18, 2020

gitpod-io bot commented Aug 18, 2020

keshav234156 commented Aug 18, 2020

gitpod-io bot commented Aug 18, 2020

jywarren commented Aug 19, 2020

jywarren Aug 26, 2020

jywarren Aug 26, 2020

jywarren commented Aug 26, 2020

jywarren left a comment

jywarren commented Sep 15, 2020

Sagarpreet commented Oct 13, 2020


		require('matchdep').filterDev('grunt-*').forEach(grunt.loadNpmTasks);
		grunt.loadNpmTasks('grunt-browserify');

upgrade Bootstrap to 4 #566

upgrade Bootstrap to 4 #566

Conversation

keshav234156 commented Jul 18, 2020

gitpod-io bot commented Jul 18, 2020 • edited Loading

keshav234156 commented Jul 18, 2020 • edited Loading

keshav234156 commented Jul 18, 2020

sagarpreet-chadha left a comment

Choose a reason for hiding this comment

sagarpreet-chadha commented Jul 19, 2020

keshav234156 commented Jul 19, 2020

cypherean commented Jul 20, 2020

jywarren commented Jul 21, 2020

keshav234156 commented Jul 28, 2020 • edited Loading

cypherean commented Jul 28, 2020 • edited Loading

jywarren commented Aug 4, 2020

keshav234156 commented Aug 6, 2020 • edited Loading

keshav234156 commented Aug 6, 2020

gitpod-io bot commented Aug 7, 2020

sagarpreet-chadha left a comment

Choose a reason for hiding this comment

keshav234156 commented Aug 11, 2020

gitpod-io bot commented Aug 17, 2020

gitpod-io bot commented Aug 18, 2020

gitpod-io bot commented Aug 18, 2020

keshav234156 commented Aug 18, 2020

gitpod-io bot commented Aug 18, 2020

jywarren commented Aug 19, 2020

jywarren Aug 26, 2020

Choose a reason for hiding this comment

jywarren Aug 26, 2020

Choose a reason for hiding this comment

jywarren commented Aug 26, 2020

jywarren left a comment

Choose a reason for hiding this comment

jywarren commented Sep 15, 2020

Sagarpreet commented Oct 13, 2020

gitpod-io bot commented Jul 18, 2020 •

edited

Loading

keshav234156 commented Jul 18, 2020 •

edited

Loading

keshav234156 commented Jul 28, 2020 •

edited

Loading

cypherean commented Jul 28, 2020 •

edited

Loading

keshav234156 commented Aug 6, 2020 •

edited

Loading