Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding video slider for beginners ( using swiper ) #153

Closed
wants to merge 9 commits into from

Conversation

subhahu123
Copy link
Contributor

@subhahu123 subhahu123 commented Mar 9, 2019

Fixes : #162

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

After changes

screenshot-127 0 0 1-5500-2019 03 09-19-46-20

screenshot-127 0 0 1-5500-2019 03 09-20-00-41

@subhahu123
Copy link
Contributor Author

@jywarren @publiclab/reviewers please review

@subhahu123 subhahu123 changed the title Adding video slider for beginners Adding video slider for beginners ( using swiper ) Mar 9, 2019
Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A suggestion, can the videos be updated dynamically instead of hardcoding some videos?

index.html Show resolved Hide resolved
@subhahu123
Copy link
Contributor Author

subhahu123 commented Mar 9, 2019

A suggestion, can the videos be updated dynamically instead of hardcoding some videos?

can't say much right now
but it require a list of videos which changes dynamically
list should contain only beginners videos
This requires using youtube API for getting videos with beginner for open source search and an js which automaically generated html for them

we can do this ......... @harshkhandeparkar

@harshkhandeparkar
Copy link
Member

harshkhandeparkar commented Mar 9, 2019 via email

@subhahu123
Copy link
Contributor Author

subhahu123 commented Mar 9, 2019

How about getting videos from a specific channel like gitKraken which provides git tutorials or how about maintaining a custom playlist on youtube which can be changed as required and the same playlist be displayed on the website?

On Sat 9 Mar, 2019, 8:18 PM subhahu, @.***> wrote: A suggestion, can the videos be updated dynamically instead of hardcoding some videos? can't say much right now but it require a list of videos which changes dynamically list should contain only beginners videos This requires using youtube API for getting videos with beginner for open source search and an js which automaically generated html for them — You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub <#153 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/AhKOn8hZJNQBGdhf4_XZ35F8IjOh203gks5vU8m0gaJpZM4bmtA0 .

does it provides api for that
if yes , then we can
otherwise there will be CORS issue
@harshkhandeparkar

@harshkhandeparkar
Copy link
Member

If it does provide an API for that, who will maintain the playlist or on whose channel is the question? Does PL have a channel? @jywarren?

@subhahu123
Copy link
Contributor Author

subhahu123 commented Mar 9, 2019

If it does provide an API for that, who will maintain the playlist or on whose channel is the question? Does PL have a channel? @jywarren?

This same can be done on youtube channel or playlist
@harshkhandeparkar

@harshkhandeparkar
Copy link
Member

But whose channel? And who will manage the videos/playlist?

@subhahu123
Copy link
Contributor Author

But whose channel? And who will manage the videos/playlist?

?

@harshkhandeparkar
Copy link
Member

@jywarren does PL have a youtube channel? If not, can we create one which has all sorts of beginner github tutorials etc. Playlists?

@subhahu123
Copy link
Contributor Author

@jywarren does PL have a youtube channel? If not, can we create one which has all sorts of beginner github tutorials etc. Playlists?

Yes @harshithpabbati

@harshkhandeparkar
Copy link
Member

I just checked, PL does have a channel

@subhahu123
Copy link
Contributor Author

subhahu123 commented Mar 9, 2019

I just checked, PL does have a channel

public lab can have their own videos for beginners @harshithpabbati

@harshkhandeparkar
Copy link
Member

Its HarshKhandeparkar not Harshithpabbati

@subhahu123
Copy link
Contributor Author

subhahu123 commented Mar 9, 2019

Its HarshKhandeparkar not Harshithpabbati

sry i was hitting enter on autolist @harshkhandeparkar

@harshkhandeparkar
Copy link
Member

harshkhandeparkar commented Mar 9, 2019

Who can manage the playlist? And how will someone sort out the vids? How about opening an issue here where people can propose changes to the playlist and after discussion, someone can do the changes. @jywarren is this possible?

@subhahu123
Copy link
Contributor Author

go for it (opening issue) @harshkhandeparkar

@harshkhandeparkar
Copy link
Member

I guess we should wait for jywarren's approval.

@subhahu123
Copy link
Contributor Author

@jywarren @gauravano please review this

examples/demo.css Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@grvsachdeva
Copy link
Member

Hey @subhahu123, thanks for great work, but I think, this needs @jywarren's consent as it's a whole new section. Regarding code, I have left some comments. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create video slider for beginners to open source
3 participants