-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding video slider for beginners ( using swiper ) #153
Conversation
@jywarren @publiclab/reviewers please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A suggestion, can the videos be updated dynamically instead of hardcoding some videos?
can't say much right now we can do this ......... @harshkhandeparkar |
How about getting videos from a specific channel like gitKraken which
provides git tutorials or how about maintaining a custom playlist on
youtube which can be changed as required and the same playlist be displayed
on the website?
…On Sat 9 Mar, 2019, 8:18 PM subhahu, ***@***.***> wrote:
A suggestion, can the videos be updated dynamically instead of hardcoding
some videos?
can't say much right now
but it require a list of videos which changes dynamically
list should contain only beginners videos
This requires using youtube API for getting videos with beginner for open
source search and an js which automaically generated html for them
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#153 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AhKOn8hZJNQBGdhf4_XZ35F8IjOh203gks5vU8m0gaJpZM4bmtA0>
.
|
does it provides api for that |
If it does provide an API for that, who will maintain the playlist or on whose channel is the question? Does PL have a channel? @jywarren? |
This same can be done on youtube channel or playlist |
But whose channel? And who will manage the videos/playlist? |
? |
@jywarren does PL have a youtube channel? If not, can we create one which has all sorts of beginner github tutorials etc. Playlists? |
Yes @harshithpabbati |
I just checked, PL does have a channel |
public lab can have their own videos for beginners @harshithpabbati |
Its HarshKhandeparkar not Harshithpabbati |
sry i was hitting enter on autolist @harshkhandeparkar |
Who can manage the playlist? And how will someone sort out the vids? How about opening an issue here where people can propose changes to the playlist and after discussion, someone can do the changes. @jywarren is this possible? |
go for it (opening issue) @harshkhandeparkar |
I guess we should wait for jywarren's approval. |
@jywarren @gauravano please review this |
Hey @subhahu123, thanks for great work, but I think, this needs @jywarren's consent as it's a whole new section. Regarding code, I have left some comments. Thanks! |
Fixes : #162
rake test
fixes #0000
-style reference to original issue #@publiclab/reviewers
for help, in a comment belowAfter changes