Make Select a module functionality responsive. #1092

Divy123 · 2019-05-28T20:09:29Z

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

Currently the "Select a module" button is not responsive at all. What we want in this issue is to make that reponsive. This is a simple UI part and the files that can be referred to are:

demo.css
selectize.default.css

🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
💾 Commit your changes
🔀 Start a Pull Request. There are two ways how you can start a pull request:

If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.

🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

o0sarthak0o · 2019-05-31T06:39:06Z

Hey, can I take up this issue?

harshkhandeparkar · 2019-05-31T13:31:44Z

Sure

o0sarthak0o · 2019-05-31T15:09:59Z

@Divy123 @harshkhandeparkar please assign this one to me then.. thanks :D

harshkhandeparkar · 2019-05-31T15:23:49Z

Just go ahead and work on it.

…

On Fri 31 May, 2019, 8:40 PM o0sarthak0o, ***@***.***> wrote: @Divy123 <https://github.com/Divy123> @harshkhandeparkar <https://github.com/HarshKhandeparkar> please assign this one to me then.. thanks :D — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1092?email_source=notifications&email_token=AIJI5H2PXVV2ZDLYHDFWZ53PYE5URA5CNFSM4HQGVWD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWVPVPQ#issuecomment-497744574>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIJI5H26D2RFQVLMUTOV4V3PYE5URANCNFSM4HQGVWDQ> .

o0sarthak0o · 2019-06-01T05:51:19Z

npm install is giving me error for this... Any suggestions?

gl@4.2.2 install C:\Users\Sarthak Agarwal\image-sequencer\node_modules\gl
prebuild-install || node-gyp rebuild

prebuild-install WARN install No prebuilt binaries found (target=10.15.0 runtime=node arch=x64 libc= platform=win32)

C:\Users\Sarthak Agarwal\image-sequencer\node_modules\gl>if not defined npm_config_node_gyp (node "C:\Program Files\nodejs\node_modules\npm\node_modules\npm-lifecycle\node-gyp-bin\....\node_modules\node-gyp\bin\node-gyp.js" rebuild ) else (node "C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" rebuild )
gyp ERR! configure error
gyp ERR! stack Error: Command failed: C:\Users\Sarthak Agarwal\AppData\Local\Programs\Python\Python36-32\python.EXE -c import sys; print "%s.%s.%s" % sys.version_info[:3];
gyp ERR! stack File "", line 1
gyp ERR! stack import sys; print "%s.%s.%s" % sys.version_info[:3];
gyp ERR! stack ^
gyp ERR! stack SyntaxError: invalid syntax
gyp ERR! stack
gyp ERR! stack at ChildProcess.exithandler (child_process.js:294:12)
gyp ERR! stack at ChildProcess.emit (events.js:182:13)
gyp ERR! stack at maybeClose (internal/child_process.js:962:16)
gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:251:5)
gyp ERR! System Windows_NT 10.0.17763
gyp ERR! command "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" "rebuild"
gyp ERR! cwd C:\Users\Sarthak Agarwal\image-sequencer\node_modules\gl
gyp ERR! node -v v10.15.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
npm WARN acorn-jsx@5.0.1 requires a peer of acorn@^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN The package eslint is included as both a dev and production dependency.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.7 (node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.7: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! gl@4.2.2 install: prebuild-install || node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the gl@4.2.2 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\Sarthak Agarwal\AppData\Roaming\npm-cache_logs\2019-06-01T05_40_05_617Z-debug.log

pmansukhani · 2019-06-24T19:27:32Z

First timer here. Can I take this up?

Divy123 · 2019-06-24T21:03:58Z

#1127

vaibhavmatta · 2019-08-09T20:11:40Z

npm install is giving me error for this... Any suggestions?

gl@4.2.2 install C:\Users\Sarthak Agarwal\image-sequencer\node_modules\gl
prebuild-install || node-gyp rebuild

prebuild-install WARN install No prebuilt binaries found (target=10.15.0 runtime=node arch=x64 libc= platform=win32)

C:\Users\Sarthak Agarwal\image-sequencer\node_modules\gl>if not defined npm_config_node_gyp (node "C:\Program Files\nodejs\node_modules\npm\node_modules\npm-lifecycle\node-gyp-bin....\node_modules\node-gyp\bin\node-gyp.js" rebuild ) else (node "C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" rebuild )
gyp ERR! configure error
gyp ERR! stack Error: Command failed: C:\Users\Sarthak Agarwal\AppData\Local\Programs\Python\Python36-32\python.EXE -c import sys; print "%s.%s.%s" % sys.version_info[:3];
gyp ERR! stack File "", line 1
gyp ERR! stack import sys; print "%s.%s.%s" % sys.version_info[:3];
gyp ERR! stack ^
gyp ERR! stack SyntaxError: invalid syntax
gyp ERR! stack
gyp ERR! stack at ChildProcess.exithandler (child_process.js:294:12)
gyp ERR! stack at ChildProcess.emit (events.js:182:13)
gyp ERR! stack at maybeClose (internal/child_process.js:962:16)
gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:251:5)
gyp ERR! System Windows_NT 10.0.17763
gyp ERR! command "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" "rebuild"
gyp ERR! cwd C:\Users\Sarthak Agarwal\image-sequencer\node_modules\gl
gyp ERR! node -v v10.15.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
npm WARN acorn-jsx@5.0.1 requires a peer of acorn@^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN The package eslint is included as both a dev and production dependency.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.7 (node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.7: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! gl@4.2.2 install: prebuild-install || node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the gl@4.2.2 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\Sarthak Agarwal\AppData\Roaming\npm-cache_logs\2019-06-01T05_40_05_617Z-debug.log

just after npm install,
run :
npm install gl --force

it will forcefully install the gl dependency in your local repository .
Tell if it works,
Thanks

vaibhavmatta · 2019-08-09T20:14:39Z

Just go ahead and work on it.
…
On Fri 31 May, 2019, 8:40 PM o0sarthak0o, @.***> wrote: @Divy123 https://github.com/Divy123 @harshkhandeparkar https://github.com/HarshKhandeparkar please assign this one to me then.. thanks :D — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1092?email_source=notifications&email_token=AIJI5H2PXVV2ZDLYHDFWZ53PYE5URA5CNFSM4HQGVWD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWVPVPQ#issuecomment-497744574>, or mute the thread https://github.com/notifications/unsubscribe-auth/AIJI5H26D2RFQVLMUTOV4V3PYE5URANCNFSM4HQGVWDQ .

@harshkhandeparkar It is responsive now I think. Please tell if I'm wrong.

harshkhandeparkar · 2019-08-23T15:50:12Z

@vaibhavmatta are you referring to the pr? #1208

vaibhavmatta · 2019-08-23T15:56:18Z

@harshkhandeparkar Yes ! Was out of town since a week. Now regularly working on it.
Thanks

harshkhandeparkar · 2019-08-23T15:58:13Z

You could leave a review on the PR and ask @jywarren to merge it.

…

On Fri, 23 Aug, 2019, 9:26 PM vaibhavmatta, ***@***.***> wrote: @harshkhandeparkar <https://github.com/HarshKhandeparkar> Yes ! Was out of town since a week. Now regularly working on it. Thanks — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1092?email_source=notifications&email_token=AIJI5HZ6R6XFR5SEGV6AHZTQGACCJA5CNFSM4HQGVWD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5ATT5A#issuecomment-524368372>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIJI5HYHR7U42NX732CUHJDQGACCJANCNFSM4HQGVWDQ> .

vaibhavmatta · 2019-08-23T16:01:54Z

Alright 🙂

keshav234156 · 2019-08-23T16:23:54Z

@harshkhandeparkar for PR #1208 changes has already been approved by @jywarren and has asked you and @Divy123 to review it.Can you please do the same!!

harshkhandeparkar · 2019-08-23T16:26:04Z

I'll do once I am free. Probably today.

…

On Fri, 23 Aug, 2019, 9:53 PM keshav234156, ***@***.***> wrote: @harshkhandeparkar <https://github.com/HarshKhandeparkar> changes has already been approved by @jywarren <https://github.com/jywarren> and has asked you and @Divy123 <https://github.com/Divy123> to review it.Can you please do the same!! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1092?email_source=notifications&email_token=AIJI5H2MG4ZGN4PUCFPDA33QGAFJZA5CNFSM4HQGVWD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5AV3LA#issuecomment-524377516>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIJI5H7XZB5ZX3YDVWWOHZLQGAFJZANCNFSM4HQGVWDQ> .

vaibhavmatta · 2019-08-23T16:47:18Z

So should I do it or not? @keshav234156 @harshkhandeparkar

harshkhandeparkar · 2019-08-23T16:51:03Z

Sure @vaibhavmatta. Your review is important.

vaibhavmatta · 2019-08-23T16:52:44Z

Alright, I will do it asap 🙂 @harshkhandeparkar

Divy123 added first-timers-only UI labels May 28, 2019

keshav234156 mentioned this issue Aug 13, 2019

make select a module responsive #1208

Merged

4 tasks

jywarren closed this as completed in #1208 Aug 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make Select a module functionality responsive. #1092

Make Select a module functionality responsive. #1092

Divy123 commented May 28, 2019

o0sarthak0o commented May 31, 2019

harshkhandeparkar commented May 31, 2019

o0sarthak0o commented May 31, 2019

harshkhandeparkar commented May 31, 2019 via email

o0sarthak0o commented Jun 1, 2019

pmansukhani commented Jun 24, 2019

Divy123 commented Jun 24, 2019

vaibhavmatta commented Aug 9, 2019

vaibhavmatta commented Aug 9, 2019 •

edited

Loading

harshkhandeparkar commented Aug 23, 2019

vaibhavmatta commented Aug 23, 2019

harshkhandeparkar commented Aug 23, 2019 via email

vaibhavmatta commented Aug 23, 2019

keshav234156 commented Aug 23, 2019 •

edited

Loading

harshkhandeparkar commented Aug 23, 2019 via email

vaibhavmatta commented Aug 23, 2019

harshkhandeparkar commented Aug 23, 2019

vaibhavmatta commented Aug 23, 2019

Make Select a module functionality responsive. #1092

Make Select a module functionality responsive. #1092

Comments

Divy123 commented May 28, 2019

🤔 What you will need to know.

📋 Step by Step

Please keep us updated

Is someone else already working on this?

🤔❓ Questions?

o0sarthak0o commented May 31, 2019

harshkhandeparkar commented May 31, 2019

o0sarthak0o commented May 31, 2019

harshkhandeparkar commented May 31, 2019 via email

o0sarthak0o commented Jun 1, 2019

pmansukhani commented Jun 24, 2019

Divy123 commented Jun 24, 2019

vaibhavmatta commented Aug 9, 2019

vaibhavmatta commented Aug 9, 2019 • edited Loading

harshkhandeparkar commented Aug 23, 2019

vaibhavmatta commented Aug 23, 2019

harshkhandeparkar commented Aug 23, 2019 via email

vaibhavmatta commented Aug 23, 2019

keshav234156 commented Aug 23, 2019 • edited Loading

harshkhandeparkar commented Aug 23, 2019 via email

vaibhavmatta commented Aug 23, 2019

harshkhandeparkar commented Aug 23, 2019

vaibhavmatta commented Aug 23, 2019

vaibhavmatta commented Aug 9, 2019 •

edited

Loading

keshav234156 commented Aug 23, 2019 •

edited

Loading