Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make select a module responsive #1208

Merged
merged 3 commits into from
Aug 26, 2019
Merged

make select a module responsive #1208

merged 3 commits into from
Aug 26, 2019

Conversation

keshav234156
Copy link
Member

@keshav234156 keshav234156 commented Aug 13, 2019

Fixes #1092
Fixes #1049
In this PR select a module buttons and other button had been made responsive.There were some css related issue,which had also been fixed in this PR.In narrow view often the content of button is not at the place where it' suppose to be.That issues are also fixed.
Before changes
Screenshot from 2019-08-13 22-54-45

Screenshot from 2019-08-13 22-54-39
Screenshot from 2019-08-13 22-53-40

After changes
Screenshot from 2019-08-13 22-53-31

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Aug 13, 2019

Thanks for opening this pull request!
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@codecov
Copy link

codecov bot commented Aug 13, 2019

Codecov Report

Merging #1208 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1208   +/-   ##
=======================================
  Coverage   55.11%   55.11%           
=======================================
  Files         117      117           
  Lines        2344     2344           
  Branches      360      360           
=======================================
  Hits         1292     1292           
  Misses       1052     1052

@keshav234156
Copy link
Member Author

@Divy123 @aashna27 can you please review!!

@keshav234156
Copy link
Member Author

@jywarren can you please review!!

@jywarren
Copy link
Member

Hi, just updated the branch and requested a couple other reviews. This looks great to me, just want to be sure and hear from others! Thank you!!!

Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Works flawlessly. Thank you!

@keshav234156
Copy link
Member Author

@jywarren can you please merge this PR

@jywarren jywarren merged commit 6613af8 into publiclab:main Aug 26, 2019
@welcome
Copy link

welcome bot commented Aug 26, 2019

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will be published to https://beta.sequencer.publiclab.org in a day or two.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

@jywarren
Copy link
Member

Awesome, thank you!!!!

@jywarren
Copy link
Member

Would you have any interest in helping to make our editor on PublicLab.org (a related project) a little more mobile-friendly? publiclab/plots2#4776 captures one issue. But in general we'd love help getting the mobile view of the editor a little more compact for small screens!

@keshav234156
Copy link
Member Author

@jywarren .would like to work on this issue. i think the problem of appearring toolbar infront of prompt has already been fixed in PublicLab.Editor/pull/248.Is it what is expected behaviour(that already present as of now) or anything other than this is expected behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Select a module functionality responsive. Fix Dropdown Width
3 participants