Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module Selector dropdown showing error in console #1531

Closed
3 tasks
rishabhshuklax opened this issue Jan 17, 2020 · 6 comments · Fixed by #1543
Closed
3 tasks

Module Selector dropdown showing error in console #1531

rishabhshuklax opened this issue Jan 17, 2020 · 6 comments · Fixed by #1543

Comments

@rishabhshuklax
Copy link
Member

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

What is to be done?

After searching module name in module search input if we clear the input field a error is shown in console, try to remove that error. Refer to below GIF for more info!

err

Files to refer to:

function selectNewStepUi() {

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

@ss62171
Copy link

ss62171 commented Jan 19, 2020

I would like to work on this issue.

@harshkhandeparkar
Copy link
Member

Sure

ss62171 added a commit to ss62171/image-sequencer that referenced this issue Jan 19, 2020
@bajajvinamr
Copy link

I would like to work on this issue.

bajajvinamr added a commit to bajajvinamr/image-sequencer that referenced this issue Sep 3, 2020
Fixed Module Selector dropdown showing error in console publiclab#1531
jywarren added a commit that referenced this issue Oct 1, 2020
Fixed Module Selector dropdown showing error in console #1531

Co-authored-by: Jeffrey Warren <jeff@unterbahn.com>
@GuptaTanisha
Copy link

@blurry-x-face Is this issue open?

@SharmaTanish
Copy link

Hi @blurry-x-face ! I am very exited to work on this issue , if it is still open . I have learnt web development from coding ninjas and all my basic concepts are clear . I am very hardworking and have scored 94.2% in 12th . You can also go through my linkedIn profile - https://www.linkedin.com/in/tanish-a54b771b3 .
Looking forward for your reply .

@jywarren
Copy link
Member

Hi all, can we try to confirm if this is still happening by running https://sequencer.publiclab.org with the JS console open? Then we can see if we need to close it.

Thanks everyone for being helpful! And, welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants