Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Module Selector Console Error #1543

Merged
merged 9 commits into from
Sep 14, 2021
Merged

Conversation

ss62171
Copy link

@ss62171 ss62171 commented Jan 19, 2020

Fixes #1531 (<=== Replace 0000 with the Issue Number)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@welcome
Copy link

welcome bot commented Jan 19, 2020

Thanks for opening this pull request!
There may be some errors, but don't worry! We're here to help! 👍🎉😄

3 similar comments
@welcome
Copy link

welcome bot commented Jan 19, 2020

Thanks for opening this pull request!
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@welcome
Copy link

welcome bot commented Jan 19, 2020

Thanks for opening this pull request!
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@welcome
Copy link

welcome bot commented Jan 19, 2020

Thanks for opening this pull request!
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@ss62171 ss62171 requested a review from aashna27 January 19, 2020 21:03
@codecov
Copy link

codecov bot commented Jan 19, 2020

Codecov Report

Merging #1543 (11f9126) into main (853e719) will decrease coverage by 1.26%.
The diff coverage is 12.90%.

❗ Current head 11f9126 differs from pull request most recent head d0f21d2. Consider uploading reports for the commit d0f21d2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1543      +/-   ##
==========================================
- Coverage   66.67%   65.41%   -1.27%     
==========================================
  Files         130      132       +2     
  Lines        2686     2741      +55     
  Branches      433      438       +5     
==========================================
+ Hits         1791     1793       +2     
- Misses        895      948      +53     
Impacted Files Coverage Δ
src/Modules.js 100.00% <ø> (ø)
src/modules/EdgeDetect/Module.js 100.00% <ø> (ø)
src/modules/WebglDistort/Module.js 2.29% <0.00%> (ø)
src/modules/ColorHalftone/Module.js 3.63% <3.63%> (ø)
src/modules/ColorHalftone/index.js 100.00% <100.00%> (ø)
src/modules/EdgeDetect/EdgeUtils.js 86.81% <100.00%> (-0.15%) ⬇️

@harshkhandeparkar harshkhandeparkar changed the title Fixes #1531 Fixes Module Selector Console Error Jan 20, 2020
@ss62171
Copy link
Author

ss62171 commented Jan 21, 2020

@harshkhandeparkar can you please review this.

Copy link
Member

@rishabhshuklax rishabhshuklax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gitpod-io
Copy link

gitpod-io bot commented Jul 8, 2020

@harshkhandeparkar harshkhandeparkar requested a review from a team as a code owner October 15, 2020 19:45
@harshkhandeparkar harshkhandeparkar added this to In Progress in v3.7.0 via automation Jul 27, 2021
@gitpod-io
Copy link

gitpod-io bot commented Jul 27, 2021

@jywarren jywarren merged commit f2a696a into publiclab:main Sep 14, 2021
v3.7.0 automation moved this from In Progress to Done Sep 14, 2021
@welcome
Copy link

welcome bot commented Sep 14, 2021

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will be published to https://beta.sequencer.publiclab.org in a day or two. Please test out your work on this testing server and report back with a comment that all has gone well!
In the meantime, can you tell us your Twitter handle so we can thank you properly also do join our weekly check-in to share your this week goal and the awesome work you did 😃.
Please find the link pinned in the issue section
Now that you've completed this, you can help someone else take their first step! Try looking at this list of first-timers-only issues, and see if someone else is waiting for feedback, or even stuck! 😕
People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉
See: Public Lab's coding community!

@jywarren
Copy link
Member

Thank you so much!!!! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v3.7.0
  
Done
Development

Successfully merging this pull request may close these issues.

Module Selector dropdown showing error in console
4 participants