Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Save as module" button on Dynamic module #231

Open
jywarren opened this issue Apr 30, 2018 · 9 comments
Open

"Save as module" button on Dynamic module #231

jywarren opened this issue Apr 30, 2018 · 9 comments

Comments

@jywarren
Copy link
Member

screen shot 2018-04-30 at 2 36 49 pm

I used the Dynamic module to generate a unique filter, and thought "this would be nice to save as a module in its own right, for others to use". Sounds like a good way to generate a new module. Could this work as part of #200 meta modules, or #190 module importing.

This issue could then be added afterwards -- but I would love to be able to add a button that prompts you to save your dynamic module settings as a new module in its own right -- Save as module!

@jywarren
Copy link
Member Author

GitMate.io thinks the contributor most likely able to help you is @tech4GT.

Possibly related issues are #108 (Math Module), #201 (Allow easier access to neighboring pixels in Dynamic module), #112 (Scale module), #146 (Monochrome "fallback" on Dynamic module not working), and #5 (image cropping module).

@tech4GT
Copy link
Member

tech4GT commented Jul 25, 2018

@jywarren This can now be done very nicely after #308 where we have a button Save Sequence which saves the current sequence with it's options. So the workflow is that you apply this dynamic module and then click the Save Sequence button which will prompt you to name it and then it will get stored in your local storage and thereafter it will appear in your modules dropdown

@jywarren
Copy link
Member Author

We may also want to suggest saving as a gist, and/or opening an issue with your new module. Now that we have full meta-modules, many problems may be solved through the recombining of multiple other modules!

@jywarren
Copy link
Member Author

Hmm, actually i think it's no longer possible to POST to gist... $.post('https://gist.github.com/', { gist: { content: 'HELLO' }}) has a CORS error. Oh well!

@jywarren
Copy link
Member Author

@tech4GT
Copy link
Member

tech4GT commented Aug 4, 2018

@jywarren Super Idea!!!

@tech4GT
Copy link
Member

tech4GT commented Aug 4, 2018

@jywarren So I should add Publish as Gist button and another to raise an issue on our github?

@tech4GT
Copy link
Member

tech4GT commented Aug 4, 2018

Or should I add a Publish Button on the top and then we can have a modal containing all options, like sharing as a link as well?

@jywarren
Copy link
Member Author

jywarren commented Aug 4, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants