New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'No file chosen' wrongly placed in Import Image module #356

Open
Paarmita opened this Issue Sep 29, 2018 · 7 comments

Comments

Projects
None yet
4 participants
@Paarmita
Member

Paarmita commented Sep 29, 2018

We are preparing to participate in Google Code-in, and have reserved this issue for participants in GCI - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more.

First Timers Only

Hi, this is a first-timers-only issue. This means this has been worked to make it more legible to folks who either haven't contributed to our codebase before or even folks who haven't contributed to open source before.

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

The Problem

'No file chosen' option in import image module is misplaced, ie. out of the box

screenshot from 2018-09-29 22-14-47

The Solution

We need to modify css such that it comes inside border or under Choose file button.
The line which needs to be mdified is:

<input type="file" class="file-input" value="">\

<div style="padding: 30px;margin: 10px 20% 30px;border: 4px dashed #ccc;border-radius: 8px;text-align: center;color: #444;" id="' + dropzoneId + '">\

You need to add class to it and add the new css for the specific class.

Instance Count = 1

@gitmate

This comment has been minimized.

Show comment
Hide comment
@gitmate

gitmate bot Sep 29, 2018

GitMate.io thinks the contributors most likely able to help are @tech4GT, and @GitMate[bot].

Possibly related issues are #5 (image cropping module), #116 (Image overlay module), #233 (Add an "import image" module), #141 (move module tests into separate test files), and #108 (Math Module).

gitmate bot commented Sep 29, 2018

GitMate.io thinks the contributors most likely able to help are @tech4GT, and @GitMate[bot].

Possibly related issues are #5 (image cropping module), #116 (Image overlay module), #233 (Add an "import image" module), #141 (move module tests into separate test files), and #108 (Math Module).

@Paarmita Paarmita changed the title from No file chosen wrongly placed in Import Image module to 'No file chosen' wrongly placed in Import Image module Sep 29, 2018

@gitmate

This comment has been minimized.

Show comment
Hide comment
@gitmate

gitmate bot Sep 29, 2018

GitMate.io thinks the contributors most likely able to help are @tech4GT, and @GitMate[bot].

Possibly related issues are #5 (image cropping module), #116 (Image overlay module), #233 (Add an "import image" module), #141 (move module tests into separate test files), and #108 (Math Module).

gitmate bot commented Sep 29, 2018

GitMate.io thinks the contributors most likely able to help are @tech4GT, and @GitMate[bot].

Possibly related issues are #5 (image cropping module), #116 (Image overlay module), #233 (Add an "import image" module), #141 (move module tests into separate test files), and #108 (Math Module).

@vikul1234

This comment has been minimized.

Show comment
Hide comment
@vikul1234

vikul1234 Sep 30, 2018

@Paarmita It's work properly look this, can you post another screenshot
ss

vikul1234 commented Sep 30, 2018

@Paarmita It's work properly look this, can you post another screenshot
ss

@Paarmita

This comment has been minimized.

Show comment
Hide comment
@Paarmita

Paarmita Sep 30, 2018

Member

@vikul1234 Plz add an import image module, then you will be able to reproduce this.

Member

Paarmita commented Sep 30, 2018

@vikul1234 Plz add an import image module, then you will be able to reproduce this.

@tech4GT

This comment has been minimized.

Show comment
Hide comment
@tech4GT

tech4GT Oct 5, 2018

Member

This issue has been reserved for GCI @vikul1234
We would really appreciate your help on another one which is not labelled gci. Thanks!!

Member

tech4GT commented Oct 5, 2018

This issue has been reserved for GCI @vikul1234
We would really appreciate your help on another one which is not labelled gci. Thanks!!

@Mridul97 Mridul97 referenced this issue Oct 15, 2018

Open

Task list staging area for Google Code-In #3276

0 of 74 tasks complete
@jywarren

This comment has been minimized.

Show comment
Hide comment
@jywarren

jywarren Oct 16, 2018

This is a great issue - @Paarmita thanks! Maybe one addition is that you can link to a page including the import-image module using a permalink:

http://sequencer.publiclab.org/examples/#steps=import-image

jywarren commented Oct 16, 2018

This is a great issue - @Paarmita thanks! Maybe one addition is that you can link to a page including the import-image module using a permalink:

http://sequencer.publiclab.org/examples/#steps=import-image

@Paarmita

This comment has been minimized.

Show comment
Hide comment
@Paarmita

Paarmita Oct 16, 2018

Member

@jywarren Yup! we can do that as well.

Member

Paarmita commented Oct 16, 2018

@jywarren Yup! we can do that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment