Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Code-In (2018) Pending issues #4581

Closed
41 of 77 tasks
CodeSarthak opened this issue Jan 9, 2019 · 18 comments
Closed
41 of 77 tasks

Google Code-In (2018) Pending issues #4581

CodeSarthak opened this issue Jan 9, 2019 · 18 comments
Labels
break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration help wanted requires help by anyone willing to contribute

Comments

@CodeSarthak
Copy link
Collaborator

CodeSarthak commented Jan 9, 2019 •
edited
Loading

This is a staging area. Each task has (or will soon have) a link to a full issue including relevant lines of code, screenshots, and other helpful information as we prepare them for solving. Some are harder than others, but those tagged with first-timers-only are great to begin with. (more documentation on tasks)

Add new items: Look here for new items to adapt for this list: planning issues, break-me-up issues, fto-candidates. Fit tasks into the categories below.

Format items to be descriptive, [bracket otherwise]: As we create this list, it's OK to be brief, but if a task lacks description, tags, screenshots, and code links, [Put it in brackets to indicate that it needs to be fleshed out]

Break out items here into their own issues: Use the gci-candidate tag instead of the gci tag to manage the supply. We don't want to have more open issues than we can support at one time, and gci is what we'll direct students towards. gci-candidate is for "held back" issues we're saving up.

Weighting: some issues don't result in many lines of code, but are still big projects. Use tags small, medium, big when you'd like to help mark them (read more)

These can be moved up once they have code links or issue links:

  •  needs-code-links Preserve redirect to original destination when accessing /post while not logged in (follow these steps: 1. publiclab.org/post You will be redirected to login page 2. Login 3. Redirected to dashboard -- Expected Behavior Redirected to /post.)
  •  display of an SVG at the URL /profile/status/_ID_ for a user with id of _ID_, showing the user.status as one of these two SVGs: https://gist.github.com/jywarren/ea0523a09f6f8660486b14eeea15de95
  •  display if someone's been banned or is still active in moderator emails (https://github.com/publiclab/plots2/blob/master/app/views/admin_mailer/notify_node_moderators.html.erb) using the SVG at the above URL so moderators can tell if something's already been moderated without opening a link -- issue at #3338
  •  make username/email form appear side by side with Oauth user registration at https://publiclab.org/signup
  •  needs-code-links Remove extra space at bottom of /post
    image
  •  needs-code-links Removal of 1 horizontal line -- issue at Remove the extra space after share #4611
    image
  •  needs-code-links Add generic video icon here, instead of being specific to YouTube. We should give equal priority to all the hosts. (https://github.com/publiclab/PublicLab.Editor/)
    image
  •  On clicking on '?' page should be opened in new tab. Currently, it is opening on the same page, using target="_blank" on the <a> tag
    image -- GCI dashboard
  •  needs-code-links Similar behaviour (needs to open on a new page) reported for Open Source Your Work link at https://publiclab.org/signup and /post
  •  needs-code-links Hover text should redirect to page listing all the wiki articles and research notes with text water quality
    image
  •  needs-code-linksHover text should redirect to page listing all the wiki articles and research notes with text balloon-mapping
    image
  •  needs-code-links Redundant Dashboard in the drop down menu #3327
    image
  •  needs-code-links Clearly mention that on RHS we have Research notes. Liked by ____ appears ambiguous to me a lot
    image
  •  needs-code-links sort wiki page likes according to date/time
    image
  •  needs-code-links If a person has no barnstars and they click on the nav bar. There must be a message to show them. Just to enhance the readability
    image
  •  On removal of any of these tags, all three must be removed image
  •  Same button three times to post work on same web page image
  •  Same thread is placed repeatedly on the dashboard page due to multiple comments.
    image
    I will suggest that one post should be shown only once.
  •  Use of common functions in /maps page : #3316
  •  Standardize display of n Wiki and m Research Notes #2193
  •  When a person submits an empty sign up form.
    image
    Error should also come that the fields are empty #3340 -- GCI dashboard
  •  Test for the the above task
  •  Tag the author on the home page where their articles are written in grid view/List view (needs own issue)
  •  logging users to wiki page when a user logs in via header on wiki page (needs own issue)
  •  Clicking on like button if not logged in should redirect to login page. (needs own issue)
  •  Pagination broken on home page
    image
    see that url shows page 2 but the pagination is of page 1. (needs own issue)
  •  needs-code-links make tags in Suggested tags on publiclab.org/post appear in tag input box when clicked - https://github.com/publiclab/PublicLab.Editor/

Documentation/Training: creating/editing documents and helping others learn more

  •  Write a page describing different tags used at github repositories like GCI, outreach, etc #2341 -- GCI dashboard
  •  write a document explaining how to start contributing at public lab for Google Summer Of Code #3319-- GCI dashboard
  •  write a document explaining how to start contributing at Public Lab for RGSoc (needs own issue)
  •  write documentation on how to open a Pull Request for first - timer contributor (needs own issue)
  •  the table of contents on the github.com/publiclab/plots2 is inconsistent with the content present after it (needs own issue)
  •  Add a list of available modules to the documentation publiclab/image-sequencer#337

Outreach/Research: community management, marketing, or studying problems and recommending solutions

Quality Assurance: testing and ensuring code is of high quality

Design: graphic design or user interface design

  •  Exploring layouts for the dashboard #3355 instance count 50
  •  BIG TASK: Wiki page should be rendered on same page. On clicking on wiki pages nav bar on /notes/popular a new page opens up. But wiki pages should be rendered under the wiki nav bar. #3456
  •  FTO: make the rsvp links in the events on the home page non clickable.
  •  add hover text in public lab editor
    image publiclab/PublicLab.Editor#156
  •  image
    ''Read More'' should be center aligned
  •  "Read more" and the next grid item should have hr in between
    image
  •  Implement "grid view" for inline lists, in addition to existing "table/list view" - #1097
  •  some Bootstrap 4 pre-upgrade work - #1716
  •  [multiple-user]Copy welcomebot and first-timers-only templates into other projects - #3681 -- GCI dashboard
@CodeSarthak CodeSarthak mentioned this issue Jan 9, 2019
Closed
78 tasks
@CodeSarthak
Copy link
Collaborator Author

Hi guys @publiclab/gci-18 @ValentinaTironi @kevinzluo @okonek , let us first figure which of these issues already have their separate issues.

If they do, then comment in this format :

(Name of Checklist Instance) (Issue Number)

and tick the checkbox.

After figuring out which tasks are already made, we can work on making new issues for the rest.

This can be also be a good source for first timers and those interested in documentation. (@SidharthBansal @jywarren )

@CodeSarthak CodeSarthak changed the title Clearing up pending GCI 18 tasks Clearing up pending GCI 18 issues Jan 9, 2019
@oorjitchowdhary
Copy link
Member

I've ticked on issues which are already solved..

@jywarren
Copy link
Member

jywarren commented Jan 9, 2019 via email

@grvsachdeva grvsachdeva changed the title Clearing up pending GCI 18 issues Google Code-In (2018) Pending issues Jan 9, 2019
@grvsachdeva grvsachdeva added help wanted requires help by anyone willing to contribute break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration labels Jan 9, 2019
@CodeSarthak
Copy link
Collaborator Author

I've ticked on issues which are already solved..

Goof job, mate 👍

@oorjitchowdhary oorjitchowdhary mentioned this issue Jan 14, 2019
Closed
5 tasks
@CodeSarthak
Copy link
Collaborator Author

Hi, @publiclab/guides @publiclab/reviewers ,

I am not sure but I believe that this issue is still relevant and we can add issues from this list to GCI too. Though, the ones which are already solved need to be closed (39 of 77 mentioned are not yet checked).

Thank you.

@SidharthBansal
Copy link
Member

SidharthBansal commented Dec 10, 2019 via email

@CodeSarthak
Copy link
Collaborator Author

Yes, of course. I was not looking to do this for points, just for the record. It seems that it would be quite helpful to the community.

I will try to work on this as and when I get time.

@SidharthBansal
Copy link
Member

SidharthBansal commented Dec 10, 2019 via email

@CodeSarthak
Copy link
Collaborator Author

Sure, thank you for the support @SidharthBansal .

@CodeSarthak
Copy link
Collaborator Author

Hey @jywarren @SidharthBansal ,

I have tried my level best here to look for already completed tasks and I have come to the conclusion that 33 issues are still there which can be resolved, some of which are also ftos and some are multiple-use too (for example, #3681 ).

This can prove to be a good source of ftos and even GCI tasks. I will get to work immediately on creating issues for the ones which don't already have one (about 15 so).

Thank you.

@SidharthBansal
Copy link
Member

Superb

@CodeSarthak
Copy link
Collaborator Author

Hey @SidharthBansal , can you upload a GCI task for this refactoring?

@SidharthBansal
Copy link
Member

SidharthBansal commented Dec 15, 2019 via email

@CodeSarthak
Copy link
Collaborator Author

Yes, sure. All the best for your exam 😆

@SidharthBansal
Copy link
Member

Please describe what you did and how can i check your work. Please help :-)

@CodeSarthak
Copy link
Collaborator Author

I went through the issues/tasks list above and figured out which of them are still unresolved. I checked the ones which have been resolved.

You can check the same by going through the issues checklist above.

I am planning to add issues for some of the tasks above which do not have an issue of their own. Though this may require help from the community since it is a large number.

Thank you.

@SidharthBansal
Copy link
Member

SidharthBansal commented Dec 18, 2019 via email

@CodeSarthak
Copy link
Collaborator Author

Hey,

I have opened a new issue (#7014) with only the issues/tasks which were left. I removed all those which has already been closed or completed.

Thus, this issue is now redundant.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration help wanted requires help by anyone willing to contribute
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jywarren @grvsachdeva @SidharthBansal @CodeSarthak @oorjitchowdhary