Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixel set redundancy removed #1188

Merged
merged 4 commits into from
Aug 14, 2019
Merged

Conversation

aashna27
Copy link

@aashna27 aashna27 commented Jul 28, 2019

Links to the pr #1050 !

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@codecov
Copy link

codecov bot commented Jul 28, 2019

Codecov Report

Merging #1188 into main will decrease coverage by 0.19%.
The diff coverage is 84.78%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #1188     +/-   ##
=========================================
- Coverage   55.31%   55.11%   -0.2%     
=========================================
  Files         116      117      +1     
  Lines        2381     2344     -37     
  Branches      364      360      -4     
=========================================
- Hits         1317     1292     -25     
+ Misses       1064     1052     -12
Impacted Files Coverage Δ
src/modules/Histogram/Module.js 13.51% <0%> (+1.88%) ⬆️
src/util/pixelSetter.js 100% <100%> (ø)
src/modules/DrawRectangle/DrawRectangle.js 100% <100%> (ø) ⬆️
src/modules/EdgeDetect/EdgeUtils.js 86.95% <100%> (-0.68%) ⬇️
src/modules/Contrast/Contrast.js 100% <100%> (ø) ⬆️
src/modules/ColorTemperature/Module.js 82.85% <100%> (-1.36%) ⬇️
src/modules/Convolution/Convolution.js 100% <100%> (ø) ⬆️
src/modules/Gradient/Module.js 93.33% <100%> (-0.42%) ⬇️
src/modules/_nomodule/PixelManipulation.js 68.05% <100%> (-0.87%) ⬇️
src/modules/Blur/Blur.js 100% <100%> (ø) ⬆️
... and 3 more

@jywarren jywarren merged commit 5b98d5c into publiclab:main Aug 14, 2019
@jywarren
Copy link
Member

OK, done! Nice! Thank you!!!!

jywarren pushed a commit that referenced this pull request Dec 16, 2019
* Pixels.set Redundancy removed

* eslint fixes

* move require to top with const
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants