fixes add-QR and color-picker in draw-rectangle,grid-overlay #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1250 +/- ##
=======================================
Coverage 32.07% 32.07%
=======================================
Files 107 107
Lines 1986 1986
Branches 297 297
=======================================
Hits 637 637
Misses 1349 1349
|
harshkhandeparkar
approved these changes
Sep 6, 2019
|
@harshkhandeparkar by mistake pressed re-review button.can you please approve it again |
harshkhandeparkar
approved these changes
Sep 6, 2019
|
Sorry for the mistakes! This is correct, also can you also check for other modules. I ll share the pr link which had the pixel setter, please verify if the changes made for modules work with them.#1188 Thanks |
aashna27
approved these changes
Sep 10, 2019
|
@aashna27 Have already checked it.They are working as expected. |
|
@jywarren i think it's good to merge. |
|
Great, thanks all! 🎉 |
jywarren
pushed a commit
that referenced
this pull request
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1247
draw-rectangle after changes
grid-overlay after changes
add-qr after changes
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test@publiclab/is-reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!