-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document noise reduction module #1189
Document noise reduction module #1189
Conversation
Thanks for opening this pull request! |
Codecov Report
@@ Coverage Diff @@
## main #1189 +/- ##
=======================================
Coverage 32.07% 32.07%
=======================================
Files 107 107
Lines 1986 1986
Branches 297 297
=======================================
Hits 637 637
Misses 1349 1349 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me. Just a few comments and this is done.
Hi, I've fixed the documentation as suggested, please review it, thank you! |
The conflict needs to be resolved and then this can be merged. |
Hi, the conflict is resolved. Please check it out!, Thank you. |
Sorry to point out again but the conflicts continue to exist. |
I have merged |
Co-Authored-By: Harsh Khandeparkar <34770591+HarshKhandeparkar@users.noreply.github.com>
Hi, please approve this issue. |
Hi @aashna27, I've resolved all comments and I believe my PR is ready to merge. Can you help me getting this merged? I don't want to leave this PR open for too long. |
Yea sure i ll help you
…On Thu, Sep 12, 2019, 4:16 AM duyquangnguyenhac ***@***.***> wrote:
Hi @aashna27 <https://github.com/aashna27>, I've resolved all comments
and I believe my PR is ready to merge. Can you help me getting this merged?
I don't want to leave this PR open for too long.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1189?email_source=notifications&email_token=AGKQ7SGPLE42O22ZUGMWBH3QJFYNPA5CNFSM4IHOP7IKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6QD22Q#issuecomment-530595178>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGKQ7SAMUCEXN7J4JFMYUEDQJFYNPANCNFSM4IHOP7IA>
.
|
Please add it alphabetically and then we can merge this |
Thanks for your help |
Module is now alphabetically sorted! |
Hi,
|
Looks awesome. I've resolved conflicts one more time, then we will merge! Thanks for your patience! |
Idk if I have left an official review here, but I have gone through it. So
consider it as a 👍 from me. Thanks!
…On Mon, 23 Sep, 2019, 8:04 PM Jeffrey Warren, ***@***.***> wrote:
Looks awesome. I've resolved conflicts one more time, then we will merge!
Thanks for your patience!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1189?email_source=notifications&email_token=AIJI5H72J5KM4VIQRDA4K2DQLDHWNA5CNFSM4IHOP7IKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7LCBDQ#issuecomment-534126734>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIJI5HZH4IJXC6I572R4D2DQLDHWNANCNFSM4IHOP7IA>
.
|
Congrats on merging your first pull request! 🙌🎉⚡️ |
Awesome! Thanks a ton! |
* Added documentation for noise reduction module * Added fixed documentation for noise reduction module * Update MODULES.md * Minor Changes to Noise-Reduction description. * Update docs/MODULES.md Co-Authored-By: Harsh Khandeparkar <34770591+HarshKhandeparkar@users.noreply.github.com> * Move documentation to alphabetical order * Update MODULES.md
Fixes #1170 (<=== Replace
0000
with the Issue Number)Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!