Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document noise reduction module #1189

Merged

Conversation

duyquangnguyenhac
Copy link

@duyquangnguyenhac duyquangnguyenhac commented Jul 29, 2019

Fixes #1170 (<=== Replace 0000 with the Issue Number)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Jul 29, 2019

Thanks for opening this pull request!
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@codecov
Copy link

codecov bot commented Jul 29, 2019

Codecov Report

Merging #1189 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1189   +/-   ##
=======================================
  Coverage   32.07%   32.07%           
=======================================
  Files         107      107           
  Lines        1986     1986           
  Branches      297      297           
=======================================
  Hits          637      637           
  Misses       1349     1349

Copy link

@aashna27 aashna27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

docs/MODULES.md Outdated Show resolved Hide resolved
Copy link
Member

@Divy123 Divy123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Just a few comments and this is done.

@duyquangnguyenhac
Copy link
Author

Hi, I've fixed the documentation as suggested, please review it, thank you!

@aashna27
Copy link

The conflict needs to be resolved and then this can be merged.

@duyquangnguyenhac
Copy link
Author

Hi, the conflict is resolved. Please check it out!, Thank you.

@aashna27
Copy link

Hi, the conflict is resolved. Please check it out!, Thank you.

Sorry to point out again but the conflicts continue to exist.

@duyquangnguyenhac
Copy link
Author

Hi, the conflict is resolved. Please check it out!, Thank you.

Sorry to point out again but the conflicts continue to exist.

I have merged main and resolved the conflicts.

docs/MODULES.md Outdated Show resolved Hide resolved
Co-Authored-By: Harsh Khandeparkar <34770591+HarshKhandeparkar@users.noreply.github.com>
@duyquangnguyenhac
Copy link
Author

Hi, please approve this issue.
Thank you, James.

@duyquangnguyenhac
Copy link
Author

Hi @aashna27, I've resolved all comments and I believe my PR is ready to merge. Can you help me getting this merged? I don't want to leave this PR open for too long.

@aashna27
Copy link

aashna27 commented Sep 12, 2019 via email

@aashna27
Copy link

Please add it alphabetically and then we can merge this

@aashna27
Copy link

Thanks for your help

@duyquangnguyenhac
Copy link
Author

Module is now alphabetically sorted!

@duyquangnguyenhac
Copy link
Author

Hi,
I think it is okay to merge now?

  • Thank you so much for supports!
    James

@jywarren
Copy link
Member

Looks awesome. I've resolved conflicts one more time, then we will merge! Thanks for your patience!

@harshkhandeparkar
Copy link
Member

harshkhandeparkar commented Sep 23, 2019 via email

@jywarren jywarren merged commit 33f3225 into publiclab:main Sep 23, 2019
@welcome
Copy link

welcome bot commented Sep 23, 2019

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will be published to https://beta.sequencer.publiclab.org in a day or two.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

@jywarren
Copy link
Member

Awesome! Thanks a ton!

jywarren pushed a commit that referenced this pull request Dec 16, 2019
* Added documentation for noise reduction module

* Added fixed documentation for noise reduction module

* Update MODULES.md

* Minor Changes to Noise-Reduction description.

* Update docs/MODULES.md

Co-Authored-By: Harsh Khandeparkar <34770591+HarshKhandeparkar@users.noreply.github.com>

* Move documentation to alphabetical order

* Update MODULES.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document Noise-Reduction Module
5 participants