Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pull_Request.md #1233

Merged
merged 3 commits into from Aug 28, 2019
Merged

Update Pull_Request.md #1233

merged 3 commits into from Aug 28, 2019

Conversation

rishabhshuklax
Copy link
Member

Fixes #1232
I have updated Pull_Request.md

@welcome
Copy link

welcome bot commented Aug 27, 2019

Thanks for opening this pull request!
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

Merging #1233 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1233   +/-   ##
=======================================
  Coverage   55.11%   55.11%           
=======================================
  Files         117      117           
  Lines        2344     2344           
  Branches      360      360           
=======================================
  Hits         1292     1292           
  Misses       1052     1052

@Divy123
Copy link
Member

Divy123 commented Aug 28, 2019

@jywarren I think this can be merged here.

@jywarren jywarren merged commit 1cc9fd1 into publiclab:main Aug 28, 2019
@welcome
Copy link

welcome bot commented Aug 28, 2019

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will be published to https://beta.sequencer.publiclab.org in a day or two.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

@jywarren
Copy link
Member

Great work, thank you!!!

jywarren pushed a commit that referenced this pull request Dec 16, 2019
* Update pull request template

* Update Pull_Request.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Pull_Request.md file for new PR workflow.
3 participants