Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Pull_Request.md #1233

Merged
merged 3 commits into from
Aug 28, 2019
Merged

Update Pull_Request.md #1233

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b356b6c
Update pull request template
rishabhshuklax Aug 27, 2019
c6d306c
Update Pull_Request.md
rishabhshuklax Aug 27, 2019
5474ab1
Merge branch 'main' into main
jywarren Aug 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ Make sure these boxes are checked before your pull request (PR) is ready to be r
* [ ] code is in uniquely-named feature branch and has no merge conflicts
* [ ] PR is descriptively titled
* [ ] ask `@publiclab/is-reviewers` for help, in a comment below

* [ ] Insert-step functionality is working correct as expected.
> We're happy to help you get this ready -- don't be afraid to ask for help, and **don't be discouraged** if your tests fail at first!

If tests do fail, click on the red `X` to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!