Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing Modules to Documentation #1325

Merged
merged 3 commits into from
Dec 10, 2019
Merged

Add Missing Modules to Documentation #1325

merged 3 commits into from
Dec 10, 2019

Conversation

rcya1
Copy link

@rcya1 rcya1 commented Dec 5, 2019

Fixes #1291 (<=== Replace 0000 with the Issue Number)

Adds the following modules to the documentation:

  • Canvas-Resize
  • Exposure
  • WebGL-Distort
  • White-Balance

These modules are in the current stable build but are not currently in the documentation.

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@welcome
Copy link

welcome bot commented Dec 5, 2019

Thanks for opening this pull request!
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@rcya1
Copy link
Author

rcya1 commented Dec 5, 2019

@publiclab/is-reviewers Please review this. Thank you!

@codecov
Copy link

codecov bot commented Dec 5, 2019

Codecov Report

Merging #1325 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1325   +/-   ##
=======================================
  Coverage   66.57%   66.57%           
=======================================
  Files         125      125           
  Lines        2546     2546           
  Branches      397      397           
=======================================
  Hits         1695     1695           
  Misses        851      851

@chen-robert
Copy link

Welcome to Public Labs @Ryan10145!

If you haven't already, be sure to check out the welcoming post at publiclab/plots2#6808.

@lohitha02
Copy link
Member

Looks great @Ryan10145 thanks for your contribution.

Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@keshav234156
Copy link
Member

@jywarren can you please review and merge the changes asap

@SidharthBansal
Copy link
Member

Just checking, Harsh are you participating in GCI ?

@harshkhandeparkar
Copy link
Member

harshkhandeparkar commented Dec 6, 2019 via email

@SidharthBansal
Copy link
Member

SidharthBansal commented Dec 6, 2019 via email

@jywarren
Copy link
Member

jywarren commented Dec 9, 2019

This is also good to merge now. Thanks!

@jywarren jywarren merged commit d371a0f into publiclab:main Dec 10, 2019
@welcome
Copy link

welcome bot commented Dec 10, 2019

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will be published to https://beta.sequencer.publiclab.org in a day or two.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

jywarren pushed a commit that referenced this pull request Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding the missing module in the documentation
7 participants