FIX: Dragzone overlapping #1333
Conversation
Changes: - inline styles moved from ../ImportImage/Ui.js to demo.css - minor code improvements The change was necessary because in the old UI dragzone was overlapping an image. Resolves #1294
|
Thanks for opening this pull request! |
Codecov Report
@@ Coverage Diff @@
## main #1333 +/- ##
=======================================
Coverage 66.57% 66.57%
=======================================
Files 125 125
Lines 2546 2546
Branches 397 397
=======================================
Hits 1695 1695
Misses 851 851 |
Changes: - rollback .dropzone input style - add styles to .import-image-zone input element
|
@keshav234156 Everything else remained the same :) |
|
@VladimirMikulic As the text was getting squashed with 100% that why I suggested you to increase the max-width in import-image-zone.Can you please do the changes. |
Changes: - max-width increased to 120% on import-image-zone input element
|
@keshav234156 as you've requested, here is the change. |
|
@VladimirMikulic don't increase max-width in .import-image-zone input ie keep it 100%.Change max-width in import-image-zone from 230 to 250.Hope it's clear now ,If not please let me know. |
Changes: - rollback .import-image-zone input max-width to fit-content - increase .import-image-zone max-width from 230px to 250px
|
I apologise. Apparently, I got lost with all these widths 😅.
|
Changes: - max-width set to 100%
|
That should do it.
|
|
Looks absolutely perfect to me now.Thanks for your patience. |
|
@keshav234156 thank you for your clarification and patience. We did it together. |
|
@jywarren can you please review the changes. |
|
@jywarren can we get this merged? I would like you to review the changes :) |
|
Looks great! Thank you! Let's merge after #1325; we'll update the branch just after that merges! |
|
Awesome! |
|
Congrats on merging your first pull request! 🙌🎉⚡️ |
* FIX: Dragzone overlapping Changes: - inline styles moved from ../ImportImage/Ui.js to demo.css - minor code improvements The change was necessary because in the old UI dragzone was overlapping an image. Resolves #1294 * FIX: Improve commit #ead4b932 Changes: - rollback .dropzone input style - add styles to .import-image-zone input element * FIX: .import-image-zone input element width Changes: - max-width increased to 120% on import-image-zone input element * FIX: .import-image-zone max-width Changes: - rollback .import-image-zone input max-width to fit-content - increase .import-image-zone max-width from 230px to 250px * FIX: .import-image-zone input element max-width Changes: - max-width set to 100%
Changes:
The change was necessary because in the old UI drag zone was overlapping
an image.
Resolves #1294
@harshithpabbati @keshav234156 requesting review :)