Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change UI Previews' Crop Default Options #1487

Merged
merged 3 commits into from Jan 16, 2020
Merged

Change UI Previews' Crop Default Options #1487

merged 3 commits into from Jan 16, 2020

Conversation

ojurkiewicz
Copy link

Fixes #1477

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@welcome
Copy link

welcome bot commented Jan 13, 2020

Thanks for opening this pull request!
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@ojurkiewicz
Copy link
Author

@publiclab/is-reviewers Please review this pr ;)

@codecov
Copy link

codecov bot commented Jan 13, 2020

Codecov Report

Merging #1487 into main will decrease coverage by 0.12%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1487      +/-   ##
==========================================
- Coverage   64.88%   64.75%   -0.13%     
==========================================
  Files         127      127              
  Lines        2597     2602       +5     
  Branches      418      418              
==========================================
  Hits         1685     1685              
- Misses        912      917       +5
Impacted Files Coverage Δ
examples/lib/defaultHtmlStepUi.js 10.98% <0%> (-0.32%) ⬇️

@jywarren jywarren merged commit 45c54bb into publiclab:main Jan 16, 2020
@welcome
Copy link

welcome bot commented Jan 16, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will be published to https://beta.sequencer.publiclab.org in a day or two.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

@jywarren
Copy link
Member

Awesome. Thanks a lot!!! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix/Change UI Previews' Crop Default Options
3 participants