Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed paint bucket fill color error #1519

Merged
merged 4 commits into from
Jan 21, 2020
Merged

Conversation

Olusamimaths
Copy link

@Olusamimaths Olusamimaths commented Jan 17, 2020

Fixes #1488

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@welcome
Copy link

welcome bot commented Jan 17, 2020

Thanks for opening this pull request!
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@codecov
Copy link

codecov bot commented Jan 17, 2020

Codecov Report

Merging #1519 into main will increase coverage by 0.16%.
The diff coverage is 80.95%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main   #1519      +/-   ##
=========================================
+ Coverage   66.64%   66.8%   +0.16%     
=========================================
  Files         129     129              
  Lines        2662    2672      +10     
  Branches      428     430       +2     
=========================================
+ Hits         1774    1785      +11     
+ Misses        888     887       -1
Impacted Files Coverage Δ
src/modules/AddQR/QR.js 91.66% <100%> (ø) ⬆️
src/modules/AddQR/Module.js 100% <100%> (ø) ⬆️
src/modules/_nomodule/PixelManipulation.js 46.15% <100%> (+0.41%) ⬆️
src/modules/TextOverlay/Module.js 46.15% <20%> (-8.4%) ⬇️
src/modules/Histogram/Module.js 100% <0%> (+2.7%) ⬆️
src/modules/Threshold/Threshold.js 83.72% <0%> (+4.65%) ⬆️

@rishabhshuklax
Copy link
Member

Fixes #0000 (<=== Replace 0000 with the Issue Number)

@Olusamimaths please write issue number here.

Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please multiply the alpha by 255 and not 256.

@LeoDog896
Copy link

@Olusamimaths please add the issue number, and also change the multiplier value to 255 instead of 256. Other than that, a great fix!

@Olusamimaths Olusamimaths changed the title fillColor getting correct color Fixed #1488 Jan 17, 2020
@jywarren jywarren changed the title Fixed #1488 Fixed paint bucket fill color error Jan 18, 2020
Copy link
Member

@rishabhshuklax rishabhshuklax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jywarren jywarren merged commit 5b92ba5 into publiclab:main Jan 21, 2020
@welcome
Copy link

welcome bot commented Jan 21, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will be published to https://beta.sequencer.publiclab.org in a day or two.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

@jywarren
Copy link
Member

Great work, thanks, folks!

@harshkhandeparkar harshkhandeparkar added this to Done in v3.6.0 Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v3.6.0
  
Done
Development

Successfully merging this pull request may close these issues.

Paint bucket module is getting wrong input for fillColor
5 participants