Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Test modules for GIF's #1530

Merged
merged 15 commits into from Jan 28, 2020
Merged

Adding Test modules for GIF's #1530

merged 15 commits into from Jan 28, 2020

Conversation

root00198
Copy link
Member

@root00198 root00198 commented Jan 17, 2020

Fixes #1479

I am creating this PR again, because the #1490 PR created some serious conflicts.
@harshkhandeparkar @jywarren, please review it..

There are some issue that I tried to address in the previous PR, like the histogram module issue. I will create a seperate PR for that.

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@root00198 root00198 requested review from harshkhandeparkar and jywarren and removed request for harshkhandeparkar January 17, 2020 20:27
@codecov
Copy link

codecov bot commented Jan 17, 2020

Codecov Report

Merging #1530 into main will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1530   +/-   ##
=======================================
  Coverage   66.61%   66.61%           
=======================================
  Files         130      130           
  Lines        2672     2672           
  Branches      430      430           
=======================================
  Hits         1780     1780           
  Misses        892      892
Impacted Files Coverage Δ
src/modules/DrawRectangle/DrawRectangle.js 100% <100%> (ø) ⬆️

@jywarren
Copy link
Member

Hmm, tests didn't pass on one of these but it needed updating again anyways... let's see what happens!

@root00198 root00198 mentioned this pull request Jan 18, 2020
5 tasks
@root00198
Copy link
Member Author

root00198 commented Jan 18, 2020

Draw-Rectangle Module which didn't passed, will get passed once #1535 PR got merged...

@jywarren
Copy link
Member

Looks like it passed after all, is this then ready for a merge? Thank you!

@root00198
Copy link
Member Author

Let's Go!!

@rishabhshuklax
Copy link
Member

@root00198 I see tests failing in the logs
https://travis-ci.org/publiclab/image-sequencer/jobs/639046685#L2623
Were they passing before merging #1533?

@root00198
Copy link
Member Author

Yes they were passing. My one module draw-rectangle was failing but it was not because of the code in this PR. It was because of the reason in #1535.

@jywarren
Copy link
Member

Hm. My update didn't seem to help. I think this may need a true rebase?

@rishabhshuklax
Copy link
Member

The tests won't pass until #1535 gets merged!

@jywarren
Copy link
Member

Updating branch! Let's see.

@jywarren jywarren merged commit 166a0d8 into publiclab:main Jan 28, 2020
@jywarren
Copy link
Member

Awesome. Great work!!!

@jywarren
Copy link
Member

Thank you!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more GIF tests
4 participants