change url string fixes #306 #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tech4GT <varun.gupta1798@gmail.com>
ghost
assigned 
|
@jywarren ready to merge |
Signed-off-by: tech4GT <varun.gupta1798@gmail.com>
|
@jywarren rebased and ready to merge!! Now working on overlay and colorbar!! |
|
This is great. Could you put a note about backwards compatibility and a couple examples of string syntax in a new section called, maybe https://github.com/publiclab/image-sequencer/#saving-sequences What do you think? |
|
@jywarren Sure!! I am working on overlay, once I am done with that I'll put this in!! An hour maybe.. |
|
@jywarren Done! I think this is ready to be merged in!! Yay!! |
jywarren
approved these changes
Aug 4, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jywarren New format is with
{}as you suggested and it is also compatible with old()Signed-off-by: tech4GT varun.gupta1798@gmail.com