Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #395:Disabled save-sequence button when no steps are added. #462

Merged
merged 1 commit into from
Nov 11, 2018
Merged

Fixes #395:Disabled save-sequence button when no steps are added. #462

merged 1 commit into from
Nov 11, 2018

Conversation

Divy123
Copy link
Member

@Divy123 Divy123 commented Nov 11, 2018

Fixes #[Add issue number here.]

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@Divy123
Copy link
Member Author

Divy123 commented Nov 11, 2018

@jywarren please review.

@Paarmita
Copy link
Member

@Divy123 Thanks for the PR :) It looks great.

@jywarren
Copy link
Member

This looks great. Very nicely done! Thank you!

There are plenty of issues up for grabs in this project, we'd love more help! Great work!

@jywarren jywarren merged commit 4576e49 into publiclab:main Nov 11, 2018
@welcome
Copy link

welcome bot commented Nov 11, 2018

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://sequencer.publiclab.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

@jywarren
Copy link
Member

And thanks @Paarmita for the extra review! Are you mostly focusing on one project or another, or just looking out across all publiclab projects? So helpful!

@Paarmita
Copy link
Member

@jywarren I'm looking out all the projects of the organization and specifically helping the students on making their PR.

@jywarren
Copy link
Member

That is so wonderful. Thank you @Paarmita !!!

@Divy123 Divy123 deleted the button-disable branch November 17, 2018 19:39
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants