Added Demo for FisheyeGl Module #62

ccpandhare · 2017-07-17T07:26:53Z

I have added a demo for the FisheyeGl module and it is now live at https://ccpandhare.github.io/image-sequencer/examples/fisheye

As #27 Suggests, I should add a 'crop+fisheyegl' demo. Should I add that in addition to this or remove this altogether and add just that?

…ng Image Sequencer UI

ccpandhare · 2017-08-01T18:06:14Z

I have made the Demo like the one in https://jywarren.github.io/fisheyegl/example/
It can be seen at https://ccpandhare.github.io/image-sequencer/examples/fisheye

This has been made with the new UI System

ccpandhare · 2017-08-01T18:28:50Z

The link is https://ccpandhare.github.io/image-sequencer/examples/fisheye and not https://ccpandhare.github.io/image-sequencer/examples/fisheyegl, sorry for that.

ccpandhare · 2017-08-02T18:21:07Z

Once this is merged in, I will add a link to it in the description.
Also we should now have a gh-pages site for publiclab/image-sequencer too

jywarren · 2017-08-03T15:35:53Z

OK - this is super. I have some requests and thoughts that will be relevant to the UI system.

First, specifically on this module's demo, there are some UI features (very recently added) which make the fisheye system much more useful:

drag drop
url hash used to store the settings, so you can pass a permalink that's a "preset" for a specific camera
storing previous images in a grid below, to make batch processing easier

These are all in main.js here: https://github.com/jywarren/fisheyegl/blob/master/example/main.js

I think we could reformat that file to simply be directly re-usable somehow in this demo, so upgrades to that UI code can be available here too. But is this a sustainable workflow?

More generally, many modules may have very specific UIs designed just for their particular use, and which make them much more useful. How can we design the system to allow modules to supply a UI that's hyper-specific in a flexible but standard way?

Could fisheye also publish a separate fisheye-ui? or could there be a baked-in module.ui?

What are your thoughts?

ccpandhare · 2017-08-03T17:21:13Z

I am not very sure how we can directly use the code from the module demo. Maybe we can have the module specify UI components? How does that sound?

…

On गुरु, ३, ऑग २०१७, २१:०५ Jeffrey Warren ***@***.***> wrote: OK - this is super. I have some requests and thoughts that will be relevant to the UI system. First, specifically on this module's demo, there are some UI features (very recently added) which make the fisheye system much more useful: - drag drop - url hash used to store the settings, so you can pass a permalink that's a "preset" for a specific camera - storing previous images in a grid below, to make batch processing easier These are all in main.js here: https://github.com/jywarren/fisheyegl/blob/master/example/main.js I think we could reformat that file to simply be directly re-usable somehow in this demo, so upgrades to that UI code can be available here too. But is this a sustainable workflow? More generally, many modules may have very specific UIs designed just for their particular use, and which make them much more useful. How can we design the system to allow modules to supply a UI that's hyper-specific in a flexible but standard way? Could fisheye also publish a separate fisheye-ui? or could there be a baked-in module.ui? What are your thoughts? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#62 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AT0xnKZNz-CjKY6OCSzruTtoyHXGjdJOks5sUejagaJpZM4OZn8y> .

jywarren · 2017-08-03T17:42:31Z

Well, we could either release a second module for each, or include a UI subcomponent in each.

…

On Aug 3, 2017 1:21 PM, "Chinmay Pandhare" ***@***.***> wrote: I am not very sure how we can directly use the code from the module demo. Maybe we can have the module specify UI components? How does that sound? On गुरु, ३, ऑग २०१७, २१:०५ Jeffrey Warren ***@***.***> wrote: > OK - this is super. I have some requests and thoughts that will be > relevant to the UI system. > > First, specifically on this module's demo, there are some UI features > (very recently added) which make the fisheye system much more useful: > > - drag drop > - url hash used to store the settings, so you can pass a permalink > that's a "preset" for a specific camera > - storing previous images in a grid below, to make batch processing > easier > > These are all in main.js here: > https://github.com/jywarren/fisheyegl/blob/master/example/main.js > > I think we could reformat that file to simply be directly re-usable > somehow in this demo, so upgrades to that UI code can be available here > too. But is this a sustainable workflow? > > More generally, many modules may have very specific UIs designed just for > their particular use, and which make them much more useful. How can we > design the system to allow modules to supply a UI that's hyper-specific in > a flexible but standard way? > > Could fisheye also publish a separate fisheye-ui? or could there be a > baked-in module.ui? > > What are your thoughts? > > — > You are receiving this because you were assigned. > Reply to this email directly, view it on GitHub > <#62# issuecomment-320006040>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AT0xnKZNz- CjKY6OCSzruTtoyHXGjdJOks5sUejagaJpZM4OZn8y> > . > — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#62 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ19ReLtphLdYrZCVomYzkXuFZRlIks5sUgGKgaJpZM4OZn8y> .

ccpandhare · 2017-08-04T08:17:29Z

I have some concerns here, is Image Sequencer supposed to provide the UI?
Shouldn't the UI be implementation specific?

Maybe we could provide a standard UI - Users can choose to use it or not.

But honestly, I don't think Image Sequencer should be handling front end code (By that i mean the markup and the stylesheets).
It should definitely have an API for UI development, but maybe not provide UI itself, and serve it's main purpose of image processing.... What do you think about this aspect of Image Sequencer? What are your goals for Image Sequencer in this regard?

jywarren · 2017-08-04T21:49:12Z

Very good thoughts, thanks.

I had to think about this for a bit. I think we definitely ought to provide a standard UI -- one which makes it very easy to try out and use the core modules.

But on consideration, what I'm proposing is not that we add all the features of main.js from fisheyegl to image-sequencer, but that we /remove/ them and come up with a standard way that fisheyegl -- or maybe fisheyegl-ui, a separate module that requires fisheyegl -- can provide a more complex HTML UI. Because I think many modules will have a very complex and refined way they enable people to interact with them in HTML.

I think the UI that fisheyegl provides should have its own CSS + HTML if it wants, and that we provide a minimal standard CSS in image-sequencer so things don't look too inconsistent.

How does that sound? Do you think modules should provide their own UI, or should have a corresponding _____-ui module that provide the UI? I lean towards providing their own as a default; they could opt for a separate UI module if they like, which then wraps the original module.

jywarren · 2017-08-04T21:50:28Z

If you like this proposal, fisheyegl's UI could be tidied up and modularized from its main.js file, and then we could test out this arrangement using this as the first module to provide its own UI. What do you think?

jywarren · 2017-08-04T21:54:36Z

test/image-manip.js

@@ -10,8 +10,8 @@ require('../src/ImageSequencer.js');
 //require image files as DataURLs so they can be tested alike on browser and Node.
 var sequencer = ImageSequencer({ ui: false });

-var test_png = require('../examples/test.png.js');
-var test_gif = require('../examples/test.gif.js');
+var test_png = require('../examples/images/test.png.js');


Perhaps we should keep test images in /test/images/ even if it's redundant... what do you think?

Yes that does sound good. I shall do that.

Fixed this in an upcoming commit

jywarren · 2017-08-04T21:56:11Z

test/image-sequencer.js

@@ -42,7 +42,7 @@ test('loadImages loads a DataURL image and creates a step.', function (t){

 if(!sequencer.options.inBrowser)
  test('loadImage loads an image from URL and creates a step. (NodeJS)', function (t){
-    sequencer.loadImage('URL','https://ccpandhare.github.io/image-sequencer/examples/red.jpg', function(){
+    sequencer.loadImage('URL','https://ccpandhare.github.io/image-sequencer/examples/images/red.jpg', function(){


I like that you want to test this, but I'm concerned about making tests rely on an internet connection. Is there any other way to do this? I guess we can leave it as is for now, but you know what I mean? It just ... feels a bit wrong i guess... but I can't come up with a really really good reason why :-)

Yes, I had thought about this, too.
But I just couldn't come up with a substitute for this.
Maybe we could run this test if and only internet access is available?

I am checking for internet access in an upcoming commit.
Hope that is sufficient.

jywarren · 2017-08-04T21:57:19Z

I guess also, what does this mean for this PR? Could we, or should we:

just merge this in and think about the custom UI provision separately
use this as the first instance of a module providing its own UI -- test out this idea?

Thanks for thinking through this carefully. It really does get us deeply into the UI phase of the work :-)

jywarren · 2017-08-05T18:04:03Z

Sure! But let's output a note that we're skipping due to no internet.

…

On Aug 5, 2017 1:47 PM, "Chinmay Pandhare" ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In test/image-sequencer.js <#62 (comment)> : > @@ -42,7 +42,7 @@ test('loadImages loads a DataURL image and creates a step.', function (t){ if(!sequencer.options.inBrowser) test('loadImage loads an image from URL and creates a step. (NodeJS)', function (t){ - sequencer.loadImage('URL','https://ccpandhare.github.io/image-sequencer/examples/red.jpg', function(){ + sequencer.loadImage('URL','https://ccpandhare.github.io/image-sequencer/examples/images/red.jpg', function(){ Yes, I had thought about this, too. But I just couldn't come up with a substitute for this. Maybe we could run this test if and only internet access is available? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#62 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ8q1f3koYJ40SjjmdFcM8CYb09-iks5sVKqZgaJpZM4OZn8y> .

ccpandhare · 2017-08-05T18:06:00Z

Thanks for the review! To sum up and suggest further changes:

We had a discussion about whether image sequencer should provide a UI or not. We concluded that Image Sequencer should provide a basic UI and that modules should have the liberty to suggest UI.
Further thoughts on this: I think the module should specify only the elements and the general CSS of image-sequencer should be responsible for styling. Which means modules specify the UI but not style it. What do you think?

ccpandhare · 2017-08-05T18:06:33Z

I think this is a major upgrade and should go in a different PR

jywarren · 2017-08-05T18:09:44Z

Agreed on everything except that sometimes CSS will be needed for functional reasons of UI like positioning. So the CSS convention should be a recommendation only? Or it's for font styling and such, but not all CSS. Great! So let's merge this and move our recap to a new issue + PR. Thanks!!

…

On Aug 5, 2017 2:06 PM, "Chinmay Pandhare" ***@***.***> wrote: - I think this is a major upgrade and should go in a different PR — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#62 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ7KpOWdSIKhMv-ikseJV-B-3PrkVks5sVK8qgaJpZM4OZn8y> .

ccpandhare · 2017-08-06T12:04:40Z

Okay!

ccpandhare · 2017-08-06T12:22:50Z

If you are fine with the changes I made, I shall merge this in!

jywarren

Looks fantastic. Great work! :-) 🎈

ccpandhare added 6 commits July 16, 2017 17:32

demo for FisheyeGl

8d8cf33

demo for FisheyeGl - Bugfixes

43d55d2

Demo Created

e6a96d7

Demo Created

dd595f3

Changed Title in Demo

dc9b9bc

Improved Demo

b963dfd

ccpandhare mentioned this pull request Jul 17, 2017

Removed Global Variables, Added a Test to check this #63

Merged

ccpandhare added the almost-complete PRs that are almost done but little more work. label Jul 26, 2017

ccpandhare self-assigned this Jul 28, 2017

ccpandhare added 3 commits August 1, 2017 01:32

Merge Commit

187f664

Organize examples directory, Recreate FisheyeGl Demo of fisheyegl usi…

b8ec24c

…ng Image Sequencer UI

Modified tests

02ec74b

ccpandhare added ready-to-merge and removed almost-complete PRs that are almost done but little more work. labels Aug 1, 2017

ccpandhare mentioned this pull request Aug 1, 2017

Rework UI Handling #85

Closed

jywarren reviewed Aug 4, 2017

View reviewed changes

ccpandhare mentioned this pull request Aug 6, 2017

Custom UI for modules #87

Closed

Made Requested Changes

812cd80

jywarren approved these changes Aug 6, 2017

View reviewed changes

jywarren merged commit 14b1152 into publiclab:master Aug 6, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Demo for FisheyeGl Module #62

Added Demo for FisheyeGl Module #62

ccpandhare commented Jul 17, 2017

ccpandhare commented Aug 1, 2017 •

edited

Loading

ccpandhare commented Aug 1, 2017

ccpandhare commented Aug 2, 2017

jywarren commented Aug 3, 2017

ccpandhare commented Aug 3, 2017 via email

jywarren commented Aug 3, 2017 via email

ccpandhare commented Aug 4, 2017

jywarren commented Aug 4, 2017

jywarren commented Aug 4, 2017

jywarren Aug 4, 2017

ccpandhare Aug 5, 2017

ccpandhare Aug 6, 2017

jywarren Aug 4, 2017

ccpandhare Aug 5, 2017

ccpandhare Aug 6, 2017 •

edited

Loading

jywarren commented Aug 4, 2017

jywarren commented Aug 5, 2017 via email

ccpandhare commented Aug 5, 2017

ccpandhare commented Aug 5, 2017

jywarren commented Aug 5, 2017 via email

ccpandhare commented Aug 6, 2017

ccpandhare commented Aug 6, 2017

jywarren left a comment

Added Demo for FisheyeGl Module #62

Added Demo for FisheyeGl Module #62

Conversation

ccpandhare commented Jul 17, 2017

ccpandhare commented Aug 1, 2017 • edited Loading

ccpandhare commented Aug 1, 2017

ccpandhare commented Aug 2, 2017

jywarren commented Aug 3, 2017

ccpandhare commented Aug 3, 2017 via email

jywarren commented Aug 3, 2017 via email

ccpandhare commented Aug 4, 2017

jywarren commented Aug 4, 2017

jywarren commented Aug 4, 2017

jywarren Aug 4, 2017

Choose a reason for hiding this comment

ccpandhare Aug 5, 2017

Choose a reason for hiding this comment

ccpandhare Aug 6, 2017

Choose a reason for hiding this comment

jywarren Aug 4, 2017

Choose a reason for hiding this comment

ccpandhare Aug 5, 2017

Choose a reason for hiding this comment

ccpandhare Aug 6, 2017 • edited Loading

Choose a reason for hiding this comment

jywarren commented Aug 4, 2017

jywarren commented Aug 5, 2017 via email

ccpandhare commented Aug 5, 2017

ccpandhare commented Aug 5, 2017

jywarren commented Aug 5, 2017 via email

ccpandhare commented Aug 6, 2017

ccpandhare commented Aug 6, 2017

jywarren left a comment

Choose a reason for hiding this comment

ccpandhare commented Aug 1, 2017 •

edited

Loading

ccpandhare Aug 6, 2017 •

edited

Loading