Removed Global Variables, Added a Test to check this #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great but are the Travis tests stalled? Should this be needed before or after the fisheyegl PR? Thanks! |
|
This can be merged in Anytime... Shouldn't be a problem. |
|
But preferably after FisheyeGl. |
|
The build has passed! |
|
:-) -- since fisheyegl may take a bit longer to open a PR on and such, go
ahead and merge this if you'd like to get it off your plate! Great catch
and good refactor. Thanks!
…On Mon, Jul 17, 2017 at 9:04 AM, Chinmay Pandhare ***@***.***> wrote:
The build has passed!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#63 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ4Y2rbZzfDtnOJmru7ChZRzlre4gks5sO1vkgaJpZM4OZvYW>
.
|
|
Okay, will merge! Actually, FisheyeGl is pretty god as of now. |
|
And thanks for the compliment! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While making a demo, I realized that ImageSequencer was producing 22 Global Variables:
v,formatInput,args,arg,json_q,format_i,i,loadedimages,datauri,image,insert,img,s,j,indices,callback,prevstep,drawarray,no_steps,init,input,this_.I have fixed this issue and created a new Unit test to check that no Global Variables are being created.