Show people in a region as a bulleted list within the popup

[jywarren]

After fixing #123, it's showing that there are "2 people" but we should be instead showing a list of the people, like:

* firstPerson
* secondPerson

Originally posted by @jywarren in #123 (comment)

[jywarren]

[jywarren]

That's odd. There should be a list already:

leaflet-blurred-location-display/src/ui/gridCenterRectangle.js

Lines 74 to 90 in bb806bb

	// generates an unordered list of marker links to fill a popup with
	function generatePopupContentsFromMarkers(markers) {
	let popupContents = "<p><b>People within this region:</b></p>";
	popupContents += "<ul>";
	if (markers[0].hasOwnProperty('url') && markers[0].hasOwnProperty('url')) {
	markers.forEach(function(marker) {
	if (marker.hasOwnProperty('url') && marker.hasOwnProperty('url')) {
	popupContents += "<li><a href='" + marker.url + "'>@" + marker.title + "</a></li>";
	}
	});
	} else {
	popupContents += "<p>" + markers.length + " people</p>";
	}
	popupContents += "</ul>";
	popupContents += "<p>These people have blurred their location. Learn about <a href='https://publiclab.org/location-privacy'>location privacy here</a>.</p>";
	return popupContents;
	}

[jywarren]

Aha! I think what happens is that it shows the count if there is no "url" property of the people. But on PublicLab.org, we do pass that. So it should be OK when run over there. I think we just need to release a new version here.

[jywarren]

Published as v1.3.1! https://www.npmjs.com/package/leaflet.blurred-location-display cc @daemon1024

[daemon1024]

We will need to reopen this.

Ref publiclab/plots2#10033 (comment)

it seems that the parsed_data you mentioned here, is only for temporary use.

leaflet-blurred-location-display/src/blurredLocationDisplay.js

Line 147 in d5cff82

var parsed_data = options.JSONparser(data) ; // JSONparser defined by user used here !

we use it here, what we store in the markers object is

leaflet-blurred-location-display/src/blurredLocationDisplay.js

Lines 164 to 168 in d5cff82

	var m = L.marker([latitude, longitude], {
	icon: icon_color
	}) ;
	SourceUrl_id_map.set(id , m) ;
	all_markers_map.set(id , m) ;

is the leaflet marker object mapped to id. So there's no URL at all and hence no list of people names.

[jywarren]

Aha! Ok, excellent debugging! Hopefully we can solve this with a PR here and then through LEL to plots2 again?

Great detective work, @daemon1024!!!

[daemon1024]

Sure, I am on it. Can be assigned to me :)