Show people in a region as a bulleted list within the popup

[daemon1024]

Fixes #133

[welcome]

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

[daemon1024]

It works 😄

[daemon1024]

/cc @jywarren

[daemon1024]

//offtopic
Btw just noticed, we could use some updates on welcome bot messages. Potential good first issues, across repositories.

[jywarren]

//offtopic
Btw just noticed, we could use some updates on welcome bot messages. Potential good first issues, across repositories.

great idea.

OK, and this one is good to merge?

[jywarren]

Looks like it! Thanks!!!

[jywarren]

Would you like to add a package.json version increment of 0.0.1?

[jywarren]

and run npm install so we get an updated package-lock.json too? Then I'll be able to publish it as a new version on NPM

[daemon1024]

Done :)

[welcome]

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://publiclab.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

[jywarren]

As soon as this publishes, let's link and follow to the PR in LEL, and then same to plots2 -- sound good? Thank you!!! Also doesn't have to be tonight, it's so late!

[daemon1024]

Yup, Sounds good to me. Thank You and Good Night 🌃

[jywarren]

Published! Good night!!!

[jywarren]

If dependabot doesn't open it, we can open it manually!

[jywarren]

Yay! publiclab/leaflet-environmental-layers#562

[jywarren]

OK! We more or less got it... still seeing an "undefined" but very close!!! Did we use the wrong property name?

publiclab/plots2#10050

[jywarren]

Hmm.

 {
      "doc_id": 768638,
      "doc_type": "PLACES",
      "doc_url": "/profile/charliejohnson",
      "doc_title": "charliejohnson",
      "doc_score": null,
      "doc_author": null,
      "doc_image_url": "https://www.gravatar.com/avatar/6e62cf8e8246c20b6b9839c175dc996a",
      "latitude": "0",
      "longitude": "0",
      "blurred": true,
      "category": "PLACES",
      "place_name": null,
      "created_at": "2021-08-10T11:07:07.000Z",
      "time_since": null,
      "comment_count": null
    }

[jywarren]

Here, it should work, i think:

leaflet-blurred-location-display/src/blurredLocationDisplay.js

Line 60 in 86e8739

obj["title"] = data.items[i].doc_title ;

[daemon1024]

The url is right, just the title is undefined somehow 🤔

[jywarren]

For the screenshot above, I was def. getting doc_title values...

{
  "doc_id": 766513,
  "doc_type": "PLACES",
  "doc_url": "/profile/dennlawgroup",
  "doc_title": "dennlawgroup",
  "doc_score": null,
  "doc_author": null,
  "doc_image_url": "/public/system/users/photos/000/766/513/thumb/denn-law-logo-1x-2.png",
  "latitude": "42",
  "longitude": "-71",
  "blurred": true,
  "category": "PLACES",
  "place_name": null,
  "created_at": "2021-07-21T08:33:27.000Z",
  "time_since": null,
  "comment_count": null
}

[jywarren]

Aha!!!!

https://github.com/publiclab/leaflet-environmental-layers/blob/702ebe1877ad9d816bd9856798607b325b7ffe13/src/PLpeopleLayer.js#L22-L39

[jywarren]

We override the JSONparser function in LEL!

[daemon1024]

Ohhh.

[daemon1024]

So just one more release then :D Making a PR asap.