Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simpl.html added, the page just has a map with no grid or center square. #58

Merged
merged 3 commits into from
Jul 26, 2017
Merged

Simpl.html added, the page just has a map with no grid or center square. #58

merged 3 commits into from
Jul 26, 2017

Conversation

mridulnagpal
Copy link
Member

No description provided.

jywarren
jywarren reviewed Jul 24, 2017
View reviewed changes
Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you upload a screenshot and also link to this from the README? Thanks!!

@mridulnagpal
Copy link
Member Author

image
Here's a piece of it, also I added two new methods enableCenterShade() and disableCenterShade() which enable and disable center shade. Adding this to gh-pages as well so that I can link it to README as well

@mridulnagpal
Copy link
Member Author

mridulnagpal commented Jul 24, 2017 •
edited
Loading

Got really comfortable with gh-pages will upload everything I do on the server, feel free ti test the demo https://mridulnagpal.github.io/leaflet-blurred-location/examples/simple.html

@jywarren
Copy link
Member

This looks good but if we're inputting by placename, we should make the "in Text" version say the same as the input placename, no? Would we need to have some kind of flag like location.fromPlacename == true or something, so we know not to reverse geocode if it was input by string in the first place?

Or better, could we save the input placename as a string, and return that, as location.placename, but if there's no input placename, then we fall back to reverse geocoding? That last sounds like a good solution; let's make a separate issue, and a test and solution in a PR. We can merge this once that's opened.

@jywarren jywarren mentioned this pull request Jul 26, 2017
Closed
@jywarren
Copy link
Member

OK, did that!

@jywarren jywarren merged commit 5447ad1 into publiclab:master Jul 26, 2017
jywarren
jywarren reviewed Jul 26, 2017
View reviewed changes
README.md
@@ -13,6 +13,7 @@ leaflet-blurred-location provides friendly interfaces for:
## Setting up leaflet-blurred-location

To set up the library first clone this repo to your local after that run 'npm install' to install all the neccessary packages required. Then open `examples/index.html` to look at the preview of the library.
There is a simpler version as well which is a simple location entry namely `examples/simple.html`, you can view all there files online using gh-pages of the repo.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

best simply link to the gh-pages directly as well so people can click and follow the link!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jywarren jywarren jywarren left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mridulnagpal @jywarren