Outreachy Project Recap: summary, planning & discussion

[crisner]

Completed tasks

Plots2

• Map layer permalinks get overwritten on page open (issue Map layer permalinks get overwritten on page open #6889) PR#293
• Add a zoom:xx power tag for map zoom along with lat and lon when saving location Save zoom when saving lat and lon in popup modal #7019 PR Save zoom in location modal #7020
• Enable embedded maps in wiki pages, notes and questions
• Add prompt to Dashboard (/dashboard) to add user location, if user doesn’t have a location set.
• Fix location input on /people/ Add your location on /people page doesn't work? #5882 PR Fix add your location on /people/ page #6895
• Fix location tagging in user profiles PR Fix tagging user profiles and add JS ajax function #6886
• In /map/ create space for the footer Push footer below map in /map/ #7048
• Use zoom:xx tag in lead and sidebar maps Add zoom override to maps in sidebar and top of page #7078
• Get permalinks on /map/wiki_slug#zoom/lat/lon pages as you drag
• Add “View map” button to geotagged page sidebars, opening /map/SLUG for wikis, and /map#zoom/lat/lon permalink for notes IN Create /map/ route for wiki pages #7061
• Make /map/wiki_slug routes that source lat/lon/zoom from matching wiki page Create /map/ route for wiki pages #7061
• Add tests for /map/ IN Create /map/ route for wiki pages #7061
• Redirect /maps to /map, leave /archive as archive IN Create /map/ route for wiki pages #7061

Update 'new post' location form:

• Fix click-and-pan freezing error
• Debug search-for-location in the location selector Location search not working leaflet-blurred-location#214 and New post location form: bug on the search-for-location #6915
• Update the styling based on Natalie's proposal Location form on /post/ has inconsistent styling #6968 PR Clean up styling of location form #6969
• Add default location of user's profile location, allow user to remove or change it Geographic: Set a default location of user's profile location on /post/ #6946 PR Add default location to /post #6957
• Add check for zoom tag, if not present calculate zoom level from lat and lon and save zoom - included in Add default location to /post #6957

Project: Redesign of location popup modal

• Create mockups and post images for feedback and approval New design for location popup modal #7031
• Update user profile location method - choose inline or popup modal - New design for location popup modal #7031

Testing:

• Fix New system tests fail due to timing issues new system test fails due to probably timing issue #6904 PR Fix new system tests for adding tags to node and user #6951

PL.Editor

• Save zoom in submitted data Add zoom to saved data PublicLab.Editor#373 PR Save zoom level PublicLab.Editor#374

LBL

• Add getZoom function Create getZoom function leaflet-blurred-location#221 PR add getZoom() leaflet-blurred-location#223
• Add getZoomFromCoordinates function Create getZoomFromCoordinates function leaflet-blurred-location#222 PR Create getZoomFromCoordinates(lat, lon) leaflet-blurred-location#224
• Write tests for the new functions - included in PR Create getZoomFromCoordinates(lat, lon) leaflet-blurred-location#224
• Add new functions to Readme API Add new functions to README leaflet-blurred-location#225 PR Add functions to readme leaflet-blurred-location#226

LBLD

• Fix google api test errors in LBLD PR#95

LEL

Embed

• Work on embed feature PR#296
• Make domain name as a settable option defaulting to the gh-pages PR#307

New Layers Menu

• Replace leaflet layer control in the demo with the layers browser menu from the mockup in #232 PR#320
• Display new layers menu when instantiating LEL with one liner code #347 PR#353
• Add media queries for layers menu for screen size 235x300 PR#378
• Collect layer metadata PR#317
• Collect urls for "requests" from layers if they are open to community submissions #138 PR#317
• Implement the report functionality on the layers browser menu for layers that accept reports like OdorLog PR#320
• Add a contribute button to osm #337 PR#345
• Track the bounding box of each layer, and display only those which intersect with current view #117 PR#320
• Make layers without bounds to display in all views instead of using hardcoded bounds #117 PR#332

New layer alert

• Display "new items" mark in Layers menu when you enter an area with a new layer #133 PR#341

Minimal mode

• Implement minimal mode as discussed in issue #123. PR#356
• Show a button to toggle between default mode and minimal mode. PR#356

Search feature

• Search not open by default but behind a magnifying glass icon that pops open PR#326
• Implement a search functionality to search for a location to re-center upon with a search button and autocomplete geocoder(discussed in #134) PR#326

Layer changes

• Implement changes in fractracker_mobile layer #87) PR#330
• Include Unearthing layer to the demo page PR#352
• Get PLpeopleLayer working in LEL PR#361

Example/demo pages

• Display notice on top of map in the demo page PR#309
• Clone demo page to embed.html so that only the embed.html shows the notice and points to the demo page in its embed code PR#311
• Add demo with multiple maps in a single page PR#356

LEL basic usage changes

• Fix active base layer selection PR#300
• Add 'display' parameter to show specific layers in LEL PR#353
• Other new options/parameters include baseLayers, simpleLayerControl, addLayersToMap, and hostname.

Documentation

• Make layer names listing in README and layers hash strings consistent PR#315
• Write documentation for new layer menu control PR#343

Testing

• Write tests for embed control PR#314
• Write tests for layer browser PR#329
• Write tests for minimal dots view PR#356
• Write tests for oneliner/basic implementation PR#397

Refactor/clean up

• Reformat/clean up code PR#303

[crisner]

Bugs Fixed

Plots2

• On /map/ if you type in lat=0&lon=115 it does not show you the right location IN Use default location lat lon for /map/ #7046
• Fix error at /map/ with no layers are specified Use default location lat lon for /map/ #7046
• Fix map at top of profile and add zoom value Fix map on profile and add check for zoom tag #7089
• Permalinks on /map/ should show current location in URL hash even when using default data IN Create /map/ route for wiki pages #7061
• Fix navbar covering top of /map/ push map below floating nav bar #7189
• addTag javascript function does not process place powertags correctly Remove geocodeStringAndPan to fix place powertag in javascript #7159
• Map popups not working Map popups not working #7281
• Map markers for nodes only show up after map interaction Map markers for nodes only appear after map interaction, not on initial load  #6910
• View on a map from notes page results in "NaN" in URL View on a map from notes pages results in "NaN" in URL #7357
• Fix sidebar maps not working Sidebar map layers not working #7381 and Default baselayer not loading properly on inline maps leaflet-environmental-layers#376 PR Maps cleanup to fix sidebar and inline map problems #7404
• Cross-wired zoom and layer issues on map Cross-wired zoom and layer issues on inline maps #7397 PR Maps cleanup to fix sidebar and inline map problems #7404
• Sidebar is interfering with full-width inline maps Sidebar is interfering with full-width inline maps #7395 PR Map control layers #7425

LBL

• Slider in LBL does not update when map is used to zoom in and out research popup menu too long for netbook screens and won't scroll #230
• Fix location saved as "Location unavailable" forced password reset #232
• Fix Google API warning in tests in LBL version history for everything #233

LEL

• Fix active base layer selection PR#300
• Embed code URL has duplicated text PR#340
• Fix error when baseLayers option is not added PR#351
• Unearthing demo not visible in publiclab.org mail notifications getting lost in spam filters? #349 PR#352
• Fix PLpeopleLayer test failures in LEL PR#358
• Fix missing layers in layer menu on refresh PR#375

Tasks posted for FTO/GCI

• FTO: Change script path in map dependencies to match with LEL Change script path in map dependancies to match with LEL #6978 (repo: plots2; status: completed)
• GCI: Map covers Publish button email relative link fixes, deep link header scrolling, fixes #156 #367 (repo: publiclab editor)
• GCI: Make map instructions open in new window additional style tweaks #366 (repo: publiclab editor)
• GCI: New post form goes off-screen at small screen sizes New post form goes off-screen at small screen sizes #6970 (repo: publiclab editor)
• FTO: Make title on /post/ full width Make "Share" title full width on /post/ #6979 (repo: plots2; status: completed)
• FTO: Add documentation on using embed control Blog template and design improvements #305 (repo: LEL; status: completed)
• FTO: Update usage of hash library in documentation Missing research note #304 (repo: LEL; status: completed)
• FTO: Edit documentation for using Windrose layer in readme.md diffs broke in wiki revisions #322 (repo: LEL; status: completed)
• FTO: Add hover style to all btn-outline-secondary buttons Add hover style to all btn-outline-secondary buttons #7051 (repo: plots2; status: completed)
• FTO: Remove incorrect color and extra space from button on Profile Remove incorrect color and extra space from button on Profile #7050 (repo: plots2; status: completed)
• FTO: Add prompt to Dashboard (/dashboard) to add user location, if user doesn’t have a location set (repo: plots2; status: completed)
• FTO: Change hover color on spam moderate buttons on admin dashboard Change hover color on spam moderate buttons on admin dashboard #7083 (repo: plots2; status: completed)
• FTO: Add hostname value to display the correct embed code Add hostname value to display the correct embed code #7217 (repo: plots2; status: completed)
• FTO: Top map only shows for tag place and not place:xx Top map only shows for tag "place" and not power tag "place:xx" #7148 (repo: plots2; status: completed)
• FTO-candidate: Invert button isn't making a dark background (repo: community toolbox; status: pending)
• FTO: Wiki page with place:xx tag shows two maps Wiki page with place:xx tag shows two maps #7149 (repo: plots2; status: completed)
• FTO: Prevent creating undefined layers-sub-list when the consecutive layer is not a group Issue Initiating Plots2 Ruby Instance on Cloud9 #333 (repo: LEL; status: completed)
• FTO: blurred:true not saved with location Blurred value not saved sometimes #7120 (repo: plots2; status: pending)
• FTO: Add 'Places' or 'Regions' (/map) to navbar Add "Places" (/map) to the navbar #7071 (repo: plots2; status: pending)
• FTO: Add prompt to Dashboard (/dashboard) to add user location, if user doesn’t have a location set At location button to dashboard sidebar #7263 (repo: plots2; status: completed)
• FTO: Add location modal script to dashboard Add location modal script to dashboard #7266 (repo: plots2; status: pending)
• FTO: Remove LEL embed button from inline maps Remove LEL embed button from inline maps #7230 (repo: plots2; status: completed)
• FTO: Fix missing embed icon Fix missing embed icon #7308 (repo: plots2; status: completed)
• FTO: Fix layer control not loaded on map page Fix layer control not loaded on map page #7344 (repo: plots2; status: pending)
• FTO: Prevent use of the same default tile layer for multiple maps timestamps to /edit links to null cache, #362 #363 (repo: LEL; status: completed)
• FTO: Add search control in one-liner code issue templates #369 (repo: LEL; status: pending)

[crisner]

Tasks left

Remaining tasks from the checklist here #6887 (comment)

• Write UI tests
• Display optional legends for each layer #103
• Stop displaying spinners if a layer fails to load for 10 seconds (issue #290)
• Zoom in on map based on user location using geolocation.(wonder if this is useful as maps are displayed based on location entered by the user in plots2.) ❔
• Implement a help functionality
  • Display option for users to file bug reports with the button directing users to a bug issue template
  • Option to request new layer that directs to an issue template. -> Layer submission process, per-layer metadata #135
  • An option to display information about the different elements in the map's UI(may be helpful to new users) may be as a modal or a simple faq or as walkthrough tooltips that can be skipped.
• Implement a features menu that can toggle other elements in the map's interface individually(except layers menu) from view.(Not sure about the usefulness of this functionality other than having 'simple' and personalized interface but just putting out here as this seemed like a good idea at the time)
• Create a function to make adding layers easier already in progress elsewhere as mentioned in #276
  • Reduce redundant layer code. A member is working on a plugin that helps avoid repetitive code when adding new layers which is mentioned in #276. We could try to use this.
• Standard methods for each layer like layer.show() layer.hide() layer.isVisible() #251
• Create a layer name aggregator function #253
• Create an option to toggle overlapping marker spiderfier feature for individual layers

Plots2

Remaining tasks from #6801 and #6993

• Project: Get notes, wikis and people showing on /map/ Fix map errors with new LEL 2.2.1 #7545
  • Use LEL PLpeople layer in /people/ map
  • Use LEL PLpeople layer in inline maps
• get popups showing title, link for each wiki, note, and question - on all maps, redesign popups
• add "Places" or "Regions" (/map) to the navbar - done elsewhere
• make “#” link in grey appear on wiki page popups that show /map/SLUG permalinks
• add a “Add to map +” button on /map/… pages to add a note, question or wiki at that location (go to a selection page between these options, at /post/choose?tags=lat:10,lon:10 -- preserving params!)
• research why PLpeople layer is so slow to load markers Research why loading nearbyPeople Srch API is so slow to load #7556

[crisner]

Tasks awaiting review/feedback

• Edit documentation in README for more clarity #354 PR#367
• Fix duplication of jquery script tags PR#373
• Refactor code in layers to replace jQuery with XHR PR#383
• Sidebar is interfering with full-width inline maps PR#7425
• Out of extents layers are not removed from the map when hash is set to false #379 PR#380

Tasks in progress

plots2

• get popups showing title, link for each wiki, note, and question - on all maps, redesign popups
• make “#” link in grey appear on wiki page popups that show /map/SLUG permalinks
• add a “Add to map +” button on /map/… pages to add a note, question or wiki at that location (go to a selection page between these options, at /post/choose?tags=lat:10,lon:10 -- preserving params!)

LEL

• Add people layer explanation in browser menu
• Fix inline map baselayer not showing correctly #376
• Combine layer metadata into a single file #371

[crisner]

Tasks to finish up the completed tasks

We may need to prioritize these over the others

Plots2

• Check media queries for layers menu on the LEL instances
• Testing - Tests for multiple inline maps - [Priority: high]

LEL

• Fix inline map baselayer not showing correctly Default baselayer not loading properly on inline maps leaflet-environmental-layers#376 in progress - [Priority: high]

• New Layers Menu - [Priority: high] Combine layer metadata into a single file Combine layer metadata into a single file leaflet-environmental-layers#371 (in progress)

• New layer alert - [Priority: low] It only displays the number of new layers now. Should we also highlight them when the user expands the layers menu similar to the image below?
  

• Search Feature - [Priority: high] - We have the search feature only in the demo file. It needs to be included in the one-liner LEL basic usage code. There is an open PR on an FTO for the same awaiting review/feedback.

• Documentation - [Priority: high]

  • Reordered and edited existing readme file awaiting review/feedback
  • Combining json files in progress
  • Linking sections of the layer details from json to the layer name in the readme file not started

• Testing - [Priority: high]

  • Tests need to be added to the one liner implementation #397
  • Tests may be needed for custom implementation in demo file
  • Tests need to added for layers that don't have them

[crisner]

Other planning issues/ideas list that we had bookmarked:

• Making note of new ideas and other tasks leaflet-environmental-layers#334
• Follow-up tasks for new /map... route #6993
• Planning issue for 2019-20 geographic features work #6801
• Planning overview (revised!) leaflet-environmental-layers#134

[crisner]

@nstjean, I have narrowed down some tasks here #7432 (comment) and marked high priority so that we can focus on completing them first. For tests in LEL I think we should prioritize testing for the one-liner code first. What do you think? Any other tasks that need to be under this list especially in plots2?

[crisner]

New layer alert - [Priority: low] It only displays the number of new layers now. Should we also highlight them when the user expands the layers menu similar to the image below?

Moved the low priority task from here to here publiclab/leaflet-environmental-layers#334.

[nstjean]

Yes I agree, I think testing for the one liner code first would be good because that's pretty much what we are using in plots2 - or will be using shortly. I'll go through it all and see if anything needs to be added to the high priority list.

[nstjean]

I have updated the Plots2 list above for what's left to do for this project.

[cesswairimu]

Awesome 🚀

[crisner]

cc: @sagarpreet-chadha

[sagarpreet-chadha]

Just Wowoww :)

[nstjean]

I finally got the tests done! This is so exciting. 😆 publiclab/leaflet-environmental-layers#397 - ready for review

I had to fix a bug with the initialized param values: publiclab/leaflet-environmental-layers#396 (merged)

I also did a little clean-up while I was in there: publiclab/leaflet-environmental-layers#401 - ready for review

Now all I need is for LEL to be bumped so I can finish in plots2. Here's the drafted release:
https://github.com/publiclab/leaflet-environmental-layers/releases/tag/2.2.1

[crisner]

Other tasks in the priority list as discussed here publiclab/leaflet-environmental-layers#399 (comment) [Awaiting feedback]

1. Once a layer is added to the map let the layer be visible both on the map and the layer menu but keep the layer from requesting data if the map is not intersecting with the layer's extents. [Priority: high]

2. The layers that are not displayed on the map will be filtered from the layer menu. We could add a feature that lets the user decide if they want to keep the layers filtered or if they want everything to be listed. [**Priority:**low]

3. We have an alert that notifies users of new layers available. We may have to highlight the new layers as well so the users can locate the new layers easily. [Priority: mid]

[crisner]

Tests for the demo page ready for review: publiclab/leaflet-environmental-layers#400

[crisner]

Update

These tasks that were awaiting feedback or in progress in #7432 (comment) have been completed/merged

• Edit documentation in README for more clarity #354 PR#367
• Fix duplication of jquery script tags PR#373
• Sidebar is interfering with full-width inline maps PR#7425
• Out of extents layers are not removed from the map when hash is set to false #379 PR#380
• Fix sidebar map errors Sidebar map layers not working #7381
• Fix inline map baselayer not showing correctly #376 - This has been addressed in Maps cleanup to fix sidebar and inline map problems #7404

[crisner]

Adding this here to include to the list of priority tasks.

• Show a "didn't load" broken icon next to a layer if it fails to fetch data #410

[crisner]

PRs ready for review/merge:

• Combine layer metadata into a single file PR#385
• Improve test timings in current cypress tests PR#412
• Improve layer menu's filtering and layer displaying features PR#409
• Write tests for eonet fires layer PR#407

cc: @sagarpreet-chadha, @cesswairimu

[nstjean]

PR Ready for review/merge: #7545
@cesswairimu @SidharthBansal

[sagarpreet-chadha]

Hey, i have reviewed the above PR's :)

@crisner , can you point me to the PR where you have integrated the cypress. Thanks!!!
Just a heads up -> I am planning to work on integrating Cucumber tests to cypress soon. This will make LEL more awesome 😄

[crisner]

Thanks!!

Just a heads up -> I am planning to work on integrating Cucumber tests to cypress soon. This will make LEL more awesome

Awesome! Can't wait! 🎉 😄

can you point me to the PR where you have integrated the cypress.

This is the PR where I set up Cypress #400 and this is the PR where I set cypress up with Travis CI #403

[nstjean]

PR ready for review/merge in LBLD: publiclab/leaflet-blurred-location-display#96

PR ready for review/merge in LEL: publiclab/leaflet-environmental-layers#401

@cesswairimu @sagarpreet-chadha @SidharthBansal

[sagarpreet-chadha]

I will review today. Thanks

[crisner]

PR#417 and PR#419 ready for review and feedback.

[crisner]

PR#426 ready for feedback and review.

[nstjean]

PR publiclab/leaflet-environmental-layers#430 ready for feedback and review

PR #7562 is erroring in travis and I'm not sure why.

[nstjean]

I do need this PR publiclab/leaflet-blurred-location-display#96 in LBLD do get merged and a new version published in NPM.

[crisner]

The following PRs are ready for review/feedback:
#438
#432
#436
#434
#428
#424

[crisner]

I have added tests for all layers other than those that use tiles.

[jywarren]

This is some incredibly epic work!!!! Congratulations to you both and many thanks! I am going through these today. This is so awesome!!!

[jywarren]

Going through last batch of @crisner's PRs now! Thanks!

[jywarren]

OK, leaving needs-rebase label on some PRs, but looking fantastic. Thanks!!! https://github.com/publiclab/leaflet-environmental-layers/labels/needs-rebase

Please leave the label on OR add a new ready-to-merge label. Or merge them yourself if you can, they all look good to me!!!

[jywarren]

And just a clarification on publiclab/leaflet-environmental-layers#424 but it seems OK to me as-is!

[jywarren]

And just looking now to see where any remaining plots2 PRs or issues are, so we can get the /map/ and /map/____ pages running! Sorry for lots of chatter today, it's my first day back!

I see #7545 -- very awesome!!!

[jywarren]

Closing this up! Thank you!!!