New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up code to have consistent formatting #303
Clean up code to have consistent formatting #303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 26 files that have been changed,, somethings wrong please have a look into it.
Thank you for pointing it out @newbazz! It shows 26 files because it includes all layer and util js files and the ESLint config files. The clean up was done in all 22 of js files. I do not know if it is recommended to clean up all files at once though. :) |
@sagarpreet-chadha, would like your feedback on this. Changes in this PR include setting up ESLint and cleaning up files to have consistent formatting. Thanks! |
@crisner the pr should be atomic, can you please have 2 separate prs for 2 issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been in my to-do checklist from a very long time. Thank you so much!!!
This is great. @crisner @sagarpreet-chadha is this good to merge? Thanks!! |
Fixes #301 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!