Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up code to have consistent formatting #303

Merged

Conversation

crisner
Copy link
Contributor

@crisner crisner commented Dec 14, 2019

Fixes #301 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR
  • code is in uniquely-named feature branch and has no merge conflicts 馃搧
  • screenshots/GIFs are attached 馃搸 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

Copy link

@newbazz newbazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 26 files that have been changed,, somethings wrong please have a look into it.

@crisner
Copy link
Contributor Author

crisner commented Dec 14, 2019

Thank you for pointing it out @newbazz! It shows 26 files because it includes all layer and util js files and the ESLint config files. The clean up was done in all 22 of js files. I do not know if it is recommended to clean up all files at once though. :)

@crisner
Copy link
Contributor Author

crisner commented Dec 14, 2019

@sagarpreet-chadha, would like your feedback on this. Changes in this PR include setting up ESLint and cleaning up files to have consistent formatting. Thanks!

@newbazz
Copy link

newbazz commented Dec 14, 2019

@crisner the pr should be atomic, can you please have 2 separate prs for 2 issues.

Copy link
Collaborator

@sagarpreet-chadha sagarpreet-chadha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been in my to-do checklist from a very long time. Thank you so much!!!

@jywarren
Copy link
Member

This is great. @crisner @sagarpreet-chadha is this good to merge? Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make code formatting consistent across files
4 participants