Move login page styling to stylesheets

[cesswairimu]

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

Description

Rails convention is that styling should not be done on the view level

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

• 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

• 📝 Update these files https://github.com/publiclab/mapknitter/blob/main/app/views/layouts/_login_form.html.erb and https://github.com/publiclab/mapknitter/blob/main/app/assets/stylesheets/style.scss (press the little pen Icon) and edit the line as shown below.

1. Delete these block of code https://github.com/publiclab/mapknitter/blob/main/app/views/layouts/_login_form.html.erb#L38-L45

2. At the end of this file https://github.com/publiclab/mapknitter/blob/main/app/assets/stylesheets/style.scss add this piece of code

 #open_id_form button{
  width: 70px;
  background-color: #ffffff;
  border: none;
  margin-right: 0.25rem;
  }

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

$DIFF

• 💾 Commit your changes

• 🔀 Start a Pull Request. There are two ways how you can start a pull request:

1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

2. You can also edit files directly in your browser and open a pull request from there.

• 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

Relevant URLs

http://mapknitter-stable.laboratoriopublico.org/maps/test

The page to be changed is https://github.com/publiclab/mapknitter/blob/main/app/views/maps/show.html.erb

[cesswairimu]

@alexido19 here you go

[briannadeg]

I would like to do this please

[alexido19]

@cesswairimu Thanks on it!

[alexido19]

@cesswairimu Done! Review needed

[cesswairimu]

@alexido19 I see two pull requests...U need to push the changes to one branch and make one pull request with both files changed.

[cesswairimu]

Hey @alexido19...progress on this? did you figure out how to push the changes to one branch? or you can just make another pull request with both the changes and close the two existing ones. Thanks

[b18050]

i will like to take this issue.

[gr455]

Hey @cesswairimu , can I work on this issue?

[cesswairimu]

Hey @gr455, sure go ahead. Thanks