Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update style.css #1080

Closed
wants to merge 1 commit into from
Closed

Update style.css #1080

wants to merge 1 commit into from

Conversation

alexido19
Copy link

@alexido19 alexido19 commented Oct 8, 2019

Stylesheet Updated. Review needed!

Fixes #1065

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

[//]: (To mark checkbox write 'x' within the square brackets)

  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 馃搧
  • screenshots/GIFs are attached 馃搸 in case of UI updation
  • ask @publiclab/mapknitter-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

Stylesheet Updated. Review needed!
@welcome
Copy link

welcome bot commented Oct 8, 2019

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 馃憤馃帀馃槃

@codeclimate
Copy link

codeclimate bot commented Oct 8, 2019

Code Climate has analyzed commit 78296d1 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Oct 8, 2019

Codecov Report

Merging #1080 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1080   +/-   ##
=======================================
  Coverage   74.03%   74.03%           
=======================================
  Files          40       40           
  Lines        1398     1398           
=======================================
  Hits         1035     1035           
  Misses        363      363

@alexido19
Copy link
Author

@publiclab/mapknitter-reviewers review needed

Copy link
Contributor

@VladimirMikulic VladimirMikulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alexido19! You've forgotten the step 1 of the issue. You should delete <style> block at the bottom of the _login_form.html.erb file.

@cesswairimu
Copy link
Collaborator

This PR has been open for a long time and no activity/ reviews requested has not been addressed. We understand you might be busy and engaged on other things. I am closing this for now...please feel free to reopen if you get some time and would like to finish this. Rem to check if its still available before you reopen. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move login page styling to stylesheets
3 participants