-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Liking (stars) for maps #126
Comments
Hey! I'd like to take this issue! |
Let's name the model `map_reactions` and have a `reaction_type` column that
has default `like`, but we could add `follow` or others in the future. How
does that sound? Thanks, and we'd love help -- i do think we are /very/
interested in full unit testing for any new feature so please bear that in
mind!
…On Thu, Feb 7, 2019 at 12:02 PM Kaustubh Nair ***@***.***> wrote:
Hey! I'd like to take this issue!
I'm thinking of creating a model called map_likes with map_id and user_id
as attributes. Would this be sufficient or should I rename it to something
else in case you would incorporate other features like followers?
Also should there be any email notification sent after liking?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#126 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ2FHaGwWWHhqpDpMbiHYx1X1xkAbks5vLFvqgaJpZM4DlQZW>
.
|
Sound's good. What other kind of reactions are we having? Github like reactions? |
potentially -- best to just plan ahead!
But wait - what if we thought a bit more about this and made reactions to
individual images instead of to maps? We are considering making the
platform more image centric in any case. What do you think?
…On Thu, Feb 7, 2019 at 2:49 PM Kaustubh Nair ***@***.***> wrote:
Sound's good. What other kind of reactions are we having? Github like
reactions?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#126 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ6pDExuUjWPpbubAkQnSZxarWfHnks5vLIMdgaJpZM4DlQZW>
.
|
Interesting.. |
Yes, i think though that there's a conceptual change we're considering,
especially because it may be faster to just start uploading images instead
of starting by "creating a map", and then people can just select any group
of images to generate an export. Then images can "belong" to multiple
collections for export. We're not 100% set on it but it does seem like a
simpler mental model with a few less steps. I think either way, it may be
useful to "like" or react to individual images rather than whole maps. Is
that helpful? Thanks!
…On Thu, Feb 7, 2019 at 3:47 PM Kaustubh Nair ***@***.***> wrote:
Interesting..
I'm new to Mapknitter here, isn't the point to stitch the images together
to create a map?
What's more important to the user: the individual images or the stitched
map?
But if we're going to be more image centric then adding reactions to
images makes more sense!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#126 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ53qkEC6iC_3ZTgUtcaCbcGYA4ulks5vLJDAgaJpZM4DlQZW>
.
|
Sounds cool! |
just like on publiclab.org
The text was updated successfully, but these errors were encountered: