Increase Test Coverage

[alaxalves]

I have realized that currently on Mapknitter we have ~60% of test coverage according to this right?!
I think that before we start we the upgrade it would be a MUST if we raised that to >80% minimum, as recommended here. Or we could be more ambitious and set a goal of 100%.
After this we could move forward with the upgrade. What do you think @kaustubh-nair @SidharthBansal @jywarren ?

[jywarren]

Hi @alaxalves I believe Cess is already taking steps towards a Rails 4.0 upgrade here: #578

CodeCov cites ~70% coverage here: https://codecov.io/gh/publiclab/mapknitter

However, I think more test coverage would be great, and 80 or near 100% would be a great goal. I think @rarrunategu1 may be helping us with this as well in the coming weeks.

I would love to see us use this analysis tool to identify where we can increase our coverage:

https://codecov.io/gh/publiclab/mapknitter/tree/main/app

many of the low-rated files are quite simple, so I think we can pretty easily increase our coverage!

[SidharthBansal]

Regarding test coverage, I think, we have create a lot of tests too. We miss many important test cases. I examined some flows, we have only 2-3 tests for those flows but there should be more test cases for them. So, may be we can create ftos for them later on.

[kaustubh-nair]

I agree. We should aim for aroung 85% and pay special attention to edge cases

[alaxalves]

@jywarren Could you add me and @kaustubh-nair to Mapknitter's Collaborators team with "write" privileges so that I can create the things proposed here by @SidharthBansal ??

[jywarren]

Yeah!!! I just did.

[kaustubh-nair]

I'll start adding tests, since @alaxalves is doing #598

[jywarren]

awesome!

…

On Wed, May 15, 2019 at 9:36 AM Kaustubh Nair ***@***.***> wrote: I'll start adding tests, since @alaxalves <https://github.com/alaxalves> is doing #598 <#598> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#594?email_source=notifications&email_token=AAAF6J2R4WIPGPKG7OQD7S3PVQGURA5CNFSM4HMP3MFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVOVVII#issuecomment-492657313>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J6M2S4XS6HTISOBYGTPVQGURANCNFSM4HMP3MFA> .

[alaxalves]

I'll start adding tests, since @alaxalves is doing #598

Thank you @kaustubh-nair I love DevOps, that's why I had to get #598 😄 😄 😄. Let me know if I can help you with anything. BTW, @cesswairimu said in #578 (comment) that she started this testing stuff. Maybe you could take advantage of his work.