Removed additional will_paginate call on _maps

[chethanagopinath]

Fixes #1437

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/mapknitter-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[welcome]

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

[codeclimate]

Code Climate has analyzed commit fa9ff45 and detected 0 issues on this pull request.

View more on Code Climate.

[chethanagopinath]

@publiclab/mapknitter-reviewers Please let me know if my fix is okay. Thank you!

[codecov]

Codecov Report

Merging #1452 into main will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1452   +/-   ##
=======================================
  Coverage   72.98%   72.98%           
=======================================
  Files          40       40           
  Lines        1399     1399           
=======================================
  Hits         1021     1021           
  Misses        378      378           

[cesswairimu]

Thanks for opening this @chethanagopinath 🎉, I have noticed removing this removes the pagination at /gallery
I think removing on the pagination on https://github.com/publiclab/mapknitter/blob/main/app/views/users/profile.html.erb might work without breaking other pages. Could you please check.

[chethanagopinath]

@cesswairimu Sure, will check that out now :) thank you!

[chethanagopinath]

@cesswairimu I checked the gallery view and my change does indeed make the pagination there disappear, so I've made changes according to what you've outlined and it works :) Thank you so much for helping me out!

[cesswairimu]

Great 🎉

[welcome]

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://mapknitter.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page. Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.