Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 馃幐 allow only active users to log in #1823

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PeculiarE
Copy link
Contributor

Fixes #1815

  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 馃搧
  • screenshots/GIFs are attached 馃搸 in case of UI updation
  • ask @publiclab/mapknitter-reviewers for help, in a comment below

@gitpod-io
Copy link

gitpod-io bot commented Aug 22, 2022

@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #1823 (75b0e7d) into main (3affa8b) will decrease coverage by 0.65%.
The diff coverage is 7.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1823      +/-   ##
==========================================
- Coverage   67.44%   66.79%   -0.66%     
==========================================
  Files          40       40              
  Lines        1321     1337      +16     
==========================================
+ Hits          891      893       +2     
- Misses        430      444      +14     
Impacted Files Coverage 螖
app/controllers/sessions_controller.rb 29.34% <3.84%> (-3.99%) 猬囷笍
app/models/user.rb 97.36% <50.00%> (-2.64%) 猬囷笍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit login process to allow only active users
1 participant