Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spam button with "ban" icon #398

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Conversation

govindjeevan
Copy link
Contributor

@govindjeevan govindjeevan commented Mar 12, 2019

References #396 (<=== Add issue number here)

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

  • tests pass -- rake test
  • code has been rebased on top of latest master (check if another pull request was added recently, and please rebase)
  • pull request is descriptively named and, if possible, multiple commits squashed if they're smaller changes

Thanks!

@welcome
Copy link

welcome bot commented Mar 12, 2019

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@jywarren
Copy link
Member

This is perfect!!! Great job. 🎉

If you're interested, we'd love help in getting other people's first contributions reviewed and helping troubleshoot! And if you'd like to create a new first-timers-only issue for someone else, please check out publiclab/plots2#4963

Thanks again!

@jywarren jywarren merged commit 3b7ca30 into publiclab:main Mar 12, 2019
@welcome
Copy link

welcome bot commented Mar 12, 2019

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://mapknitter.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

chen-robert pushed a commit to chen-robert/mapknitter that referenced this pull request Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants