-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve toggle sidebar #451
Conversation
Show only maps with at least one image in main listing
@jywarren @SidharthBansal @gauravano please review |
Oops, can you remove passenger.3001.pid and passenger.3001.pid.lock? Then this is good to merge, thanks so much!!! |
@jywarren @gauravano @SidharthBansal please review me. |
Hi @avsingh999, please remove the merge conflicts here. Thanks! |
Code Climate has analyzed commit 9c8ee86 and detected 0 issues on this pull request. View more on Code Climate. |
@avsingh999 @gauravano @jywarren I pulled this implementation and it was not working for me. @avsingh999 Perhaps your rebase might have pulled in some changes that were not compatible with your code. I didn't look into this too much because I figured there was a much simpler way to go about this anyway, and I committed that here. @avsingh999 let me know if this is fine with you! Always happy to revert if you have any objections. -- sorry it wouldn't let me add you as a reviewer for some reason but would like your review on this pls :) |
Codecov Report
@@ Coverage Diff @@
## main #451 +/- ##
=======================================
Coverage ? 70.07%
=======================================
Files ? 31
Lines ? 1243
Branches ? 0
=======================================
Hits ? 871
Misses ? 372
Partials ? 0 Continue to review full report at Codecov.
|
@avsingh999 @gauravano @jywarren my view after this rebase and my commit looks just like the one @avsingh999 posted a gif of above. |
👍 |
* Show only maps with at least one image in main listing * Update Leaflet.DistortableImage version * improve setting dropdown * improve toggle sidebar * Delete passenger.3001.pid * Delete passenger.3001.pid.lock * Update map.js
Fixes #446 (<=== Add issue number here)
Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!
rake test
Thanks!