improve toggle sidebar

[avsingh999]

Fixes #446 (<=== Add issue number here)

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

• tests pass -- rake test
• code has been rebased on top of latest master (check if another pull request was added recently, and please rebase)
• pull request is descriptively named and, if possible, multiple commits squashed if they're smaller changes

Thanks!

[avsingh999]

@jywarren @SidharthBansal @gauravano please review

[jywarren]

Oops, can you remove passenger.3001.pid and passenger.3001.pid.lock? Then this is good to merge, thanks so much!!!

[avsingh999]

@jywarren @gauravano @SidharthBansal please review me.
thanks ; )

[grvsachdeva]

Hi @avsingh999, please remove the merge conflicts here. Thanks!

[codeclimate]

Code Climate has analyzed commit 9c8ee86 and detected 0 issues on this pull request.

View more on Code Climate.

[sashadev-sky]

@avsingh999 @gauravano @jywarren I pulled this implementation and it was not working for me. @avsingh999 Perhaps your rebase might have pulled in some changes that were not compatible with your code. I didn't look into this too much because I figured there was a much simpler way to go about this anyway, and I committed that here.

@avsingh999 let me know if this is fine with you! Always happy to revert if you have any objections. -- sorry it wouldn't let me add you as a reviewer for some reason but would like your review on this pls :)

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (main@9b09a9b). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #451   +/-   ##
=======================================
  Coverage        ?   70.07%           
=======================================
  Files           ?       31           
  Lines           ?     1243           
  Branches        ?        0           
=======================================
  Hits            ?      871           
  Misses          ?      372           
  Partials        ?        0

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b09a9b...9c8ee86. Read the comment docs.

[sashadev-sky]

@avsingh999 @gauravano @jywarren my view after this rebase and my commit looks just like the one @avsingh999 posted a gif of above.

Before my commit this is what I was seeing:

[jywarren]

👍