Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme.md updated #650

Merged
merged 1 commit into from
May 31, 2019
Merged

Readme.md updated #650

merged 1 commit into from
May 31, 2019

Conversation

divyabaid16
Copy link
Contributor

Fixes #649 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 馃搧
  • screenshots/GIFs are attached 馃搸 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Thanks!

@divyabaid16
Copy link
Contributor Author

@publiclab/mapknitter-reviewers

kaustubh-nair
kaustubh-nair approved these changes May 31, 2019
View reviewed changes
Copy link
Member

@kaustubh-nair kaustubh-nair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 馃憤

@jywarren
Copy link
Member

Great!!! @sashadev-sky just noting this!

@jywarren jywarren merged commit 0ab127a into publiclab:main May 31, 2019
@divyabaid16 divyabaid16 deleted the readme-order branch June 1, 2019 05:23
@divyabaid16 divyabaid16 mentioned this pull request Jun 5, 2019
Closed
chen-robert pushed a commit to chen-robert/mapknitter that referenced this pull request Dec 5, 2019
@divyabaid16 @chen-robert
Updated (publiclab#650)
9a8f58d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaustubh-nair kaustubh-nair kaustubh-nair approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Readme
3 participants
@divyabaid16 @jywarren @kaustubh-nair