action cable setup #805

ViditChitkara · 2019-07-04T20:27:24Z

Solves #804

welcome · 2019-07-04T20:27:27Z

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

ViditChitkara · 2019-07-04T20:28:13Z

Still working on this as a part of synchronous image placement.

codecov · 2019-07-04T20:29:40Z

Codecov Report

Merging #805 into development will increase coverage by 0.4%.
The diff coverage is 96.15%.

@@              Coverage Diff               @@
##           development     #805     +/-   ##
==============================================
+ Coverage        72.78%   73.18%   +0.4%     
==============================================
  Files               37       40      +3     
  Lines             1356     1380     +24     
==============================================
+ Hits               987     1010     +23     
- Misses             369      370      +1

Impacted Files	Coverage Δ
app/channels/application_cable/channel.rb	`100% <100%> (ø)`
app/models/map.rb	`93.33% <100%> (+0.13%)`	⬆️
app/controllers/application_controller.rb	`88.88% <100%> (+0.65%)`	⬆️
app/controllers/images_controller.rb	`75.94% <100%> (+0.62%)`	⬆️
app/channels/application_cable/connection.rb	`100% <100%> (ø)`
app/channels/concurrent_editing_channel.rb	`83.33% <83.33%> (ø)`

ViditChitkara · 2019-07-06T18:23:09Z

Hi @jywarren @divyabaid16 I think the basic action cable setup is kind of complete. If you could have a look at it. Also, action cable requires puma to run so added 'puma' gem.

ViditChitkara · 2019-07-08T18:43:51Z

Any ideas on this??

alaxalves · 2019-07-09T15:42:22Z

In order to Action Cable to work does it need a Puma server running? If so I think we'll need a sidekiq executor to schedule the running processes, such as passenger, action cable and such...

ViditChitkara · 2019-07-09T15:50:32Z

Yes I think it requires puma server running. Tried it on my local machine wasn't working without puma. I didn't really understand the sidekiq part. Can you shed some more details on that.
Thanks for looking into this!!

ViditChitkara · 2019-07-14T17:11:43Z

I think the room and broadcasting is done here. But we need to figure out a way to update the map on each user's browser according to the json of warpables which is going to be recieved.
Json will be something like this:-

    "id": 101,
    "parent_id": null,
    "image_content_type": "image/png",
    "image_file_name": "apply-form-image.png",
    "thumbnail": null,
    "image_file_size": 627035,
    "width": 1758,
    "height": 2877,
    "created_at": "2019-07-14T08:50:46.393Z",
    "updated_at": "2019-07-14T09:09:44.781Z",
    "map_id": 2,
    "nodes": [
      {
        "id": 105,
        "color": "black",
        "author": "vidit",
        "lat": "28.941683305",
        "lon": "78.7811565399",
        "way_id": 0,
        "order": 0,
        "created_at": "2019-07-14T09:09:44.711Z",
        "updated_at": "2019-07-14T09:09:44.711Z",
        "name": "",
        "description": "",
        "map_id": 0,
        "way_order": 0,
        "body": null
      },

ViditChitkara · 2019-07-14T17:12:36Z

@jywarren if you could have a look at the code and suggest any changes if needed? I'll open a separate issue for the map update part.

ViditChitkara · 2019-07-19T20:10:09Z

@jywarren @jainaman224 @divyabaid16 if you could have a look at it. The synchronisation part is working pretty well now. However we'd now need to work on the locking part so that multiple users are not able to edit a single simultaneously for a particular instance which may cause conflict.
If anyone could review the changes until now so that we could could confirm if we are on the right path and then move forward. @cesswairimu @sashadev-sky you may want to have a look here!!
Thanks, this is really interesting.

ViditChitkara · 2019-07-19T20:11:57Z

app/assets/javascripts/mapknitter/Map.js

@@ -462,6 +462,28 @@ MapKnitter.Map = MapKnitter.Class.extend({
    if (this.editing._mode != "lock") e.stopPropagation()
  },

+  synchronizeData: function(warpables) {


The updation corresponding to each change will happen with the help of this function. This function gets all the necessary information related to the warpables on the map (which are broadcasted my the server on the concurrent_editing_channel)

ViditChitkara · 2019-07-19T20:12:37Z

app/channels/application_cable/connection.rb

+    end
+
+    private
+    def find_verified_user


This handles the authentication part.

ViditChitkara · 2019-07-19T20:13:12Z

app/channels/concurrent_editing_channel.rb

+    # Any cleanup needed when channel is unsubscribed
+  end
+
+  def sync changes


Whenever changes are made, this method is called and it broadcasts the updated data to the channel.

ViditChitkara · 2019-07-19T20:13:59Z

Gemfile

@@ -64,6 +64,7 @@ group :development, :test do
  gem 'byebug', '~> 11.0.1', platforms: [:mri, :mingw, :x64_mingw]
  gem 'faker', '~> 1.9.3'
  gem 'pry-rails', '~> 0.3.9'
+  gem 'puma'


The puma server is required by action cable for it's working.

jywarren · 2019-07-19T22:38:27Z

Wow this is tremendous! Can we hear from @rexagod about whether the automated placement code will also be able to integrate smoothly with this, or whether it's just based on user driven events?

…

On Fri, Jul 19, 2019 at 4:14 PM Vidit ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In Gemfile <#805 (comment)>: > @@ -64,6 +64,7 @@ group :development, :test do gem 'byebug', '~> 11.0.1', platforms: [:mri, :mingw, :x64_mingw] gem 'faker', '~> 1.9.3' gem 'pry-rails', '~> 0.3.9' + gem 'puma' The puma server is required by action cable for it's working. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#805?email_source=notifications&email_token=AAAF6J67DRUOW3KUPAL6GTDQAIOAPA5CNFSM4H57IQB2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB7BJUJI#pullrequestreview-264411685>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J5ERWPNVLI7SBDNDILQAIOAPANCNFSM4H57IQBQ> .

ViditChitkara · 2019-08-14T20:04:43Z

Also, I'm pretty much stuck with this error. Must be some sort of dependency error I'm not being able to figure out. @sashadev-sky @alaxalves could you please have a look at the console errors in the above screenshot and guide me, as to what might be wrong here?

Thanks a lot!

jywarren · 2019-08-15T15:27:30Z

OK thanks for the thorough explanation. Once the error is resolved, we'll aim to merge this /after/ the Rails 5 PR, if that's OK? Thank you!

…

On Wed, Aug 14, 2019 at 4:05 PM Vidit ***@***.***> wrote: [image: Screenshot 2019-08-15 at 1 31 08 AM] <https://user-images.githubusercontent.com/22616017/63052210-665e4180-befc-11e9-9e46-83c35fcc10a1.png> Also, I'm pretty much stuck with this error. Must be some sort of dependency error I'm not being able to figure out. @sashadev-sky <https://github.com/sashadev-sky> @alaxalves <https://github.com/alaxalves> could you please have a look at the console errors in the above screenshot and guide me, as to what might be wrong here? Thanks a lot! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#805?email_source=notifications&email_token=AAAF6J2FKPJ34GRU7HYZTULQERQNZA5CNFSM4H57IQB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4J6LKY#issuecomment-521397675>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J45M4BY6YMEL4XQLNLQERQNZANCNFSM4H57IQBQ> .

ViditChitkara · 2019-08-15T16:01:34Z

Sure, that would be great!! Till then, will work on adding some more docs and tests to it.
Sounds cool?

jywarren · 2019-08-15T16:33:10Z

Awesome! There are system tests in rails 5 - see the recently merged pr! This could allow for full stack JavaScript testing. :-)

…

On Thu, Aug 15, 2019, 12:02 PM Vidit ***@***.***> wrote: Sure, that would be great!! Till then, will work on adding some more docs and tests to it. Sounds cool? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#805?email_source=notifications&email_token=AAAF6J3ON2GCYEOBPQYDA43QEV4V5A5CNFSM4H57IQB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4MHBGA#issuecomment-521695384>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J4XYXGN6U74XB6YFSDQEV4V5ANCNFSM4H57IQBQ> .

ViditChitkara · 2019-08-15T16:37:44Z

That's awesome. I'll explore more there.
Thanks

alaxalves · 2019-08-16T00:33:38Z

Also, I'm pretty much stuck with this error. Must be some sort of dependency error I'm not being able to figure out. @sashadev-sky @alaxalves could you please have a look at the console errors in the above screenshot and guide me, as to what might be wrong here?

Thanks a lot!

I have fixed that in 62d6a80

jywarren · 2019-08-16T14:15:25Z

OK, looks like it was as Alax said, fixed in the Rails 5 merged PR, now complete! With this rebased, it should be good to merge. If you can add any system tests, go for it, please!

…into action-cable-integration

…ab/mapknitter into action-cable-integration

alaxalves · 2019-08-16T19:54:20Z

@ViditChitkara Can I merge this into development?

ViditChitkara · 2019-08-18T14:28:14Z

@ViditChitkara Can I merge this into development?

@alaxalves , Sure I think it's good to go now!!

jywarren · 2019-08-19T14:21:05Z

Looks like we're not passing tests right now; but as soon as we do, we should be good to merge into main branch. Alax, would that be a problem, or do you suggest another route?

ViditChitkara · 2019-08-19T15:00:37Z

[Screenshot]: tmp/screenshots/failures_test_warpables_change_flow.png ERROR["test_warpables_change_flow", #<Minitest::Reporters::Suite:0x0000000008d00310 @name="SynchronousTest">, 1.5737854239999933] test_warpables_change_flow#SynchronousTest (1.57s) Errno::ENOENT: Errno::ENOENT: No such file or directory @ rb_sysopen - /home/travis/build/publiclab/mapknitter/public/system/images/1/original/demo.png app/models/warpable.rb:57:insave_dimensions'
test/system/synchronous_editing_test.rb:12:in block in <class:SynchronousTest>

Seems like system tests are throwing some errors. I think there is some issue with some image demo.png. It's running perfectly on local, though.

Any ideas on this?

ViditChitkara · 2019-08-19T15:02:53Z

Trying to fix the controller tests.

ViditChitkara · 2019-08-20T05:38:38Z

Okay I think the tests are passing now!! @jywarren is it good to go now?

jywarren · 2019-08-20T17:32:55Z

Ah, there's still some conflicts to resolve - can you take a look? Thank you!

…into action-cable-integration

welcome · 2019-08-21T00:04:09Z

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://mapknitter.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page. Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

* Configurations update for rails 4.0 * ActiveSupport::Testing::Performance extracted to a gem * ruby prof required as a dependency * disable rubocop on bin folder * http patch * Comment out to allow testing * no longer supports plugin loading * lock to sprockets 2.12 * Active record patches * remove deprecated test syntax * fix failing tests * change new super class * replace right_aws with right_aws_api right_aws is no longer maintained, was throwing an error * lock to rails 4.2.11.1 * change rails version in install script * remove deprecation warnings * Change test lib to minitest, add minitest reporters * make app work * active record find patches * root_in_json include defaulted to false * confirm option removed in link helper * cookies serializer changed to hybrid * Change render :text to :plain render :text will be deprecated and poses a security risk * console for dev web * Check and fix interface functionality * fix export functionality * add protected attributes for the warpable model * fix image upload * Fix comments and images failing tests * include mass assignment security in annotations * render html for update images * clear mail array before every test * Fix codeclimate issues * skip failing test The test is failing because of different names in model(warpable) and controller(images) skipping this for now until we decide if we want to standardize the names * replace unprotected redirects * Fix codeclimate issues * Autofixing rubocop offenses and Problematic test for #578 (#667) * Autofixing rubocop offenses * Adding Rubocop to Travis pipelines and development branch * Fixing maps controller test * Fixing remaining offenses * change post test to create since action new is a get action * remove unprotected redirects * Fix codeclimate issues * Add yarn * Remove error log * Fix oauth icons * Modify package.json * Add yarn install to start.sh * Add leaflet google * Remove leaflet-google from package json * remove passenger error logs * Fix install script * Remove flag * Fix gemfile.lock * Fix gemfile.lock * Fix login * Upgrade Gemfile to Rails 5.0 * require rake' * Change config files * Add application record * Bump mysql * Local builds for Travis runners (#672) * Using local mysql for travis * Fix codeclimate issues * Refactoring yamls * Autofixing rubocop offenses and Problematic test for #578 (#667) * Autofixing rubocop offenses * Adding Rubocop to Travis pipelines and development branch * Fixing maps controller test * Fixing remaining offenses * Fixing unit tests * Adding docker build to travis pipelines * Adding docker build to travis pipelines * Staging builds in travis * fix travis.yml * Upgrading sintax of assets and using required gems * Using updated version of GDAL and installing required dependencies * Enabling cache in between builds * Test yarn for travis * Conditionalize rake db:setup for travis * Add semicolon * Remove comment * modify database.yml * Migrate seperately * Run create only for production * Locking newer Rails v * Running update task * Adding missing bootsnap gem * Fixing missing database * Adding missing listen gem * Fixing schema example version * Fixing migration versions * Updating dependencies for Rails 5 * Adding ApplicationMailer abstraction * Adding required initializers * Prefer require_relative instead of full path * Making associations not required by default * Regenerating schema file * Hotfixing MassAssigment * Upgrade web-console, remove mysql adapter override * Remove attr_accessible * Add rails-controller-testing gem * Follow new syntax for tests * Remove extra web-console from gemfile * Regenerating lock file * Fixing rubocop offenses and bundler version * Using correct Paperclip class as in rails/rails#26404 (comment) * Fix images functional tests * images controller test typecast to string * Fix rails logger * Fix map tests * Bumping rubocop version * Autofixing rubocop offenses * Including performance cop to rubocop * Refactoring deprecated routing and secret_token * Fixing routes for feed controller * Using correct routes for RSS builder * Fixing missing routes * Fixing travis bundler and yarn cache * Fixing bundle path * Splitting bundle and yarn verifications * Autofixing rubocop offenses * Fixing prod host for travis, private class usage and rubocop offenses * Upgrade to Rails 5.2 (#685) * Upgrade Gemfile to Rails 5.0 * require rake' * Change config files * Add application record * Bump mysql * Locking newer Rails v * Running update task * Adding missing bootsnap gem * Fixing missing database * Adding missing listen gem * Fixing schema example version * Fixing migration versions * Updating dependencies for Rails 5 * Adding ApplicationMailer abstraction * Adding required initializers * Prefer require_relative instead of full path * Making associations not required by default * Regenerating schema file * Hotfixing MassAssigment * Upgrade web-console, remove mysql adapter override * Remove attr_accessible * Add rails-controller-testing gem * Follow new syntax for tests * Remove extra web-console from gemfile * Regenerating lock file * Fixing rubocop offenses and bundler version * Using correct Paperclip class as in rails/rails#26404 (comment) * Fix images functional tests * images controller test typecast to string * Fix rails logger * Fix map tests * Bumping rubocop version * Autofixing rubocop offenses * Including performance cop to rubocop * Refactoring deprecated routing and secret_token * Fixing routes for feed controller * Using correct routes for RSS builder * Fixing missing routes * Fixing travis bundler and yarn cache * Fixing bundle path * Splitting bundle and yarn verifications * Fixing prod host for travis, private class usage and rubocop offenses * Enforcing params usage on get method * Using correct folder names to Rails >5 conventions * Enforcing params wrapping and adding missing front_ui route * Precompiling assets before serving * Improving Jenkins startup script * WIP action cable setup * basic action cable setup complete * minor change * minor changes * few changes * Using supported docker yaml version by Jenkins * Adding task to check database existance * Improving start script * Improving Makefile's recipes and target * Adding task to check database existance * Improving start script * Improving Makefile's recipes and target * Improving Makefile's recipes and target * Patching #803 * Improving Jenkins setup * initial working functionality complete * Fix map loading * h * Fixing Leaflet-Environmental-Layers map loading * h * leaflet * fix * change * updates * stop precompiling assets * precompile * Using correct Yarn, NPM and Node version, avoiding mismatch * Removing unwanted tags.js invocation * Improving Makefile recipe * Using node_modules/ as dependencies folder, since sass/node-sass#2050 (comment) * Upgrading Yarn dependencies * Removing duplicate rubocop directive * Removing test/ from codeclimate checks * Removing fixed FIXME comments * Removing fixed FIXME comments * Updating docs in README * Refactoring code * Bumping recaptcha and include methods * Adding Foreman gem * Scheduling Puma and Passenger servers * WIP action cable setup * basic action cable setup complete * minor change * minor changes * few changes * initial working functionality complete * Refactoring code * Adding Foreman gem * Scheduling Puma and Passenger servers * few minor fix * added a few tests * Refactoring connection module * Fixing migration version * Using strong params in requests * Using strong params in requests * Use Rack::Test::UploadedFile instead of ActionDispatch::Http::UploadedFile * added documentation * added more docs * added tests * Fix minor asset issue * Remove manual asset references and add them to application js * Fix asset ordering in application.js * Configure System tests (#936) * Add new system tests and fix minor asset loading * modify test * Add chromedriver to travis * Add sudo * Add dependencies to dockerfile * Properly installing chrome and chromedriver * Using puma as dependency and correct image controller * added a few tests * a few changes * remove unnecessary render * few test fixes * action cable setup (#805) * WIP action cable setup * basic action cable setup complete * minor change * minor changes * few changes * initial working functionality complete * Refactoring code * Adding Foreman gem * Scheduling Puma and Passenger servers * WIP action cable setup * basic action cable setup complete * minor change * minor changes * few changes * initial working functionality complete * Refactoring code * Adding Foreman gem * Scheduling Puma and Passenger servers * few minor fix * added a few tests * Refactoring connection module * Using strong params in requests * added documentation * added more docs * added tests * Using puma as dependency and correct image controller * added a few tests * a few changes * remove unnecessary render * few test fixes * Fixing CodeClimate issues * Synch editing add ons (#957) * few bug fixes * separate editing channels for different maps * test fixes * rubocop fixes * Undoing unwanted pattern set by Rubocop

* Configurations update for rails 4.0 * ActiveSupport::Testing::Performance extracted to a gem * ruby prof required as a dependency * disable rubocop on bin folder * http patch * Comment out to allow testing * no longer supports plugin loading * lock to sprockets 2.12 * Active record patches * remove deprecated test syntax * fix failing tests * change new super class * replace right_aws with right_aws_api right_aws is no longer maintained, was throwing an error * lock to rails 4.2.11.1 * change rails version in install script * remove deprecation warnings * Change test lib to minitest, add minitest reporters * make app work * active record find patches * root_in_json include defaulted to false * confirm option removed in link helper * cookies serializer changed to hybrid * Change render :text to :plain render :text will be deprecated and poses a security risk * console for dev web * Check and fix interface functionality * fix export functionality * add protected attributes for the warpable model * fix image upload * Fix comments and images failing tests * include mass assignment security in annotations * render html for update images * clear mail array before every test * Fix codeclimate issues * skip failing test The test is failing because of different names in model(warpable) and controller(images) skipping this for now until we decide if we want to standardize the names * replace unprotected redirects * Fix codeclimate issues * Autofixing rubocop offenses and Problematic test for publiclab#578 (publiclab#667) * Autofixing rubocop offenses * Adding Rubocop to Travis pipelines and development branch * Fixing maps controller test * Fixing remaining offenses * change post test to create since action new is a get action * remove unprotected redirects * Fix codeclimate issues * Add yarn * Remove error log * Fix oauth icons * Modify package.json * Add yarn install to start.sh * Add leaflet google * Remove leaflet-google from package json * remove passenger error logs * Fix install script * Remove flag * Fix gemfile.lock * Fix gemfile.lock * Fix login * Upgrade Gemfile to Rails 5.0 * require rake' * Change config files * Add application record * Bump mysql * Local builds for Travis runners (publiclab#672) * Using local mysql for travis * Fix codeclimate issues * Refactoring yamls * Autofixing rubocop offenses and Problematic test for publiclab#578 (publiclab#667) * Autofixing rubocop offenses * Adding Rubocop to Travis pipelines and development branch * Fixing maps controller test * Fixing remaining offenses * Fixing unit tests * Adding docker build to travis pipelines * Adding docker build to travis pipelines * Staging builds in travis * fix travis.yml * Upgrading sintax of assets and using required gems * Using updated version of GDAL and installing required dependencies * Enabling cache in between builds * Test yarn for travis * Conditionalize rake db:setup for travis * Add semicolon * Remove comment * modify database.yml * Migrate seperately * Run create only for production * Locking newer Rails v * Running update task * Adding missing bootsnap gem * Fixing missing database * Adding missing listen gem * Fixing schema example version * Fixing migration versions * Updating dependencies for Rails 5 * Adding ApplicationMailer abstraction * Adding required initializers * Prefer require_relative instead of full path * Making associations not required by default * Regenerating schema file * Hotfixing MassAssigment * Upgrade web-console, remove mysql adapter override * Remove attr_accessible * Add rails-controller-testing gem * Follow new syntax for tests * Remove extra web-console from gemfile * Regenerating lock file * Fixing rubocop offenses and bundler version * Using correct Paperclip class as in rails/rails#26404 (comment) * Fix images functional tests * images controller test typecast to string * Fix rails logger * Fix map tests * Bumping rubocop version * Autofixing rubocop offenses * Including performance cop to rubocop * Refactoring deprecated routing and secret_token * Fixing routes for feed controller * Using correct routes for RSS builder * Fixing missing routes * Fixing travis bundler and yarn cache * Fixing bundle path * Splitting bundle and yarn verifications * Autofixing rubocop offenses * Fixing prod host for travis, private class usage and rubocop offenses * Upgrade to Rails 5.2 (publiclab#685) * Upgrade Gemfile to Rails 5.0 * require rake' * Change config files * Add application record * Bump mysql * Locking newer Rails v * Running update task * Adding missing bootsnap gem * Fixing missing database * Adding missing listen gem * Fixing schema example version * Fixing migration versions * Updating dependencies for Rails 5 * Adding ApplicationMailer abstraction * Adding required initializers * Prefer require_relative instead of full path * Making associations not required by default * Regenerating schema file * Hotfixing MassAssigment * Upgrade web-console, remove mysql adapter override * Remove attr_accessible * Add rails-controller-testing gem * Follow new syntax for tests * Remove extra web-console from gemfile * Regenerating lock file * Fixing rubocop offenses and bundler version * Using correct Paperclip class as in rails/rails#26404 (comment) * Fix images functional tests * images controller test typecast to string * Fix rails logger * Fix map tests * Bumping rubocop version * Autofixing rubocop offenses * Including performance cop to rubocop * Refactoring deprecated routing and secret_token * Fixing routes for feed controller * Using correct routes for RSS builder * Fixing missing routes * Fixing travis bundler and yarn cache * Fixing bundle path * Splitting bundle and yarn verifications * Fixing prod host for travis, private class usage and rubocop offenses * Enforcing params usage on get method * Using correct folder names to Rails >5 conventions * Enforcing params wrapping and adding missing front_ui route * Precompiling assets before serving * Improving Jenkins startup script * WIP action cable setup * basic action cable setup complete * minor change * minor changes * few changes * Using supported docker yaml version by Jenkins * Adding task to check database existance * Improving start script * Improving Makefile's recipes and target * Adding task to check database existance * Improving start script * Improving Makefile's recipes and target * Improving Makefile's recipes and target * Patching publiclab#803 * Improving Jenkins setup * initial working functionality complete * Fix map loading * h * Fixing Leaflet-Environmental-Layers map loading * h * leaflet * fix * change * updates * stop precompiling assets * precompile * Using correct Yarn, NPM and Node version, avoiding mismatch * Removing unwanted tags.js invocation * Improving Makefile recipe * Using node_modules/ as dependencies folder, since sass/node-sass#2050 (comment) * Upgrading Yarn dependencies * Removing duplicate rubocop directive * Removing test/ from codeclimate checks * Removing fixed FIXME comments * Removing fixed FIXME comments * Updating docs in README * Refactoring code * Bumping recaptcha and include methods * Adding Foreman gem * Scheduling Puma and Passenger servers * WIP action cable setup * basic action cable setup complete * minor change * minor changes * few changes * initial working functionality complete * Refactoring code * Adding Foreman gem * Scheduling Puma and Passenger servers * few minor fix * added a few tests * Refactoring connection module * Fixing migration version * Using strong params in requests * Using strong params in requests * Use Rack::Test::UploadedFile instead of ActionDispatch::Http::UploadedFile * added documentation * added more docs * added tests * Fix minor asset issue * Remove manual asset references and add them to application js * Fix asset ordering in application.js * Configure System tests (publiclab#936) * Add new system tests and fix minor asset loading * modify test * Add chromedriver to travis * Add sudo * Add dependencies to dockerfile * Properly installing chrome and chromedriver * Using puma as dependency and correct image controller * added a few tests * a few changes * remove unnecessary render * few test fixes * action cable setup (publiclab#805) * WIP action cable setup * basic action cable setup complete * minor change * minor changes * few changes * initial working functionality complete * Refactoring code * Adding Foreman gem * Scheduling Puma and Passenger servers * WIP action cable setup * basic action cable setup complete * minor change * minor changes * few changes * initial working functionality complete * Refactoring code * Adding Foreman gem * Scheduling Puma and Passenger servers * few minor fix * added a few tests * Refactoring connection module * Using strong params in requests * added documentation * added more docs * added tests * Using puma as dependency and correct image controller * added a few tests * a few changes * remove unnecessary render * few test fixes * Fixing CodeClimate issues * Synch editing add ons (publiclab#957) * few bug fixes * separate editing channels for different maps * test fixes * rubocop fixes * Undoing unwanted pattern set by Rubocop

ViditChitkara changed the title ~~WIP action cable setup~~ action cable setup Jul 6, 2019

ViditChitkara added the needs-review label Jul 6, 2019

ViditChitkara mentioned this pull request Jul 10, 2019

Adding certain events to support concurrent editing publiclab/Leaflet.DistortableImage#328

Open

ViditChitkara added 5 commits July 13, 2019 23:30

WIP action cable setup

9b0487e

basic action cable setup complete

3b7b2bf

minor change

10d42f4

minor changes

c7af515

few changes

826745f

ViditChitkara force-pushed the action-cable-integration branch from 25cbe7a to 826745f Compare July 14, 2019 08:40

This was referenced Jul 14, 2019

Planning issue: Synchronous Editing #609

Open

Automatic map updation at user's brower publiclab/Leaflet.DistortableImage#345

Open

alaxalves force-pushed the development branch 2 times, most recently from 8e9fd3f to 2abced6 Compare July 16, 2019 12:12

alaxalves mentioned this pull request Jul 16, 2019

Weekly community Check-In #29 - Keep Reinventing #851

Closed

initial working functionality complete

6e8e33b

ViditChitkara commented Jul 19, 2019

View reviewed changes

app/channels/application_cable/connection.rb

end

private

def find_verified_user

Copy link

Member Author

ViditChitkara Jul 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This handles the authentication part.

ViditChitkara commented Jul 19, 2019

View reviewed changes

alaxalves added 3 commits August 16, 2019 15:04

Merge branch 'development' of https://github.com/publiclab/mapknitter …

a522eaa

…into action-cable-integration

Merge branch 'action-cable-integration' of https://github.com/publicl…

3b2274a

…ab/mapknitter into action-cable-integration

Using puma as dependency and correct image controller

ac8e40c

alaxalves force-pushed the action-cable-integration branch from 0bbef78 to ac8e40c Compare August 16, 2019 19:33

ViditChitkara added 2 commits August 18, 2019 18:28

added a few tests

f002ad0

a few changes

1464157

remove unnecessary render

b033cc5

few test fixes

e568fbe

Merge branch 'development' of https://github.com/publiclab/mapknitter …

7779a96

…into action-cable-integration

alaxalves merged commit 843a719 into development Aug 21, 2019

alaxalves mentioned this pull request Aug 21, 2019

Setting Action Cable #956

Merged

5 tasks

ViditChitkara mentioned this pull request Aug 21, 2019

Synch editing add ons #957

Merged

jywarren mentioned this pull request Oct 18, 2019

Follow-up fixes to synchronous editing #1097

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

action cable setup #805

action cable setup #805

ViditChitkara commented Jul 4, 2019 •

edited

Loading

welcome bot commented Jul 4, 2019

ViditChitkara commented Jul 4, 2019

codecov bot commented Jul 4, 2019 •

edited

Loading

ViditChitkara commented Jul 6, 2019

ViditChitkara commented Jul 8, 2019

alaxalves commented Jul 9, 2019

ViditChitkara commented Jul 9, 2019

ViditChitkara commented Jul 14, 2019

ViditChitkara commented Jul 14, 2019

ViditChitkara commented Jul 19, 2019

ViditChitkara Jul 19, 2019

ViditChitkara Jul 19, 2019

ViditChitkara Jul 19, 2019

ViditChitkara Jul 19, 2019

jywarren commented Jul 19, 2019 via email

ViditChitkara commented Aug 14, 2019

jywarren commented Aug 15, 2019 via email

ViditChitkara commented Aug 15, 2019

jywarren commented Aug 15, 2019 via email

ViditChitkara commented Aug 15, 2019

alaxalves commented Aug 16, 2019

jywarren commented Aug 16, 2019

alaxalves commented Aug 16, 2019

ViditChitkara commented Aug 18, 2019

jywarren commented Aug 19, 2019

ViditChitkara commented Aug 19, 2019

ViditChitkara commented Aug 19, 2019

ViditChitkara commented Aug 20, 2019

jywarren commented Aug 20, 2019

welcome bot commented Aug 21, 2019

action cable setup #805

action cable setup #805

Conversation

ViditChitkara commented Jul 4, 2019 • edited Loading

welcome bot commented Jul 4, 2019

ViditChitkara commented Jul 4, 2019

codecov bot commented Jul 4, 2019 • edited Loading

Codecov Report

ViditChitkara commented Jul 6, 2019

ViditChitkara commented Jul 8, 2019

alaxalves commented Jul 9, 2019

ViditChitkara commented Jul 9, 2019

ViditChitkara commented Jul 14, 2019

ViditChitkara commented Jul 14, 2019

ViditChitkara commented Jul 19, 2019

ViditChitkara Jul 19, 2019

Choose a reason for hiding this comment

ViditChitkara Jul 19, 2019

Choose a reason for hiding this comment

ViditChitkara Jul 19, 2019

Choose a reason for hiding this comment

ViditChitkara Jul 19, 2019

Choose a reason for hiding this comment

jywarren commented Jul 19, 2019 via email

ViditChitkara commented Aug 14, 2019

jywarren commented Aug 15, 2019 via email

ViditChitkara commented Aug 15, 2019

jywarren commented Aug 15, 2019 via email

ViditChitkara commented Aug 15, 2019

alaxalves commented Aug 16, 2019

jywarren commented Aug 16, 2019

alaxalves commented Aug 16, 2019

ViditChitkara commented Aug 18, 2019

jywarren commented Aug 19, 2019

ViditChitkara commented Aug 19, 2019

ViditChitkara commented Aug 19, 2019

ViditChitkara commented Aug 20, 2019

jywarren commented Aug 20, 2019

welcome bot commented Aug 21, 2019

ViditChitkara commented Jul 4, 2019 •

edited

Loading

codecov bot commented Jul 4, 2019 •

edited

Loading