Fix codecov inconsistencies

[kaustubh-nair]

Fixes #810

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/mapknitter-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[codeclimate]

Code Climate has analyzed commit 0681e2e and detected 0 issues on this pull request.

View more on Code Climate.

[codecov]

Codecov Report

Merging #837 into main will increase coverage by 14.36%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #837       +/-   ##
===========================================
+ Coverage   58.04%   72.41%   +14.36%     
===========================================
  Files          35       35               
  Lines        1423     1334       -89     
===========================================
+ Hits          826      966      +140     
+ Misses        597      368      -229

Impacted Files	Coverage Δ
app/models/map.rb	93.1% <0%> (+2.06%)	⬆️
app/models/warpable.rb	87.5% <0%> (+7.95%)	⬆️
app/helpers/application_helper.rb	50% <0%> (+14.7%)	⬆️
app/controllers/sessions_controller.rb	32.91% <0%> (+32.91%)	⬆️
app/controllers/maps_controller.rb	91.66% <0%> (+91.66%)	⬆️

[kaustubh-nair]

I guess that worked?

[kaustubh-nair]

Let's try one last time

[kaustubh-nair]

Nice!
@jywarren I've think got it fixed
I ran the tests thrice with no decrease in coverage. Let's see how this goes

[alaxalves]

There's no need to add this additional step to Travis, causing the build to be slower, I think you could just add test/reports to .gitignore (if its not there already), then remove this folder if its commited. But let's hear from @jywarren.

[kaustubh-nair]

It's already in .gitignore
@alaxalves Can you help removing it from git tracking?

[alaxalves]

I don't think this has worked :( check out codecov @kaustubh-nair

[kaustubh-nair]

Huhhhhhh

[kaustubh-nair]

Okay I guess this fixed it? I'm still not sure what the exact problem is. I don't know how this is possible but is travis caching any old reports maybe? @alaxalves?
Anyway @jywarren let's merge this and see how it goes
Thanks!

[alaxalves]

Okay I guess this fixed it? I'm still not sure what the exact problem is. I don't know how this is possible but is travis caching any old reports maybe? @alaxalves?
Anyway @jywarren let's merge this and see how it goes
Thanks!

Travis doesn't cache old reports because basically we "tell" him what to cache and since we have deleted the reports from git tracking it won't cache. Also everytime Travis uses a different runner and caching is made through a generated .tar.gz pack. But this seems to be working now. Maybe we had to explicitly set the formatter to be codecov.

[jywarren]

Ok cool! Great work piecing this together. Did you want to merge this now? 🎉👍🏽

[kaustubh-nair]

@jywarren Yes lets merge this now

[jywarren]

👍