-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Strings to Translation Function Call in _tab_content.html.erb #10166
Comments
Reserving this in the next 24 hours for @Tiwarisonal19 |
@Tiwarisonal19, let me know if you want this FTO issue! |
Can I take this issue if its open? |
@noi5e Yes, I want this issue. |
@Tiwarisonal19 Okay great, go ahead, and let us know if you need anything else! @ZacharyGillmore if you're looking for a first-timer issue, I'll add you to the list at #10153 |
@Tiwarisonal19 How are you doing with this? Let us know if you need any help! 🤗 Just a reminder that we re-assign FTO issues after one week with no response. But if you need more time, no problem, just let us know. |
@noi5e I'm unable to find the two files to update actually, in the plots2 repository that I have to update, and it also won't allow me to propose changes , it says that I need to be on the branch to do so, Yes please reassign this to me, so that I can figure this out and finish it. |
@noi5e I have made a pull request for the config/locales/en.yml: kindly review it. |
@Tiwarisonal19 Hmm, I see that you made a pull request into the forked repo on your GitHub account here. The pull request actually needs to go into Public Lab's original repository here. You'll need to open another pull request. There are instructions on how to make a pull request here if you're using the command line. If you're editing the files directly through GitHub, just make sure you're on
I think this might be what you're talking about: Yes, it's true that you won't be able to edit the Hope that helps! Let me know if other questions come up. |
hey can i try this? |
I want to task issue #10166 @Tiwarisonal19 |
Hi, can I take this issue or it's already solved ? |
Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.
If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!
We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝
If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!
🤔 What you will need to know.
Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.
📋 Step by Step
🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
📝 Update the following TWO files below in the
plots2
repository (press the little pen Icon) and edit the line as shown below.See this page for some help in taking your first steps!
Below is a "diff" showing in red (and a
-
) which lines to remove, and in green (and a+
) which lines to add:1.
app/views/tag/show/_tab_content.html.erb
:2.
config/locales/en.yml
:456 show: +457 displaying_content: "Displaying content from" 458 notes_tagged: "Notes tagged with <i style=\"color:#aaa;\">%{tag}</i>"
💾 Commit your changes
🔀 Start a Pull Request. There are two ways how you can start a pull request:
If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.
Please keep us updated
💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!
If this happens to you, don't sweat it! Grab another open issue.
Is someone else already working on this?
🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.
👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!
🤔❓ Questions?
Leave a comment below!
The text was updated successfully, but these errors were encountered: