Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes Made : Strings to Translation Function Call in _tab_content.… #10239

Closed
wants to merge 2 commits into from

Conversation

Sshashank5690
Copy link

@Sshashank5690 Sshashank5690 commented Oct 2, 2021

…html.erb

Fixes #10166

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@welcome
Copy link

welcome bot commented Oct 2, 2021

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄

@gitpod-io
Copy link

gitpod-io bot commented Oct 2, 2021

@codecov
Copy link

codecov bot commented Oct 2, 2021

Codecov Report

Merging #10239 (c504732) into main (a6a96c3) will decrease coverage by 0.21%.
The diff coverage is n/a.

❗ Current head c504732 differs from pull request most recent head 53247be. Consider uploading reports for the commit 53247be to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main   #10239      +/-   ##
==========================================
- Coverage   82.34%   82.12%   -0.22%     
==========================================
  Files          98       98              
  Lines        5970     5982      +12     
==========================================
- Hits         4916     4913       -3     
- Misses       1054     1069      +15     
Impacted Files Coverage Δ
app/controllers/tag_controller.rb 80.72% <0.00%> (-4.31%) ⬇️
app/models/drupal_file.rb 36.84% <0.00%> (-1.26%) ⬇️
app/controllers/comment_controller.rb 82.53% <0.00%> (-0.28%) ⬇️
app/controllers/application_controller.rb 90.42% <0.00%> (-0.20%) ⬇️
app/models/comment.rb 77.63% <0.00%> (-0.15%) ⬇️
app/models/concerns/node_shared.rb 90.29% <0.00%> (ø)
app/models/tag.rb 93.26% <0.00%> (+0.03%) ⬆️
app/controllers/home_controller.rb 96.05% <0.00%> (+0.10%) ⬆️
app/models/node.rb 90.71% <0.00%> (+0.15%) ⬆️

@TildaDares TildaDares closed this Oct 4, 2021
@TildaDares TildaDares reopened this Oct 4, 2021
@TildaDares
Copy link
Member

TildaDares commented Oct 4, 2021

Hi @Sshashank5690, can you add the issue number like this #1234 in your first comment on this PR? Thanks!

@codeclimate
Copy link

codeclimate bot commented Dec 3, 2021

Code Climate has analyzed commit 53247be and detected 0 issues on this pull request.

View more on Code Climate.

@TildaDares
Copy link
Member

Hi @Sshashank5690, we appreciate the time you took to open this PR but I'll have to close it since another PR #10234 has already resolved this issue. We deeply appreciate your contributions and hope you make your contributions. Thank you!!

@TildaDares TildaDares closed this Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Strings to Translation Function Call in _tab_content.html.erb
3 participants