Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Strings to Translation Function Call in _errorMessages.html.erb #10258

Closed
5 tasks
DalilaBA opened this issue Oct 5, 2021 · 14 comments
Closed
5 tasks

Comments

@DalilaBA
Copy link
Contributor

DalilaBA commented Oct 5, 2021

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file _errorMessages.html.erb in the Plot2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

- 3     <h2><%= pluralize(model.errors.count,"error")%> prohibited this <%= model.class.to_s.downcase %> from being saved </h2>
+ 3   <h2><%= translation('errors.template.header.other', :count => model.errors.count, :model => model.class.to_s.downcase) %></h2>
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

@DalilaBA DalilaBA added the first-timers-only They need to be well-formatted using the First-timers_Issue_Template. label Oct 5, 2021
@kkreine
Copy link
Contributor

kkreine commented Oct 5, 2021

Hi can I work on this issue?

@jywarren jywarren removed the first-timers-only They need to be well-formatted using the First-timers_Issue_Template. label Oct 5, 2021
@jywarren
Copy link
Member

jywarren commented Oct 5, 2021

Hi, I'm afraid this one isn't quite ready but once it is, we'd love your help!

@kkreine
Copy link
Contributor

kkreine commented Oct 5, 2021

@jywarren Thanks! I'll be happy to start whenever it's ready.

@DalilaBA
Copy link
Contributor Author

DalilaBA commented Oct 5, 2021

Hi @kkreine we are working on this, we will let you know as soon as it is ready

@DalilaBA
Copy link
Contributor Author

DalilaBA commented Oct 5, 2021

Hey @kkreine you can have the #10259 issue if you want

@kkreine
Copy link
Contributor

kkreine commented Oct 5, 2021

@DalilaBA Thank you!

@TildaDares
Copy link
Member

Hi @DalilaBA, is this issue ready now?

@DalilaBA
Copy link
Contributor Author

Hey, yes @TildaDares go ahead 😄

@TildaDares TildaDares added the first-timers-only They need to be well-formatted using the First-timers_Issue_Template. label Oct 10, 2021
@TildaDares
Copy link
Member

Reserved for @wajeehamushtaq

@wajeehamushtaq
Copy link
Contributor

Thanks, @TildaDares .

wajeehamushtaq added a commit to wajeehamushtaq/plots2 that referenced this issue Oct 11, 2021
@Pulkit007
Copy link
Contributor

Is this issue still open ?
If not can anyone assign me this

@TildaDares TildaDares removed the first-timers-only They need to be well-formatted using the First-timers_Issue_Template. label Oct 13, 2021
@TildaDares
Copy link
Member

Hi @Pulkit007, this issue isn’t ready yet.

@TildaDares
Copy link
Member

@DalilaBA Do you think we should close this?

@DalilaBA
Copy link
Contributor Author

@TildaDares yup I do unfortunately, sorry guys 😐

jywarren pushed a commit that referenced this issue Nov 16, 2021
…0359)

* Change Strings to Translation Function Call in _errorMessages.html.erb #10258

* Update _errorMessages.html.erb

* Fixes issue #10325

* update package

* update files

* Move question card template back

* Update yarn.lock
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this issue Dec 28, 2021
…bliclab#10359)

* Change Strings to Translation Function Call in _errorMessages.html.erb publiclab#10258

* Update _errorMessages.html.erb

* Fixes issue publiclab#10325

* update package

* update files

* Move question card template back

* Update yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants