Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move question card template back to questions/_questions.html.erb #10359

Merged
merged 11 commits into from
Nov 16, 2021

Conversation

wajeehamushtaq
Copy link
Contributor

Fixes #10325

Move question card template back to questions/_questions.html.erb

  • Update the file app/views/notes/_card.html.erb and the file app/views/questions/_questions.html.erb in the plots2 repository

@gitpod-io
Copy link

gitpod-io bot commented Oct 19, 2021

@wajeehamushtaq
Copy link
Contributor Author

wajeehamushtaq commented Oct 19, 2021

@TildaDares yarn.lock file did not update because my system have those dependencies. Can you please help me? These dependencies are in the main branch. How can I change versions of dependencies or something like this?

These "webpack": "^4.46.0" and "webpack-cli": "^3.3.12" dependencies added due to Setup React & webpacker by running

rails webpacker:install && rails webpacker:install:react && rails generate react:install

(for local SSL work, see SSL below)

@jywarren
Copy link
Member

Hi @wajeehamushtaq i think you may be able to run one of the commands linked here: https://www.w3docs.com/snippets/git/how-to-reset-or-revert-a-file-to-a-specific-revision.html#reverting-and-resetting-a-file-to-a-specific-version-2

Hope that helps!!! Otherwise you could just manually copy paste the yarn.lock from the publiclab/plots2 main branch, and commit that change and push it up. then it'll recognize that nothing differs. Make sense? Thanks a lot!!!

@codeclimate
Copy link

codeclimate bot commented Oct 20, 2021

Code Climate has analyzed commit 3c6e796 and detected 0 issues on this pull request.

View more on Code Climate.

@wajeehamushtaq
Copy link
Contributor Author

Thank you for the help @jywarren and @TildaDares. Now PR has only those files changed which it needs to change. Thanks a lot!!

@TildaDares TildaDares closed this Oct 21, 2021
@TildaDares TildaDares reopened this Oct 21, 2021
@TildaDares
Copy link
Member

TildaDares commented Oct 22, 2021

Hi @wajeehamushtaq, can you add a screenshot of the /questions page just to be sure everything works okay? Thanks!

@TildaDares TildaDares closed this Oct 30, 2021
@TildaDares
Copy link
Member

Hi @wajeehamushtaq, have you been able to get the screenshot? Do you need help with anything?

@TildaDares TildaDares reopened this Oct 30, 2021
@jywarren
Copy link
Member

I was able to get this booted - we need to update the GitPod ruby version! But, it looks good. Thank you!!!

@jywarren
Copy link
Member

image

@jywarren jywarren merged commit 0b5b6ab into publiclab:main Nov 16, 2021
@welcome
Copy link

welcome bot commented Nov 16, 2021

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
…bliclab#10359)

* Change Strings to Translation Function Call in _errorMessages.html.erb publiclab#10258

* Update _errorMessages.html.erb

* Fixes issue publiclab#10325

* update package

* update files

* Move question card template back

* Update yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move question card template back to questions/_questions.html.erb
3 participants