Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve text for welcome contribution notice #11424

Closed
6 tasks
first-timers bot opened this issue Sep 15, 2022 · 37 comments · Fixed by #11532
Closed
6 tasks

Improve text for welcome contribution notice #11424

first-timers bot opened this issue Sep 15, 2022 · 37 comments · Fixed by #11532
Labels
assigned first-timers-only They need to be well-formatted using the First-timers_Issue_Template. help wanted requires help by anyone willing to contribute

Comments

@first-timers
Copy link

first-timers bot commented Sep 15, 2022

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Claim the issue by commenting. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
💡 Learn how to claim 🙋

Claiming an issue

Unless the issue is marked as reserved for someone, you can just say "I'd like to try this!" and then you've claimed it - no need to wait for someone to assign it to you. Just be sure you link your pull request (PR) to this issue so we can see where your solution is.

And open one early if possible - even before you've completed it with additional commits - and others can help you figure out any issues you may face.

  • 📝 Update the file config/locales/en.yml in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -1133,10 +1133,17 @@ en:
     logged_out: "Successfully logged out."
   notes_controller:
     research_notes: "Research notes"
-    thank_you_for_contribution: "Success! Thank you for contributing open research,
-      and thanks for your patience while your post is approved by <a href='/wiki/moderation'>community
-      moderators</a> and we'll email you when it is published. In the meantime, if
-      you have more to contribute, feel free to do so."
+    thank_you_for_contribution: |
+      <h2>Success! You did it! Hooray!</h2>
+      <hr>
+      <p>Thank you so much for contributing open research and being part of our community.</p>
+      <h2>Here's what's happening now:</h2>
+      <hr>
+      <p>Your <a href='/wiki/first-contribution'>first contribution</a> is awaiting approval by <a href='/wiki/moderation'>community moderators</a>. 
+      <b>If you have asked an urgent question about an environmental concern, we will prioritize reviewing it</b>.
+      Thank you for your patience, in the next hours your contribution should be public. We'll email you when it is published.
+      In the meantime, if you have more to contribute, feel free to do so. Visit the <a href='/wiki/welcome'>Welcome Page</a> to discover more ways to connect.
+      </p>
     thank_you_for_question: "Success! Thank you for contributing with a question, and
       thanks for your patience while your question is approved by <a href='/wiki/moderation'>community
       moderators</a> and we'll email you when it is published."

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -296,7 +296,16 @@ class NotesControllerTest < ActionController::TestCase
          }
     # , :main_image => "/images/testimage.jpg"

-    assert_equal "Success! Thank you for contributing open research, and thanks for your patience while your post is approved by <a href='/wiki/moderation'>community moderators</a> and we'll email you when it is published. In the meantime, if you have more to contribute, feel free to do so.", flash[:notice]
+    assert_equal "<h2>Success! You did it! Hooray!</h2>
+      <hr>
+      <p>Thank you so much for contributing open research and being part of our community.</p>
+      <h2>Here's what's happening now:</h2>
+      <hr>
+      <p>Your <a href='/wiki/first-contribution'>first contribution</a> is awaiting approval by <a href='/wiki/moderation'>community moderators</a>.
+      <b>If you have asked an urgent question about an environmental concern, we will prioritize reviewing it</b>.
+      Thank you for your patience, in the next hours your contribution should be public. We'll email you when it is published.
+      In the meantime, if you have more to contribute, feel free to do so. Visit the <a href='/wiki/welcome'>Welcome Page</a> to discover more ways to connect.
+      </p>", flash[:notice]
     assert_nil flash[:warning] # no double notice
     assert_equal 4, Node.last.status
     assert_equal title, Node.last.title
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are not familiar with GitHub or the pull request model, here is a guide you can follow on how GitHub works.

  2. If you are familiar with the terminal or would like to learn to use it, here is a great tutorial on how to send a pull request using the terminal.

  3. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below, and reach out in our chatroom!

@first-timers first-timers bot added first-timers-only They need to be well-formatted using the First-timers_Issue_Template. help wanted requires help by anyone willing to contribute labels Sep 15, 2022
@cesswairimu
Copy link
Collaborator

reserved for @OlawaleYaqub

@gayatri1661
Copy link

can i work on this

@priyda
Copy link

priyda commented Sep 17, 2022

"I'd like to try this!"

priyda added a commit to priyda/plots2 that referenced this issue Sep 17, 2022
Changes for issue : Improve text for welcome contribution notice publiclab#11424"
@priyda priyda mentioned this issue Sep 17, 2022
@Vinayakkamble07
Copy link

I'd like to try this!. Can I work on this?

@Roza133
Copy link

Roza133 commented Sep 19, 2022

I'd like to try this!

1 similar comment
@BiLaL-159
Copy link

I'd like to try this!

@akashthedeveloper
Copy link

@cesswairimu I would like to take up this issue. Can you please help me to understand this issue and what needs to be done?

@klaus139
Copy link

klaus139 commented Oct 8, 2022

can i work on this

@NPDebs
Copy link

NPDebs commented Oct 9, 2022

Hi. Can I work on this issue, please? 👀

@belfarz
Copy link

belfarz commented Oct 9, 2022

i want to try this

@belfarz
Copy link

belfarz commented Oct 9, 2022

i have created a pull request

@jywarren
Copy link
Member

jywarren commented Oct 9, 2022

Hello, as this was originally for @OlawaleYaqub but we did not hear from them in a while, I'm going to let @belfarz take it, since there has already been a PR for it raised. However, for future issues, please sign up for an issue at #11105 or check if the previous person is still working on it, and we would like to respect who asked first, going forward. Thank you!

@belfarz
Copy link

belfarz commented Oct 10, 2022 via email

@ChiomaNwosisi
Copy link

i'll like to try this

@banjo-tech
Copy link
Contributor

This will be great to work on.

@Favour-Cay
Copy link

@OlawaleYaqub if you need any assist ,im happy to help

@cesswairimu
Copy link
Collaborator

Hi @banjo-tech and @Favour-Cay is any of you an Outreachy applicant and haven't been assigned first-timer issue yet? If so, please leave a comment and you can claim this, the previous assignee had already worked on a FTO and has freed this. Thanks

@akashthedeveloper
Copy link

Hii @cesswairimu I am outreachy applicant too can you assign me this issue.

@cesswairimu
Copy link
Collaborator

Hi akashthedeveloper, sure, go ahead. Thanks

@banjo-tech
Copy link
Contributor

Hi @cesswairimu I'm an outreachy applicant and I would like to work on this

@Favour-Cay
Copy link

omg im just seeing this @cesswairimu is there another free FTO i can work on pls

@cesswairimu
Copy link
Collaborator

Hi @banjo-tech, seems @akashthedeveloper hasn't started on it yet, you can go ahead and work on this -- as you were the first to express interest , @Favour-Cay I will ping when I find one, thanks

@banjo-tech
Copy link
Contributor

I will do that thank you

@banjo-tech
Copy link
Contributor

@cesswairimu I have made the changes to the first file and created a pull request.
However, I can't do the same to the second file because" assert_equal "Success! Thank you for contributing open research, and thanks for your patience while your post is approved by community moderators and we'll email you when it is published. In the meantime, if you have more to contribute, feel free to do so.", flash[:notice]" - this text is not in line 296

@cesswairimu
Copy link
Collaborator

gotcha @banjo-tech, seems they have been some changes in the file.., its on line 313, could you please check. thanks

@banjo-tech
Copy link
Contributor

okay I will thank you

@professorabhay
Copy link

I want to work on this. It seems easy. I can do this in an hour and raise a PR to check and merge.

@goelayush89
Copy link

I want to work on this issue

@cesswairimu
Copy link
Collaborator

Hi @goelayush89, we are trying to fix the failing tests here #11532, we would love your help if you have any ideas? Thanks

@Sreejith2
Copy link

Hi I would like to try this

@lata-11
Copy link

lata-11 commented Jan 18, 2023

Hey! is this issue still open? If yes, I would like to work on this. Please assign.

@Sreejith2
Copy link

Hey! is this issue still open? If yes, I would like to work on this. Please assign.

same doubt.

@7malikk
Copy link
Contributor

7malikk commented Jan 19, 2023

Hello @Sreejith2 and @lata-11, if you take a look at PR #11532, you'd notice some tests have failed, you both could suggest ways to resolve this. Thank you!

@lata-11
Copy link

lata-11 commented Jan 19, 2023

Oh Okay I am trying

@pankajkrbansal
Copy link

I'd like to try this!

@b-shears
Copy link

b-shears commented Jan 29, 2023

Hello, I would like to contribute to this issue. If I am understanding these comments correctly, someone has submitted a PR to fix the issue. But some tests are failing. Has this been resolved? If not, I would like to take a look at the issue, so I can get my first contribution to public lab.

@cesswairimu
Copy link
Collaborator

hi @pankajkrbansal and @b-shears, the failing tests have been fixed , feel free to browse some of the other open issues, we would love your help. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned first-timers-only They need to be well-formatted using the First-timers_Issue_Template. help wanted requires help by anyone willing to contribute
Projects
None yet