Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "IgnoredMethods has been renamed to AllowedMethods and/or AllowedPatterns" rubocop warning #11527

Closed
5 tasks
first-timers bot opened this issue Oct 21, 2022 · 9 comments
Closed
5 tasks
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template. help wanted requires help by anyone willing to contribute

Comments

@first-timers
Copy link

first-timers bot commented Oct 21, 2022

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from underrepresented groups in free and open-source software!

We know that the process of creating a pull request is one of the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Claim the issue by commenting. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
💡 Learn how to claim 🙋

Claiming an issue

Unless the issue is marked as reserved for someone, you can just say "I'd like to try this!" and then you've claimed it - no need to wait for someone to assign it to you. Just be sure you link your pull request (PR) to this issue so we can see where your solution is.

And open one early if possible - even before you've completed it with additional commits - and others can help you figure out any issues you may face.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -64,7 +64,7 @@ Style/BlockDelimiters:
   - let!
   - subject
   - watch
-  IgnoredMethods:
+  AllowedMethods:
   - lambda
   - proc
   - it
@@ -415,7 +415,7 @@ Layout/SpaceInsideStringInterpolation:
   - no_space
 
 Style/SymbolProc:
-  IgnoredMethods:
+  AllowedMethods:
   - respond_to
   - define_method
 
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are not familiar with GitHub or the pull request model, here is a guide you can follow on how GitHub works.

  2. If you are familiar with the terminal or would like to learn to use it, here is a great tutorial on how to send a pull request using the terminal.

  3. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in the comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below, and reach out in our chatroom!

@first-timers first-timers bot added first-timers-only They need to be well-formatted using the First-timers_Issue_Template. help wanted requires help by anyone willing to contribute labels Oct 21, 2022
@cesswairimu
Copy link
Collaborator

Reserved for Nadifa Hersi

@NadifaHersi
Copy link
Contributor

Hi @TildaDares @cesswairimu I would like to try this issue. Thank you so much.

@cesswairimu
Copy link
Collaborator

go ahead @NadifaHersi

NadifaHersi added a commit to NadifaHersi/plots2 that referenced this issue Oct 23, 2022
I fixed the assigned issue publiclab#11527 by updating the file .rubocop_shopify_styleguide.yml.
I have removed IgnoredMethods: in line 67 and added AllowedMethods:
I have also removed IgnoredMethods: in line 417 and added AllowedMethods:
@NadifaHersi
Copy link
Contributor

Hi @TildaDares @cesswairimu @jywarren I have fixed issue #11527 and created pull request #11533 .

@NadifaHersi
Copy link
Contributor

NadifaHersi commented Oct 23, 2022 via email

jywarren pushed a commit that referenced this issue Oct 23, 2022
I fixed the assigned issue #11527 by updating the file .rubocop_shopify_styleguide.yml.
I have removed IgnoredMethods: in line 67 and added AllowedMethods:
I have also removed IgnoredMethods: in line 417 and added AllowedMethods:
@cesswairimu
Copy link
Collaborator

Resolved in #11533. thanks @NadifaHersi

@NadifaHersi
Copy link
Contributor

HI @TildaDares, @jywarren , @cesswairimu , What is the next activity?

@NadifaHersi
Copy link
Contributor

Hi @TildaDares , @jywarren , @cesswairimu I would like to get some clarifications on this comment during submission of the application:

@NadifaHersi
Copy link
Contributor

Hi @TildaDares , @jywarren , @cesswairimu I would like to get some clarifications on this comment during submission of the application:
Please work with your mentor to provide a timeline of the work you plan to accomplish on the project and what tasks you will finish at each step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template. help wanted requires help by anyone willing to contribute
Projects
None yet
Development

No branches or pull requests

2 participants