-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .rubocop_shopify_styleguide.yml #11533
Conversation
I fixed the assigned issue publiclab#11527 by updating the file .rubocop_shopify_styleguide.yml. I have removed IgnoredMethods: in line 67 and added AllowedMethods: I have also removed IgnoredMethods: in line 417 and added AllowedMethods:
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Code Climate has analyzed commit c7d0114 and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thank you!
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. You can also join our Gitter channel to connect with other contributors 📥 |
@TildaDares , @jywarren , @cesswairimu What is next? |
@NadifaHersi you can browse on non-"first-timer-only" issues and comment on any you would like to work on, rem to check the comments to see if anyone is already working on it. thanks |
@TildaDares , @cesswairimu , @jywarren , Can I record my contribution to issue #11533 now Or I contribute to other issues and record all of them at one time? |
@NadifaHersi you can do either, that's fine, just rem to record all your contributions before the deadline. Thanks |
I fixed the assigned issue #11527 by updating the file .rubocop_shopify_styleguide.yml.
I have removed IgnoredMethods: in line 67 and added AllowedMethods:
I have also removed IgnoredMethods: in line 417 and added AllowedMethods:
Fixes #0000
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment below