Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

page broken at /map/northern-virginia-community-college-sterling-virginia/03-07-2014 #131

Closed
adamdgriffith opened this issue Jul 28, 2014 · 7 comments
Labels
bug the issue is regarding one of our programs which faces problems when a certain task is executed fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet help wanted requires help by anyone willing to contribute Ruby

Comments

@adamdgriffith
Copy link

adamdgriffith commented Jul 28, 2014

This has been marked as a good candidate for becoming a first-timers-only issue like these, meaning that it's simple, self-contained, and with some extra formatting, could be a great entry point for a new contributor. If you're familiar enough with this code, please consider reformatting or reposting it as a first-timers-only issue, and then ping @jywarren to get it labelled.


http://publiclab.org/map/northern-virginia-community-college-sterling-virginia/03-07-2014

@jywarren
Copy link
Member

Hi, Adam - where did you see the link to that map?

On Mon, Jul 28, 2014 at 4:05 PM, adamdgriffith notifications@github.com
wrote:

http://publiclab.org/map/northern-virginia-community-college-sterling-virginia/03-07-2014


Reply to this email directly or view it on GitHub
#131.

@jywarren
Copy link
Member

The error I see is:

Completed 500 Internal Server Error in 258ms

ActionView::Template::Error (undefined method `tms' for nil:NilClass):
1: </div>
2: <iframe style="width:100%;border:none;background:#ddd;margin-bottom:8px;" height="375" src="http://archive.publiclaboratory.org/leaflet/?tms=<%= @node.map.tms %>&lon=<%= @node.lon %>&lat=<%= @node.lat %>&zoom=<%= @node.map.min_zoom+1 %>"></iframe>
3: 
4: <div class="row-fluid">
5:   <%= render :partial => "sidebar/related" %>
app/views/map/show.html.erb:2:in `_app_views_map_show_html_erb___64319787606996866_46932220'

@jywarren
Copy link
Member

@adamdgriffith
Copy link
Author

I was browsing the archive.

On Mon, Jul 28, 2014 at 5:34 PM, Jeffrey Warren notifications@github.com
wrote:

http://publiclab.org/map/edit/10126

Reply to this email directly or view it on GitHub
#131 (comment).

@jywarren jywarren changed the title dead link page broken at /map/northern-virginia-community-college-sterling-virginia/03-07-2014 Apr 1, 2015
@jywarren jywarren added the bug the issue is regarding one of our programs which faces problems when a certain task is executed label Apr 1, 2015
@ananyo2012
Copy link
Member

@jywarren Can you check this once more? I think this is the reason causing #981

@jywarren jywarren added fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet help wanted requires help by anyone willing to contribute Ruby labels Nov 14, 2016
@jywarren
Copy link
Member

This is probably independent -- the error could be solved by adding a if @node.map conditional before calling @node.map.tms.

Good first-timers issue!

@jywarren
Copy link
Member

Reformatted this issue into #1026, closing this one now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug the issue is regarding one of our programs which faces problems when a certain task is executed fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet help wanted requires help by anyone willing to contribute Ruby
Projects
None yet
Development

No branches or pull requests

3 participants