Map page breaks with no @node.map.tms check

[jywarren]

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

The problem

The map page at http://publiclab.org/map/northern-virginia-community-college-sterling-virginia/03-07-2014 shows an error, with a server log output of the following:

Completed 500 Internal Server Error in 258ms

ActionView::Template::Error (undefined method `tms' for nil:NilClass):
2: <iframe style="width:100%;border:none;background:#ddd;margin-bottom:8px;" height="375" src="http://archive.publiclaboratory.org/leaflet/?tms=<%= @node.map.tms %>&lon=<%= @node.lon %>&lat=<%= @node.lat %>&zoom=<%= @node.map.min_zoom+1 %>"></iframe>
app/views/map/show.html.erb:2:in `_app_views_map_show_html_erb___64319787606996866_46932220'

It's supposed to show a map similar to this page: https://publiclab.org/map/barataria-site-abh1-barataria-bay-louisiana/07-25-2014

This issue reformats and replaces #131.

Solution

The error is on line 2 of:

https://github.com/publiclab/plots2/tree/master/app/views/map/show.html.erb:L2

The error could be solved by adding a if @node.map conditional around the line that uses @node.map.tms:

<% if @node.map %>
  <iframe style="width:100%;border:none;background:#ddd;margin-bottom:8px;" height="375" src="//archive.publiclab.org/leaflet/?tms=<%= @node.map.tms %>&lon=<%= @node.lon %>&lat=<%= @node.lat %>&zoom=<%= @node.map.min_zoom+1 %>"></iframe>
<% end %>

Steps to Fix

• claim this issue with a comment here, below, and ask any clarifying questions you need
• set up a repository locally following the README instructions, and make sure that all tests pass
• try to fix the issue following the steps above, but even before you're done, you can:
• commit your changes and start a pull request (see contributing to Public Lab software) but mark it as "in progress" if you have questions or if you haven't finished
• alert someone via the developers list (see below) to have your pull request merged. This may take a few extra steps depending on when you do it, but we'll help you out!

Please email the developers list (see https://publiclab.org/developers) if you have questions!

[wvward]

I'd like to contribute to this issue. I've read through the README & requested an invite to C9.io.

[jywarren]

Oh that would be so super, thank you will! Don't hesitate to ask if you need any help.

…

On Nov 28, 2016 6:12 PM, "wvward" ***@***.***> wrote: I'd like to contribute to this issue. I've read through the README & requested an invite to C9.io. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1026 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ5uo7c92CRnGh4h82D-7HsQGdthPks5rC1_PgaJpZM4K91So> .

[jywarren]

Hi, just checking if you've gotten stuck on this at all, or if I could help in any way? Thanks!

[wvward]

Hi, Jeff- I haven't been able to work on it as much this last week. I have been following the 15 minutes/week commitment too closely. I'll check in soon & update. Thanks for checking on me, Will

[jywarren]

No problem at all -- and no need to increase time commitment -- just wanted to check in! Thanks, Will

…

On Thu, Dec 8, 2016 at 3:44 PM, wvward ***@***.***> wrote: Hi, Jeff- I haven't been able to work on it as much this last week. I have been following the 15 minutes/week commitment too closely. I'll check in soon & update. Thanks for checking on me, Will On Dec 7, 2016 3:08 PM, "Jeffrey Warren" ***@***.***> wrote: Hi, just checking if you've gotten stuck on this at all, or if I could help in any way? Thanks! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1026 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ ADs3ZJ0q9PQ0kzMse9HoJY2OReSSyojWks5rFyBcgaJpZM4K91So> . — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1026 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ-jFc7S_dW6Tz40lv-Pkc1XZdWgYks5rGGw9gaJpZM4K91So> .

[Connerh92]

Hello, I noticed this was still open and it has been over a month since the last person had messaged, so I was wondering if I could have a go at this issue and fix it. Thanks!

[ananyo2012]

@Connerh92 Sure you can take this up

[jywarren]

Yes, and happy to help if you need any input! Thanks!

…

On Tue, Jan 31, 2017 at 8:25 AM, Ananyo Maiti ***@***.***> wrote: @Connerh92 <https://github.com/Connerh92> Sure you can take this up — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1026 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ2-K8ch8AVDwbC35IKmGV7f2D3tNks5rXzZRgaJpZM4K91So> .

[VishalRocks]

Hi I saw this issue open, can I solve this?

[jywarren]

Perhaps @Connerh92 is still working on it? If not, you can find more problems to solve here:

https://github.com/publiclab/plots2/projects/2?fullscreen=true

thank you!!!

[jywarren]

@Connerh92, are you still working on this? If not, @VishalRocks, you can probably give it a try!

[VishalRocks]

I have done it..but how to test it in local? I tried url localhost:3000/map/northern-virginia-community-college-sterling-virginia/03-07-2014

[wvward]

And glad others picked up where I left off (the beginning)! :)

…

On Feb 20, 2017 1:35 PM, "Vishal Sharma" ***@***.***> wrote: I have done it..but how to test it in local? I tried url localhost:3000/map/northern-virginia-community-college- sterling-virginia/03-07-2014 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1026 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADs3ZL0o3me7aZKKEZWmo7SRHqReXk7eks5reer0gaJpZM4K91So> .

[jywarren]

Hi all! To test, start by opening a pull request and we can add a test then. Sound good?

…

On Feb 20, 2017 3:01 PM, "wvward" ***@***.***> wrote: And glad others picked up where I left off (the beginning)! :) On Feb 20, 2017 1:35 PM, "Vishal Sharma" ***@***.***> wrote: > I have done it..but how to test it in local? I tried url > localhost:3000/map/northern-virginia-community-college- > sterling-virginia/03-07-2014 > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#1026 (comment) >, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ ADs3ZL0o3me7aZKKEZWmo7SRHqReXk7eks5reer0gaJpZM4K91So> > . > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1026 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ8VZRCI4jeYGxpLtoPFaT_BrAhB2ks5refEPgaJpZM4K91So> .

[VishalRocks]

Sure..this is the pull request #1285

[jywarren]

Great, solved over there!