Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contribution guidelines #2341

Closed
SidharthBansal opened this issue Feb 15, 2018 · 26 comments
Closed

Update contribution guidelines #2341

SidharthBansal opened this issue Feb 15, 2018 · 26 comments
Assignees
Labels
gci-candidate more-detail-please issue lacks proper description and perhaps needs code links or the location of the problem

Comments

@SidharthBansal
Copy link
Member

Please describe the problem (or idea)

At public labs we are now using a new pr label and issue label system as discussed in #2231. One problem with the new label system is the newcomers are not having knowledge of our existing label system

What happened just before the problem occurred? Or what problem could this idea solve?
I think one solution is to include the link to the contributors page (https://github.com/publiclab/plots2/blob/master/CONTRIBUTING.md) in all the first timers issue so that they will read and do the prs accordingly.
For that we need to change the contributors page
This is a part of #2231
@jywarren @ebarry what do you suggest??

@SidharthBansal SidharthBansal added the more-detail-please issue lacks proper description and perhaps needs code links or the location of the problem label Feb 15, 2018
@jywarren
Copy link
Member

jywarren commented Feb 15, 2018 via email

@SidharthBansal
Copy link
Member Author

I am little bit inclined to teaching them how to add labels if they don't know how to add them.
It is easy. Only they need to select labels from sidebar

@SidharthBansal SidharthBansal self-assigned this Feb 15, 2018
@jywarren
Copy link
Member

Oh, sorry i meant like are we sure they even have permissions to change labels? I sometimes forget what i'm able to do as a maintainer :-)

@jywarren
Copy link
Member

+1 teaching!

@SidharthBansal
Copy link
Member Author

No, they can't add labels. So, let's think what alternative can be adopted.

@SidharthBansal
Copy link
Member Author

My mistake 😢

@jywarren
Copy link
Member

jywarren commented Feb 15, 2018 via email

@jywarren
Copy link
Member

jywarren commented Feb 15, 2018 via email

@SidharthBansal
Copy link
Member Author

We can check this. I will create a new account now and see what happens

@ghost
Copy link

ghost commented Feb 15, 2018

Asking them to ping is a great option
Can you please assign this issue to this id so that I can check if anyhow I can add labels to this specific issue.

@jywarren
Copy link
Member

oh, darn -- you can't assign issues to someone who's not a contributor! :-(

@SidharthBansal
Copy link
Member Author

Added to GCI dashboard

@SidharthBansal
Copy link
Member Author

This task is published on GCI dashboard. Thanks all.

@oorjitchowdhary
Copy link
Member

Is this issue still open? I'd like to work on it... I'm a GCI candidate.

@SidharthBansal
Copy link
Member Author

Yeah

@oorjitchowdhary
Copy link
Member

https://github.com/publiclab/plots2/blob/master/CONTRIBUTING.md
I have to update this right?
And what all is the necessary and relevant info that could be added here...

@SidharthBansal
Copy link
Member Author

#2231

@SidharthBansal
Copy link
Member Author

Location is right

@oorjitchowdhary
Copy link
Member

Which is the file to be updated? Or I have to make a PR for this issue?

@SidharthBansal
Copy link
Member Author

I think we need to create a new file in doc folder.
Can you define all the labels there?
We will review and tell about the patches?
You can refer other documents to see how to write the documents.

@oorjitchowdhary
Copy link
Member

Ok... It can be like this file right? https://github.com/publiclab/plots2/blob/master/doc/GCI_MENTOR_GUIDELINES.md

@SidharthBansal
Copy link
Member Author

SidharthBansal commented Nov 15, 2018 via email

@oorjitchowdhary
Copy link
Member

Ohk.. Then I'll claim this task on the GCI platform

@oorjitchowdhary oorjitchowdhary mentioned this issue Nov 15, 2018
4 tasks
@oorjitchowdhary
Copy link
Member

Pls review #3981 ... Thanks.. 😄

@SidharthBansal
Copy link
Member Author

@oorjitchowdhary can you please close #2341 and #2231 once #3981 is merged?

@oorjitchowdhary
Copy link
Member

@SidharthBansal Okay sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gci-candidate more-detail-please issue lacks proper description and perhaps needs code links or the location of the problem
Projects
None yet
Development

No branches or pull requests

4 participants