-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
increase default image embedding size to "large" #329
Comments
As you add the We recently wrote about how we do that at Hoodie, maybe that’ll help? http://hood.ie/blog/starter-issues.html |
Of course, and thanks, that's a great example to work from. I'll post something in the next 15min or so. |
How's this, @gr2m ? |
amazing, thanks a lot Jeffrey, from own experience I can tell this means a lot to people new your project and to Open Source in general :) With that you could also ping @YourFirstPR to give a shout out. |
By the way I’m co-hosting a "Welcome to Open Source" workshop in Atlanta on April 2nd, would you prepare an issue like this for the participants to work on during the workshop? We have a GitHub repository where you could link the issues you prepared for the event: I’ll reach out to more projects soon, so timing is perfect :) Let me know if you have any questions. And sorry for the noise in your issue comments here, feel free to ping me on Twitter @gr2m |
For sure. I went ahead and made a list of such issues (and built out similar guidance docs):
first-timers-only
Haha, i actually don't use twitter (except for my github issue bot), but we could open an issue called "preparing issues for newcomers" and talk there, or my email is jeff@publiclab.org. :-) BTW, how do you typically deal with converting submitted issues, posted by someone else, into a nice issue like this? |
Thanks Jeffrey, I’ll send you an email next week regarding issues for the event 👍
I usually create a follow up issue with more instructions, and then close the issue posted by someone else with something like "closing in favor of #1234" |
@jywarren Hi Jeffrey. This is Yash. I'd like to work on this issue and get it fixed. |
Oh, awesome. Please tell me if there's anything you need to get started! On Wed, Mar 23, 2016 at 5:39 PM, ykl7 notifications@github.com wrote:
|
I'll let you know if anything comes up. |
Hi, @ykl7, just a heads up that we've tweaked the database configuration a bit -- read up here on how to get running if you have trouble! https://groups.google.com/forum/#!topic/plots-dev/bFN2TX85h3g |
@jywarren Thanks for the tip Jeffrey. I was following one of the issues where this topic was broached. I'll implement the necessary changes in my local repository and proceed accordingly. |
Great! I'm also going to make some time to better document some more Thanks!
|
Hi @ykl7! Thank you again for your valuable contribution to Public Lab. I would like to invite you to join us in a video conference to say a few words about what you contributed and how your experience was. The event is https://publiclab.org/openhour, and it’s coming right up on November 7th, at 1pm EDT which is UTC/GMT -4. Please feel free to respond here, or else email liz@publiclab.org, stevie@publiclab.org, jeff@publiclab.org. |
The problem
Images in research notes, comments, and wiki pages on PublicLab.org are inserted into content at the
:medium
size, by default. This is a bit narrow these days -- 500px wide. To test this, go to https://publiclab.org/post (after logging in) and drag an image into the main text body field. Wait for the markup to appear; it should say something like:See how this is the Markdown for displaying the
medium
image, surrounded by the link for theoriginal
image, so you see that when you click on the image? We want themedium
one to belarge
.Solution
800px is more appropriate. Screens are bigger now! And we have responsive styles so they'll scale down if the window is not big enough.
The code to change this is in two places; first, on this line in the server-side Ruby code by using
.path(:large)
, I believe, instead of just.path
:https://github.com/publiclab/plots2/blob/master/app/controllers/images_controller.rb#L28
Then the
:medium
in JavaScript on this line must be changed to:large
too: https://github.com/publiclab/plots2/blob/master/app/assets/javascripts/dragdrop.js#L64Steps to fix
Please email the developers list (see https://publiclab.org/developers) if you have questions!
The text was updated successfully, but these errors were encountered: